You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/12/08 16:39:00 UTC

[jira] [Commented] (SOLR-10458) setFollowRedirects should be deprecated in favor of SolrClientBuilder methods

    [ https://issues.apache.org/jira/browse/SOLR-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644892#comment-17644892 ] 

ASF subversion and git services commented on SOLR-10458:
--------------------------------------------------------

Commit 46bce2382f8c4a5556b6c4f00754d3a764b973c2 in solr's branch refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=46bce2382f8 ]

SOLR-10458: setFollowRedirects should be deprecated in favor of Solr Client Builder methods (#1216)

Fix followRedirect property on HttpSolrClient not set when using Builder pattern.  Migrated tests to use Builder.

> setFollowRedirects should be deprecated in favor of SolrClientBuilder methods
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-10458
>                 URL: https://issues.apache.org/jira/browse/SOLR-10458
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Assignee: Eric Pugh
>            Priority: Minor
>             Fix For: 7.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setFollowRedirects}} setter on all {{SolrClient}} implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org