[GitHub] [openwhisk] style95 commented on a change in pull request #4982: Fix Swagger and API mismatch for action, trigger, rule list

[GitBox <gi...@apache.org>]

style95 commented on a change in pull request #4982:
URL: https://github.com/apache/openwhisk/pull/4982#discussion_r496415227



##########
File path: tests/src/test/scala/system/rest/SwaggerTests.scala
##########
@@ -46,6 +46,20 @@ class SwaggerTests extends FlatSpec with Matchers with RestUtil {
     response.body().asString().contains("\"swagger\":") should be(true)
   }
 
+  it should "respond to /api-docs including ActionMeta/ActionExecMeta/RuleMeta/TriggerMeta" in {
+    val response = RestAssured.given().config(sslconfig).get(getServiceURL() + "/api/v1/api-docs")
+
+    response.statusCode() should be(200)
+    response.body().asString().contains("\"#/definitions/ActionMeta\"") should be(true)

Review comment:
       Since the controller just returns the content of the swagger JSON file, I am not quite sure it is meaningful.
   We need to better way to make the swagger JSON file conforms to the actual APIs controllers provide.
   
   But have no idea yet..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org