[jira] [Work logged] (BEAM-7520) DirectRunner timers are not strictly time ordered

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-7520?focusedWorklogId=305123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305123 ]

ASF GitHub Bot logged work on BEAM-7520:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Sep/19 09:58
            Start Date: 02/Sep/19 09:58
    Worklog Time Spent: 10m 
      Work Description: je-ik commented on issue #9190: [BEAM-7520] Fix timer firing order in DirectRunner
URL: https://github.com/apache/beam/pull/9190#issuecomment-527086028
 
 
   @kennknowles @reuvenlax The added @ValidatesRunner fails on Dataflow. It looks to me, that it should pass, but cannot tell for sure. Can you check this?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 305123)
    Time Spent: 9h 10m  (was: 9h)

> DirectRunner timers are not strictly time ordered
> -------------------------------------------------
>
>                 Key: BEAM-7520
>                 URL: https://issues.apache.org/jira/browse/BEAM-7520
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>    Affects Versions: 2.13.0
>            Reporter: Jan Lukavský
>            Assignee: Jan Lukavský
>            Priority: Major
>          Time Spent: 9h 10m
>  Remaining Estimate: 0h
>
> Let's suppose we have the following situation:
>  - statful ParDo with two timers - timerA and timerB
>  - timerA is set for window.maxTimestamp() + 1
>  - timerB is set anywhere between <windowStart, windowEnd), let's denote that timerB.timestamp
>  - input watermark moves to BoundedWindow.TIMESTAMP_MAX_VALUE
> Then the order of timers is as follows (correct):
>  - timerB
>  - timerA
> But, if timerB sets another timer (say for timerB.timestamp + 1), then the order of timers will be:
>  - timerB (timerB.timestamp)
>  - timerA (BoundedWindow.TIMESTAMP_MAX_VALUE)
>  - timerB (timerB.timestamp + 1)
> Which is not ordered by timestamp. The reason for this is that when the input watermark update is evaluated, the WatermarkManager,extractFiredTimers() will produce both timerA and timerB. That would be correct, but when timerB sets another timer, that breaks this.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)