You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2023/03/22 22:31:56 UTC

[GitHub] [datasketches-java] leerho opened a new pull request, #436: I discovered another bug in the design of the method

leerho opened a new pull request, #436:
URL: https://github.com/apache/datasketches-java/pull/436

   getQuantiles(evenlySpaced).
   
   The general method in QuantilesUtil.evenlySpacedFloats which is used in several places in the library was also being used in the getQuantiles(evenlySpaced) method.  It turns out that for the getQuantiles, the evenlySpaced algo must omit 0.0, which the general method does not.  It really needs its own generator for the evenly spaced ranks.
   
   Given that I fixed this issue, the documentation was also not correct, so the javadocs had to be revised, again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-java] jmalkin commented on pull request #436: I discovered another bug in the design of the method

Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on PR #436:
URL: https://github.com/apache/datasketches-java/pull/436#issuecomment-1526944669

   I'm a little confused. This PR was approved weeks ago, but then new commits were added without merging. And then we had a request for a new review and in the time since then there were yet more updates.
   
   The last seems to have been a merge from master, which shouldn't even be part of a PR as that can pull in unrelated conflicts that increase the length of the code to review unnecessarily.
   
   Anyway, as this is still changing the review request seems premature. Please let us know when the branch is done and ready for review. And once approved, please merge and use a new branch for subsequent fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-java] leerho commented on pull request #436: I discovered another bug in the design of the method

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on PR #436:
URL: https://github.com/apache/datasketches-java/pull/436#issuecomment-1527853246

   This PR is ready to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-java] leerho merged pull request #436: I discovered another bug in the design of the method

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #436:
URL: https://github.com/apache/datasketches-java/pull/436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-java] leerho commented on pull request #436: I discovered another bug in the design of the method

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on PR #436:
URL: https://github.com/apache/datasketches-java/pull/436#issuecomment-1527852755

   My apologies.  The runs using GitHub Actions reveal Javadoc issues that do not show up when I run javadoc locally.  Next time I will try testing the GitHub Actions on my personal GH repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org