You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/05 09:58:23 UTC
[GitHub] [incubator-doris] jackwener opened a new pull request #7307: [enhancement] add more content of gitignore file
jackwener opened a new pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307
## Proposed changes
Ignore the `target` file in samples/doris-demo/
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7307: [enhancement] add more content of gitignore file
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307#discussion_r762707428
##########
File path: .gitignore
##########
@@ -65,7 +65,13 @@ docs/package-lock.json
fe/fe-common/.classpath
rpc_data/
+## ignore sample target
Review comment:
you crash those to samples/doris-demo/*/target
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7307: [enhancement] add more content of gitignore file
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7307: [enhancement] add more content of gitignore file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307#issuecomment-988436689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7307: [enhancement] add more content of gitignore file
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307#discussion_r762707555
##########
File path: .gitignore
##########
@@ -65,7 +65,13 @@ docs/package-lock.json
fe/fe-common/.classpath
rpc_data/
+## ignore sample target
+samples/doris-demo/stream-load-demo/target
+samples/doris-demo/spring-jdbc-demo/target
+samples/doris-demo/flink-demo/target
+samples/doris-demo/spark-demo/target
-#ignore vscode project file
+# ignore vscode project file
.vscode
-samples/doris-demo/stream-load-demo/target
+
+
Review comment:
Just one blank line is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a change in pull request #7307: [enhancement] add more content of gitignore file
Posted by GitBox <gi...@apache.org>.
jackwener commented on a change in pull request #7307:
URL: https://github.com/apache/incubator-doris/pull/7307#discussion_r762726101
##########
File path: .gitignore
##########
@@ -65,7 +65,13 @@ docs/package-lock.json
fe/fe-common/.classpath
rpc_data/
+## ignore sample target
+samples/doris-demo/stream-load-demo/target
+samples/doris-demo/spring-jdbc-demo/target
+samples/doris-demo/flink-demo/target
+samples/doris-demo/spark-demo/target
-#ignore vscode project file
+# ignore vscode project file
.vscode
-samples/doris-demo/stream-load-demo/target
+
+
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org