You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/22 05:42:00 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
nvazquez opened a new pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images/direct-download` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577113629
Thanks @DaanHoogland, comments are sorted out using your suggestions
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594342163
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577019822
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595060297
@DaanHoogland @andrijapanicsb cc @borisstoyanov @PaulAngus this is ready to merge, please advice if any manual testing is complete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589492299
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593428741
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-581005846
@nvazquez last run nearing perfection ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591998249
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577122692
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594582539
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez opened a new pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595319172
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595664709
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589004119
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589482181
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589487648
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594331037
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-586119824
Is this ready or still in progress @nvazquez ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591767988
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594349059
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593418143
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez opened a new pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591807800
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594583438
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-586147383
@rhtyd as i understand it it is based on #3731 so it will have to wait. @nvazquez ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579593653
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589615334
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-581005877
rekicking some individual travis jobs 🛑
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577113698
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage
provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369454279
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1693,38 +1696,77 @@ private DirectTemplateDownloader getDirectTemplateDownloaderFromCommand(DirectDo
@Override
public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand cmd) {
final PrimaryDataStoreTO pool = cmd.getDestPool();
- if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
- return new DirectDownloadAnswer(false, "Unsupported pool type " + pool.getPoolType().toString(), true);
- }
- KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
DirectTemplateDownloader downloader;
+ KVMPhysicalDisk template;
try {
- downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
- } catch (IllegalArgumentException e) {
- return new DirectDownloadAnswer(false, "Unable to create direct downloader: " + e.getMessage(), true);
- }
+ s_logger.info("Verifying temporary location for downloading the template exists on the host");
Review comment:
seems like a debug message to me. Why does the operator want to see this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591986133
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577681630
travis choked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580154949
@nvazquez I am seeing them in both 4.13 and master (see https://github.com/apache/cloudstack/pull/3819#issuecomment-579570104) I have no idea yet when they started or where they come from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591998419
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage
provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369455351
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1693,38 +1696,77 @@ private DirectTemplateDownloader getDirectTemplateDownloaderFromCommand(DirectDo
@Override
public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand cmd) {
final PrimaryDataStoreTO pool = cmd.getDestPool();
- if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
- return new DirectDownloadAnswer(false, "Unsupported pool type " + pool.getPoolType().toString(), true);
- }
- KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
DirectTemplateDownloader downloader;
+ KVMPhysicalDisk template;
try {
- downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
- } catch (IllegalArgumentException e) {
- return new DirectDownloadAnswer(false, "Unable to create direct downloader: " + e.getMessage(), true);
- }
+ s_logger.info("Verifying temporary location for downloading the template exists on the host");
+ String temporaryDownloadPath = resource.getDirectDownloadTemporaryDownloadPath();
+ if (!isLocationAccessible(temporaryDownloadPath)) {
+ String msg = "The temporary location path for downloading templates does not exist: " +
+ temporaryDownloadPath + " on this host";
+ s_logger.error(msg);
+ return new DirectDownloadAnswer(false, msg, true);
+ }
- try {
+ s_logger.info("Checking for free space on the host for downloading the template");
+ if (!isEnoughSpaceForDownloadTemplateOnTemporaryLocation(cmd.getTemplateSize())) {
+ String msg = "Not enough space on the defined temporary location to download the template " + cmd.getTemplateId();
+ s_logger.error(msg);
+ return new DirectDownloadAnswer(false, msg, true);
+ }
+
+ KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
+ downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool, temporaryDownloadPath);
s_logger.info("Trying to download template");
Review comment:
maybe change this one to debug as well, or move and add the resulting path to the message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594363102
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594362835
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593398831
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595250275
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [WIP DO NOT MERGE]
[KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577019756
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595238503
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595060297
@DaanHoogland @andrijapanicsb cc @borisstoyanov @PaulAngus this is ready to merge, please advice if any manual testing is complete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593370558
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov removed a comment on issue #3828: [KVM]
Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
borisstoyanov removed a comment on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591999083
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-585080516
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage
provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369454964
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1693,38 +1696,77 @@ private DirectTemplateDownloader getDirectTemplateDownloaderFromCommand(DirectDo
@Override
public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand cmd) {
final PrimaryDataStoreTO pool = cmd.getDestPool();
- if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
- return new DirectDownloadAnswer(false, "Unsupported pool type " + pool.getPoolType().toString(), true);
- }
- KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
DirectTemplateDownloader downloader;
+ KVMPhysicalDisk template;
try {
- downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
- } catch (IllegalArgumentException e) {
- return new DirectDownloadAnswer(false, "Unable to create direct downloader: " + e.getMessage(), true);
- }
+ s_logger.info("Verifying temporary location for downloading the template exists on the host");
+ String temporaryDownloadPath = resource.getDirectDownloadTemporaryDownloadPath();
+ if (!isLocationAccessible(temporaryDownloadPath)) {
+ String msg = "The temporary location path for downloading templates does not exist: " +
+ temporaryDownloadPath + " on this host";
+ s_logger.error(msg);
+ return new DirectDownloadAnswer(false, msg, true);
+ }
- try {
+ s_logger.info("Checking for free space on the host for downloading the template");
Review comment:
in this case i would say that if the operator wants info it would be the actual size found and not an announcement that it is going to be calculated. also seems debug to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589482257
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579594136
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580670240
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577024774
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589511919
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579589211
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-585080229
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577122776
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579589091
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595060576
@nvazquez there is one issue specific to simulator, address implement the mocked/override method:
```
[ERROR] /home/travis/build/apache/cloudstack/plugins/hypervisors/simulator/src/main/java/com/cloud/resource/SimulatorStorageProcessor.java:[56,7] error: SimulatorStorageProcessor is not abstract and does not override abstract method copyVolumeFromPrimaryToPrimary(CopyCommand) in StorageProcessor
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure
[ERROR] /home/travis/build/apache/cloudstack/plugins/hypervisors/simulator/src/main/java/com/cloud/resource/SimulatorStorageProcessor.java:[56,7] error: SimulatorStorageProcessor is not abstract and does not override abstract method copyVolumeFromPrimaryToPrimary(CopyCommand) in StorageProcessor
[ERROR] -> [Help 1]
```
@DaanHoogland @andrijapanicsb cc @borisstoyanov @PaulAngus this is ready to merge, please advice if any manual testing is complete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579875025
@DaanHoogland marvin tests fixed, but rebased master and getting these failures^^. Have seen them in master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591801080
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593606995
<b>Trillian test result (tid-1167)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29016 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t1167-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 79 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 187.09 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589486259
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez opened a new pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images/direct-download` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez opened a new pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images/direct-download` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589621797
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593407438
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589019767
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594341946
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577401062
<b>Trillian test result (tid-805)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37512 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t805-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 3.34 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 2.23 | test_direct_download.py
test_02_upload_direct_download_certificates | `Failure` | 0.04 | test_direct_download.py
test_02_deploy_vm_from_direct_download_template | `Error` | 38.35 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 10.61 | test_templates.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [WIP DO NOT MERGE]
[KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577017724
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-581006003
@nvazquez travis seems to have to jobs running into genguine failures. Want to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594605346
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593407128
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577121366
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589615085
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595238400
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579815948
<b>Trillian test result (tid-834)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36465 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t834-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 75 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_oobm_background_powerstate_sync | `Failure` | 20.52 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 21.35 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 7.36 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 6.35 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 7.36 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 6.34 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 6.34 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 7.35 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.59 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 2.20 | test_outofbandmanagement.py
test_05_rvpc_multi_tiers | `Failure` | 411.41 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 439.38 | test_vpc_redundant.py
test_hostha_kvm_host_degraded | `Error` | 3.61 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 5.69 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 3.61 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593797583
There are still 2 issues that @nvazquez is working on @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595910597
3 x approvals, extensive manual testing, another review of the same and all regression testing passes.
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589487831
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595208560
Fix for the simulator build added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-592074867
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-579593916
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595664354
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580895204
<b>Trillian test result (tid-871)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31234 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t871-kvm-centos7.zip
Smoke tests completed. 78 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580669850
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589517173
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez removed a comment on issue #3828: [WIP DO NOT
MERGE] [KVM] Direct download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on issue #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577017724
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-594636282
<b>Trillian test result (tid-1183)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t1183-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Smoke tests completed. 81 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591800848
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593667705
<b>Trillian test result (tid-1169)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29347 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t1169-kvm-centos7.zip
Smoke tests completed. 80 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595319394
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589003895
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593370809
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-592062551
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3828: [KVM] Direct download
agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580690216
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage
provider
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369455650
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1693,38 +1696,77 @@ private DirectTemplateDownloader getDirectTemplateDownloaderFromCommand(DirectDo
@Override
public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand cmd) {
final PrimaryDataStoreTO pool = cmd.getDestPool();
- if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
- return new DirectDownloadAnswer(false, "Unsupported pool type " + pool.getPoolType().toString(), true);
- }
- KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
DirectTemplateDownloader downloader;
+ KVMPhysicalDisk template;
try {
- downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
- } catch (IllegalArgumentException e) {
- return new DirectDownloadAnswer(false, "Unable to create direct downloader: " + e.getMessage(), true);
- }
+ s_logger.info("Verifying temporary location for downloading the template exists on the host");
+ String temporaryDownloadPath = resource.getDirectDownloadTemporaryDownloadPath();
+ if (!isLocationAccessible(temporaryDownloadPath)) {
+ String msg = "The temporary location path for downloading templates does not exist: " +
+ temporaryDownloadPath + " on this host";
+ s_logger.error(msg);
+ return new DirectDownloadAnswer(false, msg, true);
+ }
- try {
+ s_logger.info("Checking for free space on the host for downloading the template");
+ if (!isEnoughSpaceForDownloadTemplateOnTemporaryLocation(cmd.getTemplateSize())) {
+ String msg = "Not enough space on the defined temporary location to download the template " + cmd.getTemplateId();
+ s_logger.error(msg);
+ return new DirectDownloadAnswer(false, msg, true);
+ }
+
+ KVMStoragePool destPool = storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
+ downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool, temporaryDownloadPath);
s_logger.info("Trying to download template");
- if (!downloader.downloadTemplate()) {
+ Pair<Boolean, String> result = downloader.downloadTemplate();
+ if (!result.first()) {
s_logger.warn("Couldn't download template");
return new DirectDownloadAnswer(false, "Unable to download template", true);
}
+ String tempFilePath = result.second();
if (!downloader.validateChecksum()) {
s_logger.warn("Couldn't validate template checksum");
return new DirectDownloadAnswer(false, "Checksum validation failed", false);
}
- if (!downloader.extractAndInstallDownloadedTemplate()) {
- s_logger.warn("Couldn't extract and install template");
- return new DirectDownloadAnswer(false, "Extraction and installation failed", false);
- }
+ template = storagePoolMgr.createPhysicalDiskFromDirectDownloadTemplate(tempFilePath, destPool, 100);
} catch (CloudRuntimeException e) {
s_logger.warn("Error downloading template " + cmd.getTemplateId() + " due to: " + e.getMessage());
return new DirectDownloadAnswer(false, "Unable to download template: " + e.getMessage(), true);
+ } catch (IllegalArgumentException e) {
+ return new DirectDownloadAnswer(false, "Unable to create direct downloader: " + e.getMessage(), true);
}
- DirectTemplateInformation info = downloader.getTemplateInformation();
- return new DirectDownloadAnswer(true, info.getSize(), info.getInstallPath());
+ return new DirectDownloadAnswer(true, template.getSize(), template.getName());
+ }
+
+ /**
+ * True if location exists
+ */
+ private boolean isLocationAccessible(String temporaryDownloadPath) {
+ File dir = new File(temporaryDownloadPath);
+ return dir.exists();
+ }
+
+ /**
+ * Perform a free space check on the host for downloading the direct download templates
+ * @param templateSize template size obtained from remote server when registering the template (in bytes)
+ */
+ protected boolean isEnoughSpaceForDownloadTemplateOnTemporaryLocation(Long templateSize) {
+ if (templateSize == null || templateSize == 0L) {
+ s_logger.info("The server did not provide the template size, assuming there is enough space to download it");
Review comment:
👍 this one I agree is good for the operator to have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593394742
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez opened a new pull request #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
## Description
This FR proposes the extension of the direct download support to primary storage pools using the most commonly used protocols/storage types:
- NFS – already supported
- Local storage
- SharedMountpoint
Other storage providers support can be extended in future by interface implementation on the KVM storage provider depending on the storage adaptor.
The KVM storage processor is extended to achieve the direct template downloads in a storage agnostic way, including the supported storage providers implementations and allowing future implementations for different storage providers:
- A new check of the available free space on the downloading host local storage is added before attempting to download a template. As on registration, a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD command to the template URL. In case the server provides the remote file size of the template, this size is passed as part of the DirectDownloadCommand and used to check against the available free space.
- The template file is downloaded to a scratch space in the local storage system within the host. This location can be explicitly set by the administrator via agent.properties file on the property: `direct.download.temporary.download.location`, and in case it is not set the default location `var/lib/libvirt/images/direct-download` is used.
- After the template file is downloaded to the scratch space location, it is extracted (or copied) to the primary storage pool selected by the CloudStack planner.
- The implementation of the extract/copy method is extended to invoke the different StorageAdaptors implementations for different storage providers. These implementations include local storage, shared mount point and NFS in the scope of this PR.
- After the template is extracted/copied to the destination storage pool, the downloaded file is removed from the scratch space location in the host.
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ubuntu based management server
Test zone with local storage for user VMs enabled
2 x CentOS7 based KVM hosts
1 NFS storage pool
1 Shared mount point across the 2 hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-589511928
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591768046
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591985374
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-595858359
<b>Trillian test result (tid-1206)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t1206-kvm-centos7.zip
Smoke tests completed. 81 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-592062245
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593428376
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-593394720
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580689774
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-580690495
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-585119012
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-813
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct
download agnostic of the storage provider
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-591773157
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services