[GitHub] [incubator-nuttx] davids5 commented on a diff in pull request #6728: w25qxxxjv.c: Ensure Quad SPI mode is enabled

[GitBox <gi...@apache.org>]

davids5 commented on code in PR #6728:
URL: https://github.com/apache/incubator-nuttx/pull/6728#discussion_r932033612


##########
drivers/mtd/w25qxxxjv.c:
##########
@@ -594,6 +601,32 @@ static void w25qxxxjv_write_disable(FAR struct w25qxxxjv_dev_s *priv)
   while ((status & STATUS_WEL_MASK) != STATUS_WEL_DISABLED);
 }
 
+/****************************************************************************
+ * Name:  w25qxxxjv_quad_enable
+ ****************************************************************************/
+
+static void w25qxxxjv_quad_enable(FAR struct w25qxxxjv_dev_s *priv)
+{
+  w25qxxxjv_command_read(priv->qspi, W25QXXXJV_READ_STATUS_2,
+                         (FAR void *)priv->cmdbuf, 1);
+
+  while ((priv->cmdbuf[0] & STATUS2_QE_MASK) != STATUS2_QE_ENABLED)

Review Comment:
   Why does this need to be looping?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org