You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/10/15 19:42:57 UTC
Review Request 39346: GEODE-405: sameAs needs to ignore ssl-*
properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39346/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Bugs: GEODE-405
https://issues.apache.org/jira/browse/GEODE-405
Repository: geode
Description
-------
Since toProperties does not include ssl-* properties
sameAs needs to also ignore ssl-* properties.
Since the ssl-* are always copied to cluster-ssl-*
and sameAs compares these it will still return false
if the ssl-* properties had different values.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 75e4314d67dbeff8fb6b97d712f689263094e7d7
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 88a06542383d50d41f6768b8142c9deb6d988392
Diff: https://reviews.apache.org/r/39346/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 39346: GEODE-405: sameAs needs to ignore ssl-*
properties
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39346/#review105093
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Oct. 15, 2015, 5:42 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39346/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 5:42 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Bugs: GEODE-405
> https://issues.apache.org/jira/browse/GEODE-405
>
>
> Repository: geode
>
>
> Description
> -------
>
> Since toProperties does not include ssl-* properties
> sameAs needs to also ignore ssl-* properties.
> Since the ssl-* are always copied to cluster-ssl-*
> and sameAs compares these it will still return false
> if the ssl-* properties had different values.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 75e4314d67dbeff8fb6b97d712f689263094e7d7
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 88a06542383d50d41f6768b8142c9deb6d988392
>
> Diff: https://reviews.apache.org/r/39346/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>