[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1880: Issue #1876: Explicitly declare the used features for each dependency in arrow-flight

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1880:
URL: https://github.com/apache/arrow-rs/pull/1880#discussion_r899486594


##########
arrow-flight/Cargo.toml:
##########
@@ -27,14 +27,14 @@ repository = "https://github.com/apache/arrow-rs"
 license = "Apache-2.0"
 
 [dependencies]
-arrow = { path = "../arrow", version = "16.0.0" }
-base64 = "0.13"
-tonic = "0.7"
-bytes = "1"
-prost = "0.10"
-prost-types = { version = "0.10.0", optional = true }
-prost-derive = "0.10"
-tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread"] }
+arrow = { path = "../arrow", version = "16.0.0", default-features = false, features = ["ipc"] }
+base64 = { version = "0.13", default-features = false }
+tonic = { version = "0.7", default-features = false, features = ["transport", "codegen", "prost"] }
+bytes = { version = "1", default-features = false }

Review Comment:
   I'm surprised by this, we are definitely using the `std` feature as we are using the reader implementation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org