You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/10 21:54:00 UTC

[jira] [Commented] (AIRFLOW-3670) Make Travis Fail quickly on Flake

    [ https://issues.apache.org/jira/browse/AIRFLOW-3670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739814#comment-16739814 ] 

ASF GitHub Bot commented on AIRFLOW-3670:
-----------------------------------------

drewsonne commented on pull request #4477: [AIRFLOW-3670] Add stages to Travis build
URL: https://github.com/apache/airflow/pull/4477
 
 
   Allow travis to fail the entire build quickly, if the flake8 build fails
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-3670
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
    This makes no changes to the application code, and is designed to improve the development ccle by reducing the cycle time from test start to notification that test has failed
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   No tests as this is a config for the test running. An example of the fast fail can be seen here https://travis-ci.org/drewsonne/airflow/builds/478054124
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make Travis Fail quickly on Flake
> ---------------------------------
>
>                 Key: AIRFLOW-3670
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3670
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: travis
>    Affects Versions: 1.10.1
>            Reporter: Drew Sonne
>            Priority: Minor
>             Fix For: 1.10.2
>
>
> Add stages to the travis builds to split flake8 and functional/unit tests, so that if flake8 tests fail, the rest of the build will fail quickly.
> This will reduce turnaround time for bad linting notifications.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)