You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/01/15 02:35:35 UTC

[GitHub] peng-yongsheng commented on a change in pull request #732: Adjust ui-query protocol

peng-yongsheng commented on a change in pull request #732: Adjust ui-query protocol
URL: https://github.com/apache/incubator-skywalking/pull/732#discussion_r160987060
 
 

 ##########
 File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/alarm.graphqls
 ##########
 @@ -10,6 +15,11 @@ enum AlarmType {
     SERVICE
 }
 
+enum CauseType {
+    LOW_SUCCESS_RATE,
+    SLOW_RESPONSE
+}
+
 extend type Query {
-    loadAlertList(keyword: String, alertType: AlarmType, duration:Duration!):[AlarmItem]
+    loadAlertList(keyword: String, alertType: AlarmType, duration:Duration!, paging: Pagination!):[AlarmItem!]!
 
 Review comment:
   The parameter in this method contains paging, but no count parameter in return object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services