You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/25 07:49:47 UTC

[GitHub] [incubator-druid] leventov opened a new issue #8156: Prohibit Thread.getState() != TERMINATED antipattern

leventov opened a new issue #8156: Prohibit Thread.getState() != TERMINATED antipattern
URL: https://github.com/apache/incubator-druid/issues/8156
 
 
   https://github.com/apache/incubator-druid/blob/61f4abece445e5bb1f15df093cbd800ebbd8c501/server/src/test/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseIdleTest.java#L103-L105
   
   Can be replaced with `firehose.getDelayedCloseExecutor().join();`
   
   There is a similar occurrence in `EventReceiverFirehoseTest`.
   
   This pattern could be prohibited using a [Structural Search inspection](https://github.com/apache/incubator-druid/blob/master/dev/teamcity.md#creating-a-custom-inspection-from-a-structural-search-pattern).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org