You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2014/06/09 21:00:24 UTC
Review Request 22387: Windows swig warns about a union nested in a struct
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22387/
-----------------------------------------------------------
Review request for qpid.
Bugs: PROTON-601
https://issues.apache.org/jira/browse/PROTON-601
Repository: qpid
Description
-------
The fix is to take the union out of the struct.
Diffs
-----
Diff: https://reviews.apache.org/r/22387/diff/
Testing
-------
passes ctest windows and linux
Thanks,
Chug Rolke
Re: Review Request 22387: Windows swig warns about a union nested in a struct
Posted by Chug Rolke <cr...@redhat.com>.
> On June 9, 2014, 7:42 p.m., Andrew Stitcher wrote:
> > But why do we care about this warning anyway? (we could just suppress it)
> >
> > I think the appropriate "solution", if we even need one, is to %ignore pn_atom_t.
> >
> > Allowing swig to wrap pn_atom_t doesn't make much sense in the first place and we have typemaps for the cases that this type is used in the API.
%ignore pn_atom_t it shall be, thanks.
- Chug
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22387/#review45115
-----------------------------------------------------------
On June 9, 2014, 7:38 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22387/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 7:38 p.m.)
>
>
> Review request for qpid, Andrew Stitcher and Rafael Schloming.
>
>
> Bugs: PROTON-601
> https://issues.apache.org/jira/browse/PROTON-601
>
>
> Repository: qpid
>
>
> Description
> -------
>
> The fix is to take the union out of the struct.
>
>
> Diffs
> -----
>
> proton/trunk/proton-c/include/proton/codec.h 1600756
>
> Diff: https://reviews.apache.org/r/22387/diff/
>
>
> Testing
> -------
>
> passes ctest windows and linux
>
>
> Thanks,
>
> Chug Rolke
>
>
Re: Review Request 22387: Windows swig warns about a union nested in a struct
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22387/#review45115
-----------------------------------------------------------
But why do we care about this warning anyway? (we could just suppress it)
I think the appropriate "solution", if we even need one, is to %ignore pn_atom_t.
Allowing swig to wrap pn_atom_t doesn't make much sense in the first place and we have typemaps for the cases that this type is used in the API.
- Andrew Stitcher
On June 9, 2014, 7:38 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22387/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 7:38 p.m.)
>
>
> Review request for qpid, Andrew Stitcher and Rafael Schloming.
>
>
> Bugs: PROTON-601
> https://issues.apache.org/jira/browse/PROTON-601
>
>
> Repository: qpid
>
>
> Description
> -------
>
> The fix is to take the union out of the struct.
>
>
> Diffs
> -----
>
> proton/trunk/proton-c/include/proton/codec.h 1600756
>
> Diff: https://reviews.apache.org/r/22387/diff/
>
>
> Testing
> -------
>
> passes ctest windows and linux
>
>
> Thanks,
>
> Chug Rolke
>
>
Re: Review Request 22387: Windows swig warns about a union nested in a struct
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22387/
-----------------------------------------------------------
(Updated June 9, 2014, 7:38 p.m.)
Review request for qpid, Andrew Stitcher and Rafael Schloming.
Changes
-------
add reviewers
Bugs: PROTON-601
https://issues.apache.org/jira/browse/PROTON-601
Repository: qpid
Description
-------
The fix is to take the union out of the struct.
Diffs
-----
proton/trunk/proton-c/include/proton/codec.h 1600756
Diff: https://reviews.apache.org/r/22387/diff/
Testing
-------
passes ctest windows and linux
Thanks,
Chug Rolke
Re: Review Request 22387: Windows swig warns about a union nested in a struct
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22387/
-----------------------------------------------------------
(Updated June 9, 2014, 7:01 p.m.)
Review request for qpid.
Changes
-------
the diff
Bugs: PROTON-601
https://issues.apache.org/jira/browse/PROTON-601
Repository: qpid
Description
-------
The fix is to take the union out of the struct.
Diffs (updated)
-----
proton/trunk/proton-c/include/proton/codec.h 1600756
Diff: https://reviews.apache.org/r/22387/diff/
Testing
-------
passes ctest windows and linux
Thanks,
Chug Rolke