You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "PetervdPerk-NXP (via GitHub)" <gi...@apache.org> on 2026/01/07 09:14:08 UTC
[PR] Fix NuttX Kinetis/S32K3XX by caused by refactoring [nuttx]
PetervdPerk-NXP opened a new pull request, #17788:
URL: https://github.com/apache/nuttx/pull/17788
## Summary
During some renames/cleanup of spinlocks kinetis/s32k3xx didn't compile anymore
## Impact
Boards compile and work again
## Testing
It builds again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kinetis: Fix S32K3XX regressions caused by refactoring [nuttx]
Posted by "PetervdPerk-NXP (via GitHub)" <gi...@apache.org>.
PetervdPerk-NXP commented on code in PR #17788:
URL: https://github.com/apache/nuttx/pull/17788#discussion_r2668744591
##########
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:
##########
@@ -151,9 +151,9 @@
/* Control 1 Register */
-#define CAN_CTRL1_PROSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
-#define CAN_CTRL1_PROSEG_MASK (7 << CAN_CTRL1_PROSEG_SHIFT)
-#define CAN_CTRL1_PROPSEG(x) (((uint32_t)(((uint32_t)(x)) << CAN_CTRL1_PROPSEG_SHIFT)) & CAN_CTRL1_PROSEG_MASK)
+#define CAN_CTRL1_PROPSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
+#define CAN_CTRL1_PROPSEG_MASK (7 << CAN_CTRL1_PROPSEG_SHIFT)
Review Comment:
I see, I missed that (atlhough somehow nxstyle aswell), fixed the spacing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix NuttX Kinetis/S32K3XX regressions by caused by refactoring [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #17788:
URL: https://github.com/apache/nuttx/pull/17788#discussion_r2668128533
##########
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:
##########
@@ -151,9 +151,9 @@
/* Control 1 Register */
-#define CAN_CTRL1_PROSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
-#define CAN_CTRL1_PROSEG_MASK (7 << CAN_CTRL1_PROSEG_SHIFT)
-#define CAN_CTRL1_PROPSEG(x) (((uint32_t)(((uint32_t)(x)) << CAN_CTRL1_PROPSEG_SHIFT)) & CAN_CTRL1_PROSEG_MASK)
+#define CAN_CTRL1_PROPSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
+#define CAN_CTRL1_PROPSEG_MASK (7 << CAN_CTRL1_PROPSEG_SHIFT)
Review Comment:
@PetervdPerk-NXP seems like this two lines are not aligned (they are 1 space ahead to the right)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kinetis: Fix S32K3XX regressions caused by refactoring [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #17788:
URL: https://github.com/apache/nuttx/pull/17788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix NuttX Kinetis/S32K3XX regressions by caused by refactoring [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #17788:
URL: https://github.com/apache/nuttx/pull/17788#discussion_r2668128533
##########
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:
##########
@@ -151,9 +151,9 @@
/* Control 1 Register */
-#define CAN_CTRL1_PROSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
-#define CAN_CTRL1_PROSEG_MASK (7 << CAN_CTRL1_PROSEG_SHIFT)
-#define CAN_CTRL1_PROPSEG(x) (((uint32_t)(((uint32_t)(x)) << CAN_CTRL1_PROPSEG_SHIFT)) & CAN_CTRL1_PROSEG_MASK)
+#define CAN_CTRL1_PROPSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */
+#define CAN_CTRL1_PROPSEG_MASK (7 << CAN_CTRL1_PROPSEG_SHIFT)
Review Comment:
@PetervdPerk-NXP seems like this two lines are not aligned (they are 1 space ahead to the right)
(0) and (7 << ...) should start at same column of the bottom (third line)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org