You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2016/06/21 04:10:00 UTC
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/13798
[SPARKR][DOCS] R code doc cleanup
## What changes were proposed in this pull request?
I ran a full pass from A to Z and fixed the obvious duplications, improper grouping etc.
Also removed job group function that was exported (?)
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rdocseealso
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13798
----
commit 227fce72abcd39249fd51c617103ca8dfcc9efa1
Author: Felix Cheung <fe...@hotmail.com>
Date: 2016-06-21T04:04:47Z
update roxygen2 doc
commit 345b9e23adbca891c61121f45daa2093590d07a9
Author: Felix Cheung <fe...@hotmail.com>
Date: 2016-06-21T04:07:57Z
remove job group functions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60906/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60906/consoleFull)** for PR 13798 at commit [`28916fc`](https://github.com/apache/spark/commit/28916fc8ce0fa0bf370f717a7c0992a3f9724c20).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13798#discussion_r67813477
--- Diff: R/pkg/R/DataFrame.R ---
@@ -606,10 +607,10 @@ setMethod("unpersist",
#'
#' The following options for repartition are possible:
#' \itemize{
-#' \item{"Option 1"} {Return a new SparkDataFrame partitioned by
+#' \item{1.} {Return a new SparkDataFrame partitioned by
#' the given columns into `numPartitions`.}
-#' \item{"Option 2"} {Return a new SparkDataFrame that has exactly `numPartitions`.}
-#' \item{"Option 3"} {Return a new SparkDataFrame partitioned by the given column(s),
+#' \item{2.} {Return a new SparkDataFrame that has exactly `numPartitions`.}
+#' \item{3.} {Return a new SparkDataFrame partitioned by the given column(s),
#' using `spark.sql.shuffle.partitions` as number of partitions.}
--- End diff --
For the ordered itemize, what about the following?
```
#' \enumerate{
#' \item Return a new SparkDataFrame partitioned by the given columns into `numPartitions`.
#' \item Return a new SparkDataFrame that has exactly `numPartitions`.
#' \item Return a new SparkDataFrame partitioned by the given column(s),
#' using `spark.sql.shuffle.partitions` as number of partitions.
#' }
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60909/consoleFull)** for PR 13798 at commit [`d9d9b3e`](https://github.com/apache/spark/commit/d9d9b3e3da6cfc62c9f59652d18f8be8e855bb5d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13798#discussion_r67811733
--- Diff: R/pkg/R/generics.R ---
@@ -689,67 +689,67 @@ setGeneric("randomSplit", function(x, weights, seed) { standardGeneric("randomSp
###################### Column Methods ##########################
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("asc", function(x) { standardGeneric("asc") })
-#' @rdname column
+#' @rdname between
#' @export
setGeneric("between", function(x, bounds) { standardGeneric("between") })
-#' @rdname column
+#' @rdname cast
#' @export
setGeneric("cast", function(x, dataType) { standardGeneric("cast") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("contains", function(x, ...) { standardGeneric("contains") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("desc", function(x) { standardGeneric("desc") })
-#' @rdname column
+#' @rdname endsWith
#' @export
setGeneric("endsWith", function(x, suffix) { standardGeneric("endsWith") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("getField", function(x, ...) { standardGeneric("getField") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("getItem", function(x, ...) { standardGeneric("getItem") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("isNull", function(x) { standardGeneric("isNull") })
-#' @rdname column
+#' @rdname column functions
--- End diff --
They were on one page, but "column" is the wrong rd to put them - there's already the class `Column` and function `column`. (there's also function `columns` but that's a different page) - so the intent is to put these in their separate pages as `column functions`)
it looked like this previously:
This is still buggy - investigating.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60903/consoleFull)** for PR 13798 at commit [`345b9e2`](https://github.com/apache/spark/commit/345b9e23adbca891c61121f45daa2093590d07a9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60906/consoleFull)** for PR 13798 at commit [`28916fc`](https://github.com/apache/spark/commit/28916fc8ce0fa0bf370f717a7c0992a3f9724c20).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60909/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13798
Fixed. I double-checked all affected rd.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60903/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13798
Thanks for the update. This one looks fine to me now.
@dongjoon-hyun Any other comments ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13798
Yeah lets do that in a separate PR with discussion ? We don't lose much by leaving in a few extra functions that we deprecate / remove later.
Thanks for the doc cleanup - I'll take one more look at that now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13798#discussion_r67810125
--- Diff: R/pkg/R/generics.R ---
@@ -689,67 +689,67 @@ setGeneric("randomSplit", function(x, weights, seed) { standardGeneric("randomSp
###################### Column Methods ##########################
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("asc", function(x) { standardGeneric("asc") })
-#' @rdname column
+#' @rdname between
#' @export
setGeneric("between", function(x, bounds) { standardGeneric("between") })
-#' @rdname column
+#' @rdname cast
#' @export
setGeneric("cast", function(x, dataType) { standardGeneric("cast") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("contains", function(x, ...) { standardGeneric("contains") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("desc", function(x) { standardGeneric("desc") })
-#' @rdname column
+#' @rdname endsWith
#' @export
setGeneric("endsWith", function(x, suffix) { standardGeneric("endsWith") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("getField", function(x, ...) { standardGeneric("getField") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("getItem", function(x, ...) { standardGeneric("getItem") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
-#' @rdname column
+#' @rdname column functions
#' @export
setGeneric("isNull", function(x) { standardGeneric("isNull") })
-#' @rdname column
+#' @rdname column functions
--- End diff --
not sure i follow the intent here - do we want these all in the same rd ? Also is there supposed to be an underscore (i.e. `column_functions`) instead of a space ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13798
No more jobGroup changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60903/consoleFull)** for PR 13798 at commit [`345b9e2`](https://github.com/apache/spark/commit/345b9e23adbca891c61121f45daa2093590d07a9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13798
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13798
Opened a JIRA since we are removing methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13798
@shivaram @dongjoon-hyun
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13798
Right they are really SparkContext methods - I could leave/deprecate them if you'd prefer, or separate that into a different PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13798
**[Test build #60909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60909/consoleFull)** for PR 13798 at commit [`d9d9b3e`](https://github.com/apache/spark/commit/d9d9b3e3da6cfc62c9f59652d18f8be8e855bb5d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13798: [SPARKR][DOCS] R code doc cleanup
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13798#discussion_r67815785
--- Diff: R/pkg/R/DataFrame.R ---
@@ -606,10 +607,10 @@ setMethod("unpersist",
#'
#' The following options for repartition are possible:
#' \itemize{
-#' \item{"Option 1"} {Return a new SparkDataFrame partitioned by
+#' \item{1.} {Return a new SparkDataFrame partitioned by
#' the given columns into `numPartitions`.}
-#' \item{"Option 2"} {Return a new SparkDataFrame that has exactly `numPartitions`.}
-#' \item{"Option 3"} {Return a new SparkDataFrame partitioned by the given column(s),
+#' \item{2.} {Return a new SparkDataFrame that has exactly `numPartitions`.}
+#' \item{3.} {Return a new SparkDataFrame partitioned by the given column(s),
#' using `spark.sql.shuffle.partitions` as number of partitions.}
--- End diff --
it mentioned "these options" (as in one of these choices) on the line before, so I thought it's nicer to numbered the options.
in other cases we have unnumbered bullets if they are enum values and so on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARK-16088][SPARKR][DOCS] Remove setJobGroup, clearJob...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13798
Hmm can we document somewhere why we want to remove this functionality ? Is this because spark context is no longer accessible ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13798: [SPARKR][DOCS] R code doc cleanup
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13798
Alright I'm merging this to master and branch-2.0 so that it makes it to the RC. We can try and fix minor things going forward
Thanks @felixcheung -- This is a much needed clean up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org