You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:33:29 UTC
[GitHub] [iotdb] Wei-hao-Li commented on a diff in pull request #8230: [To rel/1.0] [IOTDB-4940] Optimize query fetch data partition process while containg unclosed time filter
Wei-hao-Li commented on code in PR #8230:
URL: https://github.com/apache/iotdb/pull/8230#discussion_r1033547491
##########
node-commons/src/main/java/org/apache/iotdb/commons/partition/DataPartitionQueryParam.java:
##########
@@ -28,12 +28,31 @@ public class DataPartitionQueryParam {
private String devicePath;
private List<TTimePartitionSlot> timePartitionSlotList = new ArrayList<>();
+ // it will be set to true in query when there exist filter like: time <= XXX
+ // (-oo, timePartitionSlotList.get(0)]
+ private boolean needLeftAll = false;
+
+ // it will be set to true query when there exist filter like: time >= XXX
+ // [timePartitionSlotList.get(timePartitionSlotList.size() - 1), +oo)
+ private boolean needRightAll = false;
Review Comment:
The margin partition will be added （if need）in previous process code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org