You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/09 17:25:07 UTC

[GitHub] [arrow-rs] sunchao commented on a diff in pull request #1674: Support dictionary arrays in length and bit_length

sunchao commented on code in PR #1674:
URL: https://github.com/apache/arrow-rs/pull/1674#discussion_r868244584


##########
arrow/src/compute/kernels/length.rs:
##########
@@ -127,10 +150,26 @@ where
 /// For list array, length is the number of elements in each list.
 /// For string array and binary array, length is the number of bytes of each value.
 ///
-/// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray and BinaryArray/LargeBinaryArray
+/// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray andBinaryArray/LargeBinaryArray,

Review Comment:
   nit: space after `and`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org