[jira] [Commented] (PHOENIX-5611) Inaccurate MutationState numRows and estimatedSize counting

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993580#comment-16993580 ] 

Hadoop QA commented on PHOENIX-5611:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12988529/estSize.patch
  against master branch at commit 964dd80f20ab8649af7672314f4127b73c0280b7.
  ATTACHMENT ID: 12988529

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3181//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3181//console

This message is automatically generated.

> Inaccurate MutationState numRows and estimatedSize counting
> -----------------------------------------------------------
>
>                 Key: PHOENIX-5611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5611
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.2
>            Reporter: Alex Batyrshin
>            Priority: Minor
>         Attachments: estSize.patch, numRows.patch
>
>
> Hello,
> I found that numRows decreased by HBase mutations count instead of SQL rows count. In case of NULL in UPSERT there will be 1 SQL row  == 2 HBase mutation.
> UPSERT INTO test VALUES ('foo', NULL) => HBase Put Mutation + HBase Delete Mutation
> Also I found that estimatedSize could be calculated via KeyValueUtil.getEstimatedRowMutationSize and via RowMutationState.calculateEstimatedSize. Last one doesn't take into account length of row keys, so result KeyValueUtil.getEstimatedRowMutationSize != RowMutationState.calculateEstimatedSize



--
This message was sent by Atlassian Jira
(v8.3.4#803005)