You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/17 11:41:19 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3696: ARTEMIS-3420: Target Java 11
gemmellr opened a new pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696
https://issues.apache.org/jira/browse/ARTEMIS-3420
I have been extracting and dropping related isolated changes onto main for a while already that have just released with 2.18.0, since they improved various Java 11+ related issues without actually requiring it. These are my remaining changes to actually require and target Java 11, resolve new issues that creates, and clean up some bits that become stale as a result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908492998
Yep figured as much, that is the reason I haven't sent a <tumblweed> comment to the mail thread already ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-916781232
@gemmellr / @clebertsuconic with the next Java LTS due this month, with the dropping of java 8, i assume we want to add support of 17, at same time, e.g. we keep support of two current java LTS versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-916805582
You may have seen me actually reference 17ea at various points in JIRAs and emails, as I do personally think it should supported quickly though I'd say its somewhat separate from requiring 11.
That said, I have actually also been ensuring the GHA build works on 17ea with these changes though (and also 2.18.0 with those I extracted before then), I just didnt include it here yet as its wasnt out yet and Temurin inst in the GHA build runner tool cache yet. I planned to add it to the actual build as soon as 17 released though (and hopefully Temurin might actually be in the tool cache by then also).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-964298023
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908492998
Yep figured as much, that is the reason I haven't sent a \<tumblweed\> comment to the mail thread already ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908492998
Yep figured as much, that is the reason I haven't sent a \<tumblweed\> comment to the mail thread already ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-964292246
yayyyy!!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-917023090
@gemmellr of course 17 is separate than this PR it was more a question of did you have something in the pipeline...and it sounds like you do. +100.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908492998
Yep figured as much, that is the reason I haven't sent a <tumblweed> comment to the mail thread already ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908488178
I want to wait my next release before merging this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-916781232
@gemmellr / @clebertsuconic with the next Java LTS due this month, with the dropping of java 8 support in Artemis, i assume we want to add support of 17, at same time, e.g. we keep support of two current java LTS versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-908488178
I want to wait my next release before merging this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696#issuecomment-905426666
Rebased again and updated to account for other subsequent build config changes I made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3696: ARTEMIS-3420: Target Java 11
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3696:
URL: https://github.com/apache/activemq-artemis/pull/3696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org