[GitHub] [beam] KhaninArtur commented on a change in pull request #16325: [BEAM-13471] [Playground] Tag existing unit-tests

[GitBox <gi...@apache.org>]

KhaninArtur commented on a change in pull request #16325:
URL: https://github.com/apache/beam/pull/16325#discussion_r774617267



##########
File path: examples/java/src/test/java/org/apache/beam/examples/complete/game/GameStatsTest.java
##########
@@ -17,6 +17,14 @@
  */
 package org.apache.beam.examples.complete.game;
 
+// beam-playground:
+//   name: GameStatsTest
+//   description: Unit-test for the GameStats example.
+//   multifile: false
+//   pipeline_options:
+//   categories:

Review comment:
       ```suggestion
   //   categories:
   //     - Testing
   ```

##########
File path: sdks/go/pkg/beam/partition_test.go
##########
@@ -15,6 +15,13 @@
 
 package beam_test
 
+// beam-playground:
+//   name: PartitionTest
+//   description: Unit-test for the Partition example.
+//   multifile: false
+//   pipeline_options:
+//   categories:

Review comment:
       ```suggestion
   //   categories:
   //     - Testing
   ```

##########
File path: sdks/python/apache_beam/metrics/metric_test.py
##########
@@ -17,6 +17,14 @@
 
 # pytype: skip-file
 
+# beam-playground:
+#   name: MetricTest
+#   description: Unit-test for the Metric example.
+#   multifile: false
+#   pipeline_options:
+#   categories:
+#	  - Metrics

Review comment:
       ```suggestion
   #     - Metrics
   ```

##########
File path: sdks/go/pkg/beam/testing/ptest/ptest.go
##########
@@ -16,6 +16,14 @@
 // Package ptest contains utilities for pipeline unit testing.
 package ptest
 
+// beam-playground:
+//   name: PTest
+//   description: Contains utilities for pipeline unit testing.

Review comment:
       Why do we need utilities? Do they test anything?

##########
File path: sdks/go/test/integration/xlang/xlang_test.go
##########
@@ -15,6 +15,15 @@
 
 package xlang
 
+// beam-playground:
+//   name: XLangTest
+//   description: Unit-test for the XLang example.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Combiners
+//	   - Testing

Review comment:
       ```suggestion
   //     - Testing
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org