You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/25 05:49:42 UTC

[GitHub] [hive] kasakrisz opened a new pull request #2118: HIVE-24935: Remove outdated check for correlated exists subqueries with full aggregate

kasakrisz opened a new pull request #2118:
URL: https://github.com/apache/hive/pull/2118


   ### What changes were proposed in this pull request?
   1. Remove outdated comment lines and if condition which was moved to `QBSubQueryParseInfo` and implementations of `ExprFactory.createSubqueryExpr`
   2. Renamed boolean variable `noImplicityGby` -> `hasExplicitGby` and negate its semantics.
   
   ### Why are the changes needed?
   Code cleanup. This is a follow-up of: #2039
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   ```
   mvn test -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=subquery_full_aggregate.q -pl itests/qtest -Pitests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] kasakrisz merged pull request #2118: HIVE-24935: Remove outdated check for correlated exists subqueries with full aggregate

Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #2118:
URL: https://github.com/apache/hive/pull/2118


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org