You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/24 23:04:41 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2732: Properly format code in arrow project

rdblue commented on a change in pull request #2732:
URL: https://github.com/apache/iceberg/pull/2732#discussion_r658343335



##########
File path: arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnarBatch.java
##########
@@ -36,17 +36,17 @@
   ColumnarBatch(int numRows, ColumnVector[] columns) {
     for (int i = 0; i < columns.length; i++) {
       int columnValueCount = columns[i].getFieldVector().getValueCount();
-      Preconditions.checkArgument(numRows == columnValueCount,
+      Preconditions.checkArgument(
+          numRows == columnValueCount,

Review comment:
       I don't have a problem with including the condition on the previous line. Is the rule that if one argument starts with a newline that all arguments must be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org