You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:45:59 UTC

[GitHub] [arrow] zeroshade opened a new pull request #8471: [Go][Flight] Add context to flight client auth handler

zeroshade opened a new pull request #8471:
URL: https://github.com/apache/arrow/pull/8471


   During my usage I found that if i wanted to reuse an existing flight client that required authentication, it was difficult to reuse the auth handler since there wasn't a way to tell which goroutine / which auth made a particular request. By passing the context to the client auth handler it allows passing information to the auth handler via the context which could then be utilized by consumers in order to reuse a auth handler so that an entire flight client could be shared across multiple goroutines if desired. 
   
   Corresponding unit test is updated as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-709512672


   https://issues.apache.org/jira/browse/ARROW-10319


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8471: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-709456491


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-716621186


   @kszucs anything you can do to help move this along to get it reviewed and submitted?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-710107160


   @sbinet @wesm 
   
   Just poking you both so I can get this reviewed and merged in. It's pretty small.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-712247323


   Any luck from anyone to get a quick review on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sbinet closed pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
sbinet closed pull request #8471:
URL: https://github.com/apache/arrow/pull/8471


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #8471: ARROW-10319: [Go][Flight] Add context to flight client auth handler

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-716641845


   Seems like it is resolved now :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org