You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@continuum.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2010/09/11 06:51:32 UTC

[jira] Created: (CONTINUUM-2570) PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems

PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems
---------------------------------------------------------------------------------

                 Key: CONTINUUM-2570
                 URL: http://jira.codehaus.org/browse/CONTINUUM-2570
             Project: Continuum
          Issue Type: Bug
          Components: Database
    Affects Versions: 1.4.0 (Beta), 1.3.6
            Reporter: Brett Porter


Line 160 of PlexusJdoUtils swallows an exception, and retries instead. In some circumstances this may have been valid to retry, but in others the exception will lead to an inconsistent state. The second attempt will fail with a different error, leading to some confusion for the user.

One of the following solutions should be put in place:
- log a warning with the original exception, saying it may lead to a later problem
- review the addition of the retry and determine if it should be removed / made more specific so that the original exception will bubble to the user.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-2570) PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234937#action_234937 ] 

Brett Porter commented on CONTINUUM-2570:
-----------------------------------------

related issues are: CONTINUUM-617, CONTINUUM-721

I think this retry should be removed and the deadlock problem fixed properly - but perhaps for now we should log the original exception to track whether they are likely to recur or not.



> PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems
> ---------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2570
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-2570
>             Project: Continuum
>          Issue Type: Bug
>          Components: Database
>    Affects Versions: 1.3.6, 1.4.0 (Beta)
>            Reporter: Brett Porter
>             Fix For: 1.4.1 (Beta)
>
>
> Line 160 of PlexusJdoUtils swallows an exception, and retries instead. In some circumstances this may have been valid to retry, but in others the exception will lead to an inconsistent state. The second attempt will fail with a different error, leading to some confusion for the user.
> One of the following solutions should be put in place:
> - log a warning with the original exception, saying it may lead to a later problem
> - review the addition of the retry and determine if it should be removed / made more specific so that the original exception will bubble to the user.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-2570) PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated CONTINUUM-2570:
------------------------------------

    Fix Version/s: 1.4.1 (Beta)

> PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems
> ---------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2570
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-2570
>             Project: Continuum
>          Issue Type: Bug
>          Components: Database
>    Affects Versions: 1.3.6, 1.4.0 (Beta)
>            Reporter: Brett Porter
>             Fix For: 1.4.1 (Beta)
>
>
> Line 160 of PlexusJdoUtils swallows an exception, and retries instead. In some circumstances this may have been valid to retry, but in others the exception will lead to an inconsistent state. The second attempt will fail with a different error, leading to some confusion for the user.
> One of the following solutions should be put in place:
> - log a warning with the original exception, saying it may lead to a later problem
> - review the addition of the retry and determine if it should be removed / made more specific so that the original exception will bubble to the user.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-2570) PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234936#action_234936 ] 

Brett Porter commented on CONTINUUM-2570:
-----------------------------------------

this is originally derived from: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java?r1=328150&r2=344392&pathrev=400000&diff_format=h



> PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems
> ---------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2570
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-2570
>             Project: Continuum
>          Issue Type: Bug
>          Components: Database
>    Affects Versions: 1.3.6, 1.4.0 (Beta)
>            Reporter: Brett Porter
>             Fix For: 1.4.1 (Beta)
>
>
> Line 160 of PlexusJdoUtils swallows an exception, and retries instead. In some circumstances this may have been valid to retry, but in others the exception will lead to an inconsistent state. The second attempt will fail with a different error, leading to some confusion for the user.
> One of the following solutions should be put in place:
> - log a warning with the original exception, saying it may lead to a later problem
> - review the addition of the retry and determine if it should be removed / made more specific so that the original exception will bubble to the user.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-2570) PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems

Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/CONTINUUM-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Catherine Tan updated CONTINUUM-2570:
-------------------------------------------

    Fix Version/s:     (was: 1.4.1 (Beta))
                   1.4.2 (Beta)

> PlexusJdoUtils swallows exceptions, making it difficult to diagnose some problems
> ---------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2570
>                 URL: https://jira.codehaus.org/browse/CONTINUUM-2570
>             Project: Continuum
>          Issue Type: Bug
>          Components: Database
>    Affects Versions: 1.3.6, 1.4.0 (Beta)
>            Reporter: Brett Porter
>             Fix For: 1.4.2 (Beta)
>
>
> Line 160 of PlexusJdoUtils swallows an exception, and retries instead. In some circumstances this may have been valid to retry, but in others the exception will lead to an inconsistent state. The second attempt will fail with a different error, leading to some confusion for the user.
> One of the following solutions should be put in place:
> - log a warning with the original exception, saying it may lead to a later problem
> - review the addition of the retry and determine if it should be removed / made more specific so that the original exception will bubble to the user.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira