You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/10 15:06:32 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #9002: MINOR: Add ApiMessageTypeGenerator

cmccabe commented on a change in pull request #9002:
URL: https://github.com/apache/kafka/pull/9002#discussion_r452902273



##########
File path: generator/src/main/java/org/apache/kafka/message/MessageGenerator.java
##########
@@ -267,10 +283,10 @@ public static void main(String[] args) throws Exception {
         if (args.length == 0) {
             System.out.println(USAGE);
             System.exit(0);
-        } else if (args.length != 3) {
+        } else if (args.length != 4) {

Review comment:
       It's traditional for invoking a program with no arguments to print out the usage message, and exit with success, which is 0.  If there was a usage error, then we exit with failure, which is 1.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org