You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Bannier (JIRA)" <ji...@apache.org> on 2017/09/14 18:28:00 UTC
[jira] [Updated] (MESOS-7979) reviewboard's GUESS_FIELDS setting
leads to redundant information in commit messages
[ https://issues.apache.org/jira/browse/MESOS-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bannier updated MESOS-7979:
------------------------------------
Description:
Reviewboard can be set up to automatically guess a patch's summary and description when {{GUESS_FIELDS}} is set. For commits that have no dedicated description, it uses the commit summary as description as well. This leads to commits with redundant commit messages, e.g.,
{code}
Frobnicate the foobarizer.
Frobnicate the foobarizer.
Review: https://reviews.apache.org/r/1234567890
{code}
When applying this commit with e.g., {{apply_reviews.py}} the redundant body is faithfully copied, but we should consider updating it to instead remove the redundant information automatically leading to e.g.,
{code}
Frobnicate the foobarizer.
Review: https://reviews.apache.org/r/1234567890
{code}
was:
Reviewboard can be set up to automatically guess a patch's summary and description when {{GUESS_FIELDS}} is set. For commits that have no dedicated description, it uses the commit summary as description as well. This leads to commits with redundant commit messages, e.g.,
{code}
Frobnicate to foobarizer.
Frobnicate to foobarizer.
Review: https://reviews.apache.org/r/1234567890
{code}
When applying this commit with e.g., {{apply_reviews.py}} the redundant body is faithfully copied, but we should consider updating it to instead remove the redundant information automatically leading to e.g.,
{code}
Frobnicate to foobarizer.
Review: https://reviews.apache.org/r/1234567890
{code}
> reviewboard's GUESS_FIELDS setting leads to redundant information in commit messages
> ------------------------------------------------------------------------------------
>
> Key: MESOS-7979
> URL: https://issues.apache.org/jira/browse/MESOS-7979
> Project: Mesos
> Issue Type: Bug
> Reporter: Benjamin Bannier
> Priority: Minor
> Labels: mesosphere, newbie, python
>
> Reviewboard can be set up to automatically guess a patch's summary and description when {{GUESS_FIELDS}} is set. For commits that have no dedicated description, it uses the commit summary as description as well. This leads to commits with redundant commit messages, e.g.,
> {code}
> Frobnicate the foobarizer.
> Frobnicate the foobarizer.
> Review: https://reviews.apache.org/r/1234567890
> {code}
> When applying this commit with e.g., {{apply_reviews.py}} the redundant body is faithfully copied, but we should consider updating it to instead remove the redundant information automatically leading to e.g.,
> {code}
> Frobnicate the foobarizer.
> Review: https://reviews.apache.org/r/1234567890
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)