You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/25 13:44:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #11838: Constraints generation runs regardless from test status
potiuk opened a new pull request #11838:
URL: https://github.com/apache/airflow/pull/11838
Constraints generation did not run when tests were failing
but this was wrong. In case of tests that fail due to constraints
upgrade we neeed to see the output of constraint generation, to
know which constraints failed. Only pushing the constraint
should be limited to the case where everything succeeded.
This should make investigation of problems similar to #11837 much
easier.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11838: Constraints generation runs regardless from test status
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11838:
URL: https://github.com/apache/airflow/pull/11838#issuecomment-717090678
Simple thing to easier analyse problems with constraints please :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11838: Constraints generation runs regardless from test status
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11838:
URL: https://github.com/apache/airflow/pull/11838
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org