You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Will McQueen (JIRA)" <ji...@apache.org> on 2012/04/30 00:29:50 UTC
[jira] [Created] (FLUME-1164) Reconsider whether configure() should
be called on the same component object after a reconfig event
Will McQueen created FLUME-1164:
-----------------------------------
Summary: Reconsider whether configure() should be called on the same component object after a reconfig event
Key: FLUME-1164
URL: https://issues.apache.org/jira/browse/FLUME-1164
Project: Flume
Issue Type: Bug
Components: Configuration
Affects Versions: v1.2.0
Reporter: Will McQueen
Fix For: v1.2.0
After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
For reference, please see:
FLUME-932
FLUME-933
FLUME-1036
FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1164) Reconsider whether configure()
should be called on the same component object after a reconfig event
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271082#comment-13271082 ]
jiraposter@reviews.apache.org commented on FLUME-1164:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4939/#review7719
-----------------------------------------------------------
Ship it!
+1
Please rebase the patch and attach it to the Jira.
- Arvind
On 2012-04-30 21:33:09, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4939/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-30 21:33:09)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.
bq.
bq.
bq. This addresses bug FLUME-1164.
bq. https://issues.apache.org/jira/browse/FLUME-1164
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5
bq. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b
bq. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
bq.
bq. Diff: https://reviews.apache.org/r/4939/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1164) Reconsider whether configure() should
be called on the same component object after a reconfig event
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated FLUME-1164:
------------------------------------
Status: Patch Available (was: Open)
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1164-rebased.patch
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1164) Reconsider whether configure() should
be called on the same component object after a reconfig event
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated FLUME-1164:
------------------------------------
Attachment: FLUME-1164-rebased.patch
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1164-rebased.patch
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1164) Reconsider whether configure()
should be called on the same component object after a reconfig event
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271718#comment-13271718 ]
jiraposter@reviews.apache.org commented on FLUME-1164:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4939/
-----------------------------------------------------------
(Updated 2012-05-09 19:26:00.814385)
Review request for Flume.
Changes
-------
Rebased. updated a test class to support the new interface.
Summary
-------
Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.
This addresses bug FLUME-1164.
https://issues.apache.org/jira/browse/FLUME-1164
Diffs (updated)
-----
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 878feda
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 292ebcd
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 48659c4
Diff: https://reviews.apache.org/r/4939/diff
Testing
-------
Thanks,
Hari
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1164) Reconsider whether configure()
should be called on the same component object after a reconfig event
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265394#comment-13265394 ]
jiraposter@reviews.apache.org commented on FLUME-1164:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4939/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.
This addresses bug FLUME-1164.
https://issues.apache.org/jira/browse/FLUME-1164
Diffs
-----
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
Diff: https://reviews.apache.org/r/4939/diff
Testing
-------
Thanks,
Hari
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1164) Configure should be called after
stopping all events.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1164:
------------------------------------
Summary: Configure should be called after stopping all events. (was: Reconsider whether configure() should be called on the same component object after a reconfig event)
> Configure should be called after stopping all events.
> -----------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1164-rebased.patch
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-1164) Reconsider whether configure()
should be called on the same component object after a reconfig event
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan reassigned FLUME-1164:
---------------------------------------
Assignee: Hari Shreedharan
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1164) Reconsider whether configure() should
be called on the same component object after a reconfig event
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated FLUME-1164:
------------------------------------
Affects Version/s: (was: v1.2.0)
v1.1.0
Note that this affects v1.1.0.
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1164) Configure should be called after
stopping all events.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1164:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Thanks Hari!
> Configure should be called after stopping all events.
> -----------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1164-rebased.patch
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1164) Configure should be called after
stopping all events.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271884#comment-13271884 ]
Hudson commented on FLUME-1164:
-------------------------------
Integrated in flume-trunk #202 (See [https://builds.apache.org/job/flume-trunk/202/])
FLUME-1164. Configure should be called after stopping all components.
(Hari Shreedharan via Arvind Prabhakar) (Revision 1336416)
Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1336416
Files :
* /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
* /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
* /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java
* /incubator/flume/trunk/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
> Configure should be called after stopping all events.
> -----------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1164-rebased.patch
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira