You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2012/03/23 19:54:15 UTC
Re: svn commit: r1304377 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
On 03/23/2012 03:39 PM, sebb@apache.org wrote:
> Author: sebb
> Date: Fri Mar 23 14:39:56 2012
> New Revision: 1304377
>
> URL: http://svn.apache.org/viewvc?rev=1304377&view=rev
> Log:
> Refix bug introduced in r1304137
> (accidentally converted assertFalse to assertEquals)
>
> Modified:
> commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
>
> Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java?rev=1304377&r1=1304376&r2=1304377&view=diff
> ==============================================================================
> --- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java (original)
> +++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java Fri Mar 23 14:39:56 2012
> @@ -341,7 +341,7 @@ public class HexTest {
> actual = Hex.encodeHex(b, true);
> assertEquals(expected, new String(actual));
> actual = Hex.encodeHex(b, false);
> - assertEquals(expected.toUpperCase(), new String(actual));
> + assertFalse(expected.equals(new String(actual)));
> }
didn't like the way I fixed it? ;-)
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1304377 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
Posted by sebb <se...@gmail.com>.
On 23 March 2012 18:54, Thomas Neidhart <th...@gmail.com> wrote:
> On 03/23/2012 03:39 PM, sebb@apache.org wrote:
>> Author: sebb
>> Date: Fri Mar 23 14:39:56 2012
>> New Revision: 1304377
>>
>> URL: http://svn.apache.org/viewvc?rev=1304377&view=rev
>> Log:
>> Refix bug introduced in r1304137
>> (accidentally converted assertFalse to assertEquals)
>>
>> Modified:
>> commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
>>
>> Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java
>> URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java?rev=1304377&r1=1304376&r2=1304377&view=diff
>> ==============================================================================
>> --- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java (original)
>> +++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java Fri Mar 23 14:39:56 2012
>> @@ -341,7 +341,7 @@ public class HexTest {
>> actual = Hex.encodeHex(b, true);
>> assertEquals(expected, new String(actual));
>> actual = Hex.encodeHex(b, false);
>> - assertEquals(expected.toUpperCase(), new String(actual));
>> + assertFalse(expected.equals(new String(actual)));
>> }
>
> didn't like the way I fixed it? ;-)
It wasn't that - I was restoring the original behaviour that I broke by mistake.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org