You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by drmacro <gi...@git.apache.org> on 2018/08/01 21:35:30 UTC
[GitHub] poi pull request #119: Implemented a number of new set and get methods for u...
GitHub user drmacro opened a pull request:
https://github.com/apache/poi/pull/119
Implemented a number of new set and get methods for useful formatting…
This adds getters and setters for additional Run formatting properties. My goal was to implement the properties likely to be used in generating DOCX from non-trivial HTML documents. The only property I couldn't figure out how to set was underline color, which I can come back to.
I also fixed a bug in isHighlight() that returned a false positive if highlight was not set at all (the test case was flawed and didn't catch this case).
I used the built-in OOXML enums so that I could set values using the same strings as specified in the OO XML spec rather than having to translate them to e.g., uppercase keywords as used with the custom enumerations (this is why I implemented setVerticalAlignment() as a replacement for setSubscript() [which was a bad method name anyway.]
I did not implement versions of the methods that involve enumerations to also allow direct specification of the enumeration values themselves--I can if there's a need for it, but for most uses it seems more likely that string values will be the input, e.g., from parsing of XML or HTML or whatever.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drmacro/poi feature/run-formatting-settings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/poi/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit d549b48a3857769b664c4c6dfa6c9e68f62981fc
Author: Eliot Kimber <dr...@...>
Date: 2018-08-01T21:23:47Z
Implemented a number of new set and get methods for useful formatting properties.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] poi pull request #119: Implemented a number of new set and get methods for u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/poi/pull/119
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org