[jira] Updated: (TRINIDAD-1101) Invalid assert and comment in CoreRenderingContext

["Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TRINIDAD-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott O'Bryan updated TRINIDAD-1101:
------------------------------------

    Status: Patch Available  (was: Open)

> Invalid assert and comment in CoreRenderingContext
> --------------------------------------------------
>
>                 Key: TRINIDAD-1101
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1101
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions:  1.0.8-core,  1.2.8-core
>            Reporter: Scott O'Bryan
>            Assignee: Scott O'Bryan
>            Priority: Minor
>             Fix For: 1.0.9-core, 1.2.9-core
>
>         Attachments: TRINIDAD-1101.patch
>
>
> The CoreRenderingContext.getFormData() contains an invalid assert that often triggers when asserts are turned on.   The invalid assert checks to see if formData is null.  I did a check for all code referencing getFormData and they all seem to handle a null value being returned, therefore, this assert is invalid because a null formData seems to be part of the normal execution of this method.  Furthermore, the comment on  CoreRenderingContext.getFormData() says that the method will create a new formData if one is not present.  This does not agree with either the usage OR the assert.
> Therefore we need to switch this method so that it works with the current usage of the class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.