[GitHub] [superset] kasiazjc commented on pull request #18793: feat: Adds support to multiple dependencies to the native filters

[GitBox <gi...@apache.org>]

kasiazjc commented on pull request #18793:
URL: https://github.com/apache/superset/pull/18793#issuecomment-1058062647


   Looks great! From my perspective - all of the things that were supposed to be included in Stage 1 were implemented and are added to this PR. I also tested the feature and it seems to be working well. Kudos @michael-s-molina @kgabryje @jinghua-qa 👏 
   
   One additional comment from me - you may see that the filter type is different on filter card and in "add/edit filters" modal. This is something that has to be fixed separately and hopefully will be fixed soon (cc: @kgabryje)  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org