You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/16 09:36:17 UTC
Review Request 55563: Added capabilities to master's Slave struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55563/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Bugs: MESOS-6902
https://issues.apache.org/jira/browse/MESOS-6902
Repository: mesos
Description
-------
This is used to easily deal with Agent capabilities.
Diffs
-----
src/common/protobuf_utils.hpp 9dee91afdd1e2d4d0d7abd4671133b1fd25b418f
src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004
src/tests/protobuf_utils_tests.cpp 6940b66080ce403ead97a8b789beebf72aeea90a
Diff: https://reviews.apache.org/r/55563/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 55563: Added capabilities to master's Slave struct.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55563/#review161950
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 16, 2017, 9:36 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55563/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 9:36 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-6902
> https://issues.apache.org/jira/browse/MESOS-6902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is used to easily deal with Agent capabilities.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 9dee91afdd1e2d4d0d7abd4671133b1fd25b418f
> src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004
> src/tests/protobuf_utils_tests.cpp 6940b66080ce403ead97a8b789beebf72aeea90a
>
> Diff: https://reviews.apache.org/r/55563/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 55563: Added capabilities to master's Slave struct.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55563/#review161726
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55561, 55562, 55563]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos ReviewBot
On Jan. 16, 2017, 9:36 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55563/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 9:36 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-6902
> https://issues.apache.org/jira/browse/MESOS-6902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is used to easily deal with Agent capabilities.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 9dee91afdd1e2d4d0d7abd4671133b1fd25b418f
> src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004
> src/tests/protobuf_utils_tests.cpp 6940b66080ce403ead97a8b789beebf72aeea90a
>
> Diff: https://reviews.apache.org/r/55563/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>