You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2018/05/18 08:30:50 UTC

[1/8] wicket git commit: Updated to Java 9

Repository: wicket
Updated Branches:
  refs/heads/wicket-9.x [created] 8c058e49f


Updated to Java 9

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4fe3a916
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4fe3a916
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4fe3a916

Branch: refs/heads/wicket-9.x
Commit: 4fe3a916003852d43e3fd8ad32715aa6511e86cc
Parents: 167a14e
Author: Andrea Del Bene <an...@gmail.com>
Authored: Sat Apr 14 13:17:36 2018 +0200
Committer: Andrea Del Bene <an...@gmail.com>
Committed: Sat May 12 20:05:11 2018 +0200

----------------------------------------------------------------------
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/4fe3a916/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index d098c7f..fbecbb9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -119,8 +119,8 @@
 		<maven.compiler.optimize>true</maven.compiler.optimize>
 		<maven.compiler.showDeprecation>true</maven.compiler.showDeprecation>
 		<maven.compiler.showWarnings>true</maven.compiler.showWarnings>
-		<maven.compiler.source>1.8</maven.compiler.source>
-		<maven.compiler.target>1.8</maven.compiler.target>
+		<maven.compiler.source>9</maven.compiler.source>
+		<maven.compiler.target>9</maven.compiler.target>
 
 		<!-- Project Versions -->
 		<cglib.version>3.2.5</cglib.version>


[7/8] wicket git commit: Fix to resolve Arquillian dependencies online

Posted by ad...@apache.org.
Fix to resolve Arquillian dependencies online


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e5828ab4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e5828ab4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e5828ab4

Branch: refs/heads/wicket-9.x
Commit: e5828ab40a5d87bd217e6e6c55ed9f823af3c983
Parents: c07b095
Author: Andrea Del Bene <an...@edenviaggi.it>
Authored: Mon May 14 17:37:46 2018 +0200
Committer: Andrea Del Bene <an...@edenviaggi.it>
Committed: Mon May 14 17:37:46 2018 +0200

----------------------------------------------------------------------
 pom.xml                                                       | 2 +-
 .../arquillian/testing/deployment/AbstractDeploymentTest.java | 3 +--
 wicket-examples/pom.xml                                       | 7 +------
 3 files changed, 3 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/e5828ab4/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 253b757..65bb077 100644
--- a/pom.xml
+++ b/pom.xml
@@ -125,7 +125,7 @@
 		<!-- Project Versions -->
 		<cglib.version>3.2.5</cglib.version>
 		<jacoco.version>0.7.9</jacoco.version>
-		<jetty.version>9.4.7.v20170914</jetty.version>
+		<jetty.version>9.4.10.v20180503</jetty.version>
 		<joda-time.version>2.9.9</joda-time.version>
 		<junit.version>4.12</junit.version>
 		<spring.version>4.3.10.RELEASE</spring.version>

http://git-wip-us.apache.org/repos/asf/wicket/blob/e5828ab4/testing/wicket-arquillian/src/test/java/org/apache/wicket/arquillian/testing/deployment/AbstractDeploymentTest.java
----------------------------------------------------------------------
diff --git a/testing/wicket-arquillian/src/test/java/org/apache/wicket/arquillian/testing/deployment/AbstractDeploymentTest.java b/testing/wicket-arquillian/src/test/java/org/apache/wicket/arquillian/testing/deployment/AbstractDeploymentTest.java
index 7a3e1a2..cb3c3eb 100644
--- a/testing/wicket-arquillian/src/test/java/org/apache/wicket/arquillian/testing/deployment/AbstractDeploymentTest.java
+++ b/testing/wicket-arquillian/src/test/java/org/apache/wicket/arquillian/testing/deployment/AbstractDeploymentTest.java
@@ -73,8 +73,7 @@ public abstract class AbstractDeploymentTest {
 		
 		// Create libs from POM.XML.
 		File[] asFile = Maven.configureResolver()
-				// I'm not using internet directly, I have a Nexus Repository that handles the libs for me.
-				.workOffline().withMavenCentralRepo(false)
+				.withMavenCentralRepo(true)
 				// Load everything from pom, that is compile and runtime, as a file and transitivity to don't loose anything and cause exceptions.
 				.loadPomFromFile("./pom.xml").importCompileAndRuntimeDependencies()
 				.resolve().withTransitivity().asFile();

http://git-wip-us.apache.org/repos/asf/wicket/blob/e5828ab4/wicket-examples/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
index 6e1aa5e..856373f 100644
--- a/wicket-examples/pom.xml
+++ b/wicket-examples/pom.xml
@@ -56,12 +56,7 @@
 				<groupId>org.codelibs</groupId>
 				<artifactId>jhighlight</artifactId>
 				<version>1.0.3</version>
-				<exclusions>
-					<exclusion>
-						<groupId>javax.servlet</groupId>
-						<artifactId>servlet-api</artifactId>
-					</exclusion>
-				</exclusions>
+				
 			</dependency>
 			<dependency>
 				<groupId>org.hibernate</groupId>


Re: [4/8] wicket git commit: Added missing java 9 module

Posted by Andrea Del Bene <an...@gmail.com>.
In short, code migration was trivial, except for the Wildfly/Arquillian
which required a lot of config  troubleshooting :-)

On Fri, May 18, 2018 at 12:32 PM, Andrea Del Bene <an...@gmail.com>
wrote:

> I did that particular change because with the new Wildfly/Arquillian
> versions I got a NPE with MockHttpServletRequest#getSession(boolean b).
> In short this method returns null id the current session is temporary.
> According to Martin's commit (7ca927c) this was done  in order to comply
> with servlet spec. Later I decided to not change this behavior but rather
> make MockHttpServletRequestTest use permanent sessions.
>
> On Fri, May 18, 2018 at 12:15 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
>> Thanks Andrea,
>>
>> I have noticed that while looking through later commits
>> Should answer myself :(
>>
>> Was curious what changes were required to create java9 compatible build :)
>>
>> On Fri, May 18, 2018 at 5:13 PM, Andrea Del Bene <an...@gmail.com>
>> wrote:
>>
>> > Hi,
>> >
>> > changes to MockHttpServletRequest and its test have been reverted in a
>> > later commit, so the final code doesn't contain the commented out code.
>> >
>> > On Fri, May 18, 2018 at 10:47 AM, Maxim Solodovnik <
>> solomax666@gmail.com>
>> > wrote:
>> >
>> > > Is this commented out code really necessary?
>> > > Or maybe it should be fixed?
>> > >
>> > > On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:
>> > >
>> > > > Added missing java 9 module
>> > > >
>> > > >
>> > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>> > > > Commit: http://git-wip-us.apache.org/r
>> epos/asf/wicket/commit/26557b35
>> > > > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
>> > > > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35
>> > > >
>> > > > Branch: refs/heads/wicket-9.x
>> > > > Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
>> > > > Parents: bfbdfe2
>> > > > Author: Andrea Del Bene <an...@gmail.com>
>> > > > Authored: Sun May 13 21:25:43 2018 +0200
>> > > > Committer: Andrea Del Bene <an...@gmail.com>
>> > > > Committed: Sun May 13 21:25:43 2018 +0200
>> > > >
>> > > > ------------------------------------------------------------
>> ----------
>> > > >  pom.xml                                         | 25
>> ++++++++++++++-
>> > > >  testing/wicket-arquillian/pom.xml               |  8 ++++-
>> > > >  wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
>> > > >  .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
>> > > >  .../http/mock/MockHttpServletRequest.java       |  8 +----
>> > > >  .../http/mock/MockHttpServletRequestTest.java   | 32
>> > > ++++++++++----------
>> > > >  6 files changed, 69 insertions(+), 28 deletions(-)
>> > > > ------------------------------------------------------------
>> ----------
>> > > >
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/pom.xml b/pom.xml
>> > > > index 8e3a754..fd8498c 100644
>> > > > --- a/pom.xml
>> > > > +++ b/pom.xml
>> > > > @@ -442,6 +442,28 @@
>> > > >                                 <version>2.4.2.SP1</version>
>> > > >                         </dependency>
>> > > >                         <dependency>
>> > > > +                           <groupId>org.jboss.weld</groupId>
>> > > > +                           <artifactId>weld-spi</artifactId>
>> > > > +                           <version>3.0.SP3</version>
>> > > > +                       </dependency>
>> > > > +                       <dependency>
>> > > > +                           <groupId>org.jboss.weld.modul
>> e</groupId>
>> > > > +                           <artifactId>weld-web</artifactId>
>> > > > +                           <version>3.0.4.Final</version>
>> > > > +                       </dependency>
>> > > > +
>> > > > +                       <dependency>
>> > > > +                           <groupId>org.jboss.weld</groupId>
>> > > > +                           <artifactId>weld-core</artifactId>
>> > > > +                           <version>2.4.7.Final</version>
>> > > > +                       </dependency>
>> > > > +                       <dependency>
>> > > > +                           <groupId>org.jboss.weld.se</groupId>
>> > > > +                           <artifactId>weld-se</artifactId>
>> > > > +                           <version>2.4.7.Final</version>
>> > > > +                           <scope>test</scope>
>> > > > +                       </dependency>
>> > > > +                       <dependency>
>> > > >                                 <groupId>org.objenesis</groupId>
>> > > >                                 <artifactId>objenesis</artifactId>
>> > > >                                 <version>${objenesis.version}<
>> > /version>
>> > > > @@ -544,7 +566,7 @@
>> > > >                         <dependency>
>> > > >                                 <groupId>org.jglue.cdi-unit</
>> groupId>
>> > > >                                 <artifactId>cdi-unit</artifactId>
>> > > > -                               <version>2.2.1</version>
>> > > > +                               <version>4.0.2</version>
>> > > >                                 <scope>test</scope>
>> > > >                         </dependency>
>> > > >                         <dependency>
>> > > > @@ -959,6 +981,7 @@
>> > > >                                                 <includes>
>> > > >
>> > > > <include>**/*Test.java</include>
>> > > >                                                 </includes>
>> > > > +                                               <argLine>--add-opens
>> > > > java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
>> > > >                                         </configuration>
>> > > >                                         <dependencies>
>> > > >                                                 <dependency>
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> > > > 26557b35/testing/wicket-arquillian/pom.xml
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/testing/wicket-arquillian/pom.xml
>> > > > b/testing/wicket-arquillian/pom.xml
>> > > > index f82ed07..954dd62 100644
>> > > > --- a/testing/wicket-arquillian/pom.xml
>> > > > +++ b/testing/wicket-arquillian/pom.xml
>> > > > @@ -42,7 +42,7 @@
>> > > >                 <wicket.arquillian.management.
>> > > > port>11091</wicket.arquillian.management.port>
>> > > >                 <!-- end port configuration -->
>> > > >
>> > > > -               <arquillian.version>1.1.13.Fi
>> nal</arquillian.version>
>> > > > +               <arquillian.version>1.4.0.Fin
>> al</arquillian.version>
>> > > >                 <maven.dependency.plugin.version>2.10</maven.
>> > > > dependency.plugin.version>
>> > > >                 <project.build.sourceEncoding>UTF-8</project.build.
>> > > > sourceEncoding>
>> > > >                 <wildfly.version>8.2.1.Final</wildfly.version>
>> > > > @@ -84,6 +84,12 @@
>> > > >                         <groupId>org.wildfly</groupId>
>> > > >                         <artifactId>wildfly-embedded</artifactId>
>> > > >                         <version>${wildfly.version}</version>
>> > > > +                       <exclusions>
>> > > > +            <exclusion>
>> > > > +                <groupId>sun.jdk</groupId>
>> > > > +                <artifactId>jconsole</artifactId>
>> > > > +            </exclusion>
>> > > > +        </exclusions>
>> > > >                 </dependency>
>> > > >                 <dependency>
>> > > >                         <groupId>org.jboss.
>> arquillian.junit</groupId>
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> > > > 26557b35/wicket-cdi-1.1/pom.xml
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
>> > > > index 957ff0e..9bfa684 100644
>> > > > --- a/wicket-cdi-1.1/pom.xml
>> > > > +++ b/wicket-cdi-1.1/pom.xml
>> > > > @@ -60,5 +60,22 @@
>> > > >                         <groupId>org.jglue.cdi-unit</groupId>
>> > > >                         <artifactId>cdi-unit</artifactId>
>> > > >                 </dependency>
>> > > > +               <dependency>
>> > > > +                   <groupId>org.jboss.weld</groupId>
>> > > > +                   <artifactId>weld-spi</artifactId>
>> > > > +               </dependency>
>> > > > +               <dependency>
>> > > > +                   <groupId>org.jboss.weld</groupId>
>> > > > +                   <artifactId>weld-core</artifactId>
>> > > > +               </dependency>
>> > > > +               <dependency>
>> > > > +                   <groupId>org.jboss.weld.se</groupId>
>> > > > +                   <artifactId>weld-se</artifactId>
>> > > > +                   <scope>test</scope>
>> > > > +               </dependency>
>> > > > +               <dependency>
>> > > > +                       <groupId>org.jboss.weld.module</groupId>
>> > > > +                       <artifactId>weld-web</artifactId>
>> > > > +               </dependency>
>> > > >         </dependencies>
>> > > >  </project>
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> > > > 26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/
>> > > > cdi/ContextManager.java
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
>> > > ContextManager.java
>> > > > b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
>> > ContextManager.java
>> > > > index 3e22aef..ee92367 100644
>> > > > --- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
>> > > > ContextManager.java
>> > > > +++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
>> > > > ContextManager.java
>> > > > @@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
>> > > >  import org.jboss.weld.bean.builtin.BeanManagerProxy;
>> > > >  import org.jboss.weld.servlet.HttpContextLifecycle;
>> > > >  import org.jboss.weld.servlet.spi.helpers.
>> > > AcceptingHttpContextActivation
>> > > > Filter;
>> > > > -import org.jglue.cdiunit.internal.LifecycleAwareRequest;
>> > > > +import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
>> > > > +import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
>> > > >
>> > > >  /**
>> > > >   * @author jsarman
>> > > > @@ -49,7 +50,7 @@ public class ContextManager
>> > > >                 try
>> > > >                 {
>> > > >                         lifecycle = new HttpContextLifecycle(
>> > > > BeanManagerProxy.unwrap(beanManager),
>> > > > -
>> AcceptingHttpContextActivation
>> > > Filter.INSTANCE,
>> > > > true, true);
>> > > > +
>> AcceptingHttpContextActivation
>> > > Filter.INSTANCE,
>> > > > true, true, false, true);
>> > > >                 }
>> > > >                 catch (NoSuchMethodError e)
>> > > >                 {
>> > > > @@ -73,7 +74,7 @@ public class ContextManager
>> > > >                 if (currentRequest != null)
>> > > >                         return;
>> > > >
>> > > > -               currentRequest = new LifecycleAwareRequest(lifecycl
>> e,
>> > > > request, currentSession);
>> > > > +               currentRequest = new LifecycleAwareRequest(new
>> > > > CdiUnitInitialListenerImpl(), request);
>> > > >                 lifecycle.requestInitialized(currentRequest, null);
>> > > >         }
>> > > >
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> > > > 26557b35/wicket-core/src/main/java/org/apache/wicket/
>> > protocol/http/mock/
>> > > > MockHttpServletRequest.java
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/
>> > > > http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/
>> > > > org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
>> > > > index 44ee8d4..10c878d 100755
>> > > > --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/
>> mock/
>> > > > MockHttpServletRequest.java
>> > > > +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/
>> mock/
>> > > > MockHttpServletRequest.java
>> > > > @@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements
>> > > > HttpServletRequest
>> > > >         @Override
>> > > >         public HttpSession getSession(boolean b)
>> > > >         {
>> > > > -               HttpSession sess = null;
>> > > >                 if (session instanceof MockHttpSession)
>> > > >                 {
>> > > >                         MockHttpSession mockHttpSession =
>> > > > (MockHttpSession)session;
>> > > > @@ -1188,13 +1187,8 @@ public class MockHttpServletRequest
>> implements
>> > > > HttpServletRequest
>> > > >                         {
>> > > >                                 mockHttpSession.setTemporary(
>> false);
>> > > >                         }
>> > > > -
>> > > > -                       if (mockHttpSession.isTemporary() == false)
>> > > > -                       {
>> > > > -                               sess = session;
>> > > > -                       }
>> > > >                 }
>> > > > -               return sess;
>> > > > +               return session;
>> > > >         }
>> > > >
>> > > >         /**
>> > > >
>> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> > > > 26557b35/wicket-core/src/test/java/org/apache/wicket/
>> > protocol/http/mock/
>> > > > MockHttpServletRequestTest.java
>> > > > ------------------------------------------------------------
>> ----------
>> > > > diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/
>> > > > http/mock/MockHttpServletRequestTest.java
>> b/wicket-core/src/test/java/
>> > > > org/apache/wicket/protocol/http/mock/MockHttpServletRequestT
>> est.java
>> > > > index 99f956e..8f0802c 100755
>> > > > --- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/
>> mock/
>> > > > MockHttpServletRequestTest.java
>> > > > +++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/
>> mock/
>> > > > MockHttpServletRequestTest.java
>> > > > @@ -119,22 +119,22 @@ public class MockHttpServletRequestTest
>> extends
>> > > > WicketTestCase
>> > > >          assertNull(url.getQueryString());
>> > > >      }
>> > > >
>> > > > -       @Test
>> > > > -       public void getSessionFromNonMockHttpSession()
>> > > > -       {
>> > > > -               HttpSession httpSession = Mockito.mock(HttpSession.
>> > > class);
>> > > > -               MockHttpServletRequest request = new
>> > > > MockHttpServletRequest(null, httpSession, null);
>> > > > -               assertNull("MockHttpServletRequest knows how to
>> work
>> > > only
>> > > > with MockHttpSession", request.getSession(true));
>> > > > -               assertNull("MockHttpServletRequest knows how to
>> work
>> > > only
>> > > > with MockHttpSession", request.getSession(false));
>> > > > -       }
>> > > > -
>> > > > -       @Test
>> > > > -       public void getSessionFalseFromMockHttpSession()
>> > > > -       {
>> > > > -               HttpSession httpSession = new MockHttpSession(null);
>> > > > -               MockHttpServletRequest request = new
>> > > > MockHttpServletRequest(null, httpSession, null);
>> > > > -               assertNull("HttpSession should not be created!",
>> > > > request.getSession(false));
>> > > > -       }
>> > > > +//     @Test
>> > > > +//     public void getSessionFromNonMockHttpSession()
>> > > > +//     {
>> > > > +//             HttpSession httpSession = Mockito.mock(HttpSession.
>> > > class);
>> > > > +//             MockHttpServletRequest request = new
>> > > > MockHttpServletRequest(null, httpSession, null);
>> > > > +//             assertTrue("MockHttpServletRequest knows how to
>> work
>> > > only
>> > > > with MockHttpSession", request.getSession(true).);
>> > > > +//             assertNull("MockHttpServletRequest knows how to
>> work
>> > > only
>> > > > with MockHttpSession", request.getSession(false));
>> > > > +//     }
>> > > > +//
>> > > > +//     @Test
>> > > > +//     public void getSessionFalseFromMockHttpSession()
>> > > > +//     {
>> > > > +//             HttpSession httpSession = new MockHttpSession(null);
>> > > > +//             MockHttpServletRequest request = new
>> > > > MockHttpServletRequest(null, httpSession, null);
>> > > > +//             assertNull("HttpSession should not be created!",
>> > > > request.getSession(false));
>> > > > +//     }
>> > > >
>> > > >         @Test
>> > > >         public void getSessionDefaultFromMockHttpSession()
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > > WBR
>> > > Maxim aka solomax
>> > >
>> >
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>

Re: [4/8] wicket git commit: Added missing java 9 module

Posted by Andrea Del Bene <an...@gmail.com>.
I did that particular change because with the new Wildfly/Arquillian
versions I got a NPE with MockHttpServletRequest#getSession(boolean b). In
short this method returns null id the current session is temporary.
According to Martin's commit (7ca927c) this was done  in order to comply
with servlet spec. Later I decided to not change this behavior but rather
make MockHttpServletRequestTest use permanent sessions.

On Fri, May 18, 2018 at 12:15 PM, Maxim Solodovnik <so...@gmail.com>
wrote:

> Thanks Andrea,
>
> I have noticed that while looking through later commits
> Should answer myself :(
>
> Was curious what changes were required to create java9 compatible build :)
>
> On Fri, May 18, 2018 at 5:13 PM, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > Hi,
> >
> > changes to MockHttpServletRequest and its test have been reverted in a
> > later commit, so the final code doesn't contain the commented out code.
> >
> > On Fri, May 18, 2018 at 10:47 AM, Maxim Solodovnik <solomax666@gmail.com
> >
> > wrote:
> >
> > > Is this commented out code really necessary?
> > > Or maybe it should be fixed?
> > >
> > > On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:
> > >
> > > > Added missing java 9 module
> > > >
> > > >
> > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > > > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/
> 26557b35
> > > > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
> > > > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35
> > > >
> > > > Branch: refs/heads/wicket-9.x
> > > > Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
> > > > Parents: bfbdfe2
> > > > Author: Andrea Del Bene <an...@gmail.com>
> > > > Authored: Sun May 13 21:25:43 2018 +0200
> > > > Committer: Andrea Del Bene <an...@gmail.com>
> > > > Committed: Sun May 13 21:25:43 2018 +0200
> > > >
> > > > ------------------------------------------------------------
> ----------
> > > >  pom.xml                                         | 25 ++++++++++++++-
> > > >  testing/wicket-arquillian/pom.xml               |  8 ++++-
> > > >  wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
> > > >  .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
> > > >  .../http/mock/MockHttpServletRequest.java       |  8 +----
> > > >  .../http/mock/MockHttpServletRequestTest.java   | 32
> > > ++++++++++----------
> > > >  6 files changed, 69 insertions(+), 28 deletions(-)
> > > > ------------------------------------------------------------
> ----------
> > > >
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/pom.xml b/pom.xml
> > > > index 8e3a754..fd8498c 100644
> > > > --- a/pom.xml
> > > > +++ b/pom.xml
> > > > @@ -442,6 +442,28 @@
> > > >                                 <version>2.4.2.SP1</version>
> > > >                         </dependency>
> > > >                         <dependency>
> > > > +                           <groupId>org.jboss.weld</groupId>
> > > > +                           <artifactId>weld-spi</artifactId>
> > > > +                           <version>3.0.SP3</version>
> > > > +                       </dependency>
> > > > +                       <dependency>
> > > > +                           <groupId>org.jboss.weld.module</groupId>
> > > > +                           <artifactId>weld-web</artifactId>
> > > > +                           <version>3.0.4.Final</version>
> > > > +                       </dependency>
> > > > +
> > > > +                       <dependency>
> > > > +                           <groupId>org.jboss.weld</groupId>
> > > > +                           <artifactId>weld-core</artifactId>
> > > > +                           <version>2.4.7.Final</version>
> > > > +                       </dependency>
> > > > +                       <dependency>
> > > > +                           <groupId>org.jboss.weld.se</groupId>
> > > > +                           <artifactId>weld-se</artifactId>
> > > > +                           <version>2.4.7.Final</version>
> > > > +                           <scope>test</scope>
> > > > +                       </dependency>
> > > > +                       <dependency>
> > > >                                 <groupId>org.objenesis</groupId>
> > > >                                 <artifactId>objenesis</artifactId>
> > > >                                 <version>${objenesis.version}<
> > /version>
> > > > @@ -544,7 +566,7 @@
> > > >                         <dependency>
> > > >                                 <groupId>org.jglue.cdi-unit</
> groupId>
> > > >                                 <artifactId>cdi-unit</artifactId>
> > > > -                               <version>2.2.1</version>
> > > > +                               <version>4.0.2</version>
> > > >                                 <scope>test</scope>
> > > >                         </dependency>
> > > >                         <dependency>
> > > > @@ -959,6 +981,7 @@
> > > >                                                 <includes>
> > > >
> > > > <include>**/*Test.java</include>
> > > >                                                 </includes>
> > > > +                                               <argLine>--add-opens
> > > > java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
> > > >                                         </configuration>
> > > >                                         <dependencies>
> > > >                                                 <dependency>
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > 26557b35/testing/wicket-arquillian/pom.xml
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/testing/wicket-arquillian/pom.xml
> > > > b/testing/wicket-arquillian/pom.xml
> > > > index f82ed07..954dd62 100644
> > > > --- a/testing/wicket-arquillian/pom.xml
> > > > +++ b/testing/wicket-arquillian/pom.xml
> > > > @@ -42,7 +42,7 @@
> > > >                 <wicket.arquillian.management.
> > > > port>11091</wicket.arquillian.management.port>
> > > >                 <!-- end port configuration -->
> > > >
> > > > -               <arquillian.version>1.1.13.
> Final</arquillian.version>
> > > > +               <arquillian.version>1.4.0.Final</arquillian.version>
> > > >                 <maven.dependency.plugin.version>2.10</maven.
> > > > dependency.plugin.version>
> > > >                 <project.build.sourceEncoding>UTF-8</project.build.
> > > > sourceEncoding>
> > > >                 <wildfly.version>8.2.1.Final</wildfly.version>
> > > > @@ -84,6 +84,12 @@
> > > >                         <groupId>org.wildfly</groupId>
> > > >                         <artifactId>wildfly-embedded</artifactId>
> > > >                         <version>${wildfly.version}</version>
> > > > +                       <exclusions>
> > > > +            <exclusion>
> > > > +                <groupId>sun.jdk</groupId>
> > > > +                <artifactId>jconsole</artifactId>
> > > > +            </exclusion>
> > > > +        </exclusions>
> > > >                 </dependency>
> > > >                 <dependency>
> > > >                         <groupId>org.jboss.arquillian.
> junit</groupId>
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > 26557b35/wicket-cdi-1.1/pom.xml
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> > > > index 957ff0e..9bfa684 100644
> > > > --- a/wicket-cdi-1.1/pom.xml
> > > > +++ b/wicket-cdi-1.1/pom.xml
> > > > @@ -60,5 +60,22 @@
> > > >                         <groupId>org.jglue.cdi-unit</groupId>
> > > >                         <artifactId>cdi-unit</artifactId>
> > > >                 </dependency>
> > > > +               <dependency>
> > > > +                   <groupId>org.jboss.weld</groupId>
> > > > +                   <artifactId>weld-spi</artifactId>
> > > > +               </dependency>
> > > > +               <dependency>
> > > > +                   <groupId>org.jboss.weld</groupId>
> > > > +                   <artifactId>weld-core</artifactId>
> > > > +               </dependency>
> > > > +               <dependency>
> > > > +                   <groupId>org.jboss.weld.se</groupId>
> > > > +                   <artifactId>weld-se</artifactId>
> > > > +                   <scope>test</scope>
> > > > +               </dependency>
> > > > +               <dependency>
> > > > +                       <groupId>org.jboss.weld.module</groupId>
> > > > +                       <artifactId>weld-web</artifactId>
> > > > +               </dependency>
> > > >         </dependencies>
> > > >  </project>
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > 26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/
> > > > cdi/ContextManager.java
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > > ContextManager.java
> > > > b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > ContextManager.java
> > > > index 3e22aef..ee92367 100644
> > > > --- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > > > ContextManager.java
> > > > +++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > > > ContextManager.java
> > > > @@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
> > > >  import org.jboss.weld.bean.builtin.BeanManagerProxy;
> > > >  import org.jboss.weld.servlet.HttpContextLifecycle;
> > > >  import org.jboss.weld.servlet.spi.helpers.
> > > AcceptingHttpContextActivation
> > > > Filter;
> > > > -import org.jglue.cdiunit.internal.LifecycleAwareRequest;
> > > > +import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
> > > > +import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
> > > >
> > > >  /**
> > > >   * @author jsarman
> > > > @@ -49,7 +50,7 @@ public class ContextManager
> > > >                 try
> > > >                 {
> > > >                         lifecycle = new HttpContextLifecycle(
> > > > BeanManagerProxy.unwrap(beanManager),
> > > > -
>  AcceptingHttpContextActivation
> > > Filter.INSTANCE,
> > > > true, true);
> > > > +
>  AcceptingHttpContextActivation
> > > Filter.INSTANCE,
> > > > true, true, false, true);
> > > >                 }
> > > >                 catch (NoSuchMethodError e)
> > > >                 {
> > > > @@ -73,7 +74,7 @@ public class ContextManager
> > > >                 if (currentRequest != null)
> > > >                         return;
> > > >
> > > > -               currentRequest = new LifecycleAwareRequest(
> lifecycle,
> > > > request, currentSession);
> > > > +               currentRequest = new LifecycleAwareRequest(new
> > > > CdiUnitInitialListenerImpl(), request);
> > > >                 lifecycle.requestInitialized(currentRequest, null);
> > > >         }
> > > >
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > 26557b35/wicket-core/src/main/java/org/apache/wicket/
> > protocol/http/mock/
> > > > MockHttpServletRequest.java
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/
> > > > http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/
> > > > org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
> > > > index 44ee8d4..10c878d 100755
> > > > --- a/wicket-core/src/main/java/org/apache/wicket/protocol/
> http/mock/
> > > > MockHttpServletRequest.java
> > > > +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/
> http/mock/
> > > > MockHttpServletRequest.java
> > > > @@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements
> > > > HttpServletRequest
> > > >         @Override
> > > >         public HttpSession getSession(boolean b)
> > > >         {
> > > > -               HttpSession sess = null;
> > > >                 if (session instanceof MockHttpSession)
> > > >                 {
> > > >                         MockHttpSession mockHttpSession =
> > > > (MockHttpSession)session;
> > > > @@ -1188,13 +1187,8 @@ public class MockHttpServletRequest implements
> > > > HttpServletRequest
> > > >                         {
> > > >                                 mockHttpSession.setTemporary(false);
> > > >                         }
> > > > -
> > > > -                       if (mockHttpSession.isTemporary() == false)
> > > > -                       {
> > > > -                               sess = session;
> > > > -                       }
> > > >                 }
> > > > -               return sess;
> > > > +               return session;
> > > >         }
> > > >
> > > >         /**
> > > >
> > > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > 26557b35/wicket-core/src/test/java/org/apache/wicket/
> > protocol/http/mock/
> > > > MockHttpServletRequestTest.java
> > > > ------------------------------------------------------------
> ----------
> > > > diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/
> > > > http/mock/MockHttpServletRequestTest.java
> b/wicket-core/src/test/java/
> > > > org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
> > > > index 99f956e..8f0802c 100755
> > > > --- a/wicket-core/src/test/java/org/apache/wicket/protocol/
> http/mock/
> > > > MockHttpServletRequestTest.java
> > > > +++ b/wicket-core/src/test/java/org/apache/wicket/protocol/
> http/mock/
> > > > MockHttpServletRequestTest.java
> > > > @@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends
> > > > WicketTestCase
> > > >          assertNull(url.getQueryString());
> > > >      }
> > > >
> > > > -       @Test
> > > > -       public void getSessionFromNonMockHttpSession()
> > > > -       {
> > > > -               HttpSession httpSession = Mockito.mock(HttpSession.
> > > class);
> > > > -               MockHttpServletRequest request = new
> > > > MockHttpServletRequest(null, httpSession, null);
> > > > -               assertNull("MockHttpServletRequest knows how to work
> > > only
> > > > with MockHttpSession", request.getSession(true));
> > > > -               assertNull("MockHttpServletRequest knows how to work
> > > only
> > > > with MockHttpSession", request.getSession(false));
> > > > -       }
> > > > -
> > > > -       @Test
> > > > -       public void getSessionFalseFromMockHttpSession()
> > > > -       {
> > > > -               HttpSession httpSession = new MockHttpSession(null);
> > > > -               MockHttpServletRequest request = new
> > > > MockHttpServletRequest(null, httpSession, null);
> > > > -               assertNull("HttpSession should not be created!",
> > > > request.getSession(false));
> > > > -       }
> > > > +//     @Test
> > > > +//     public void getSessionFromNonMockHttpSession()
> > > > +//     {
> > > > +//             HttpSession httpSession = Mockito.mock(HttpSession.
> > > class);
> > > > +//             MockHttpServletRequest request = new
> > > > MockHttpServletRequest(null, httpSession, null);
> > > > +//             assertTrue("MockHttpServletRequest knows how to work
> > > only
> > > > with MockHttpSession", request.getSession(true).);
> > > > +//             assertNull("MockHttpServletRequest knows how to work
> > > only
> > > > with MockHttpSession", request.getSession(false));
> > > > +//     }
> > > > +//
> > > > +//     @Test
> > > > +//     public void getSessionFalseFromMockHttpSession()
> > > > +//     {
> > > > +//             HttpSession httpSession = new MockHttpSession(null);
> > > > +//             MockHttpServletRequest request = new
> > > > MockHttpServletRequest(null, httpSession, null);
> > > > +//             assertNull("HttpSession should not be created!",
> > > > request.getSession(false));
> > > > +//     }
> > > >
> > > >         @Test
> > > >         public void getSessionDefaultFromMockHttpSession()
> > > >
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>

Re: [4/8] wicket git commit: Added missing java 9 module

Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks Andrea,

I have noticed that while looking through later commits
Should answer myself :(

Was curious what changes were required to create java9 compatible build :)

On Fri, May 18, 2018 at 5:13 PM, Andrea Del Bene <an...@gmail.com>
wrote:

> Hi,
>
> changes to MockHttpServletRequest and its test have been reverted in a
> later commit, so the final code doesn't contain the commented out code.
>
> On Fri, May 18, 2018 at 10:47 AM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Is this commented out code really necessary?
> > Or maybe it should be fixed?
> >
> > On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:
> >
> > > Added missing java 9 module
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/26557b35
> > > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
> > > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35
> > >
> > > Branch: refs/heads/wicket-9.x
> > > Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
> > > Parents: bfbdfe2
> > > Author: Andrea Del Bene <an...@gmail.com>
> > > Authored: Sun May 13 21:25:43 2018 +0200
> > > Committer: Andrea Del Bene <an...@gmail.com>
> > > Committed: Sun May 13 21:25:43 2018 +0200
> > >
> > > ----------------------------------------------------------------------
> > >  pom.xml                                         | 25 ++++++++++++++-
> > >  testing/wicket-arquillian/pom.xml               |  8 ++++-
> > >  wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
> > >  .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
> > >  .../http/mock/MockHttpServletRequest.java       |  8 +----
> > >  .../http/mock/MockHttpServletRequestTest.java   | 32
> > ++++++++++----------
> > >  6 files changed, 69 insertions(+), 28 deletions(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
> > > ----------------------------------------------------------------------
> > > diff --git a/pom.xml b/pom.xml
> > > index 8e3a754..fd8498c 100644
> > > --- a/pom.xml
> > > +++ b/pom.xml
> > > @@ -442,6 +442,28 @@
> > >                                 <version>2.4.2.SP1</version>
> > >                         </dependency>
> > >                         <dependency>
> > > +                           <groupId>org.jboss.weld</groupId>
> > > +                           <artifactId>weld-spi</artifactId>
> > > +                           <version>3.0.SP3</version>
> > > +                       </dependency>
> > > +                       <dependency>
> > > +                           <groupId>org.jboss.weld.module</groupId>
> > > +                           <artifactId>weld-web</artifactId>
> > > +                           <version>3.0.4.Final</version>
> > > +                       </dependency>
> > > +
> > > +                       <dependency>
> > > +                           <groupId>org.jboss.weld</groupId>
> > > +                           <artifactId>weld-core</artifactId>
> > > +                           <version>2.4.7.Final</version>
> > > +                       </dependency>
> > > +                       <dependency>
> > > +                           <groupId>org.jboss.weld.se</groupId>
> > > +                           <artifactId>weld-se</artifactId>
> > > +                           <version>2.4.7.Final</version>
> > > +                           <scope>test</scope>
> > > +                       </dependency>
> > > +                       <dependency>
> > >                                 <groupId>org.objenesis</groupId>
> > >                                 <artifactId>objenesis</artifactId>
> > >                                 <version>${objenesis.version}<
> /version>
> > > @@ -544,7 +566,7 @@
> > >                         <dependency>
> > >                                 <groupId>org.jglue.cdi-unit</groupId>
> > >                                 <artifactId>cdi-unit</artifactId>
> > > -                               <version>2.2.1</version>
> > > +                               <version>4.0.2</version>
> > >                                 <scope>test</scope>
> > >                         </dependency>
> > >                         <dependency>
> > > @@ -959,6 +981,7 @@
> > >                                                 <includes>
> > >
> > > <include>**/*Test.java</include>
> > >                                                 </includes>
> > > +                                               <argLine>--add-opens
> > > java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
> > >                                         </configuration>
> > >                                         <dependencies>
> > >                                                 <dependency>
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > 26557b35/testing/wicket-arquillian/pom.xml
> > > ----------------------------------------------------------------------
> > > diff --git a/testing/wicket-arquillian/pom.xml
> > > b/testing/wicket-arquillian/pom.xml
> > > index f82ed07..954dd62 100644
> > > --- a/testing/wicket-arquillian/pom.xml
> > > +++ b/testing/wicket-arquillian/pom.xml
> > > @@ -42,7 +42,7 @@
> > >                 <wicket.arquillian.management.
> > > port>11091</wicket.arquillian.management.port>
> > >                 <!-- end port configuration -->
> > >
> > > -               <arquillian.version>1.1.13.Final</arquillian.version>
> > > +               <arquillian.version>1.4.0.Final</arquillian.version>
> > >                 <maven.dependency.plugin.version>2.10</maven.
> > > dependency.plugin.version>
> > >                 <project.build.sourceEncoding>UTF-8</project.build.
> > > sourceEncoding>
> > >                 <wildfly.version>8.2.1.Final</wildfly.version>
> > > @@ -84,6 +84,12 @@
> > >                         <groupId>org.wildfly</groupId>
> > >                         <artifactId>wildfly-embedded</artifactId>
> > >                         <version>${wildfly.version}</version>
> > > +                       <exclusions>
> > > +            <exclusion>
> > > +                <groupId>sun.jdk</groupId>
> > > +                <artifactId>jconsole</artifactId>
> > > +            </exclusion>
> > > +        </exclusions>
> > >                 </dependency>
> > >                 <dependency>
> > >                         <groupId>org.jboss.arquillian.junit</groupId>
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > 26557b35/wicket-cdi-1.1/pom.xml
> > > ----------------------------------------------------------------------
> > > diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> > > index 957ff0e..9bfa684 100644
> > > --- a/wicket-cdi-1.1/pom.xml
> > > +++ b/wicket-cdi-1.1/pom.xml
> > > @@ -60,5 +60,22 @@
> > >                         <groupId>org.jglue.cdi-unit</groupId>
> > >                         <artifactId>cdi-unit</artifactId>
> > >                 </dependency>
> > > +               <dependency>
> > > +                   <groupId>org.jboss.weld</groupId>
> > > +                   <artifactId>weld-spi</artifactId>
> > > +               </dependency>
> > > +               <dependency>
> > > +                   <groupId>org.jboss.weld</groupId>
> > > +                   <artifactId>weld-core</artifactId>
> > > +               </dependency>
> > > +               <dependency>
> > > +                   <groupId>org.jboss.weld.se</groupId>
> > > +                   <artifactId>weld-se</artifactId>
> > > +                   <scope>test</scope>
> > > +               </dependency>
> > > +               <dependency>
> > > +                       <groupId>org.jboss.weld.module</groupId>
> > > +                       <artifactId>weld-web</artifactId>
> > > +               </dependency>
> > >         </dependencies>
> > >  </project>
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > 26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/
> > > cdi/ContextManager.java
> > > ----------------------------------------------------------------------
> > > diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > ContextManager.java
> > > b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> ContextManager.java
> > > index 3e22aef..ee92367 100644
> > > --- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > > ContextManager.java
> > > +++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > > ContextManager.java
> > > @@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
> > >  import org.jboss.weld.bean.builtin.BeanManagerProxy;
> > >  import org.jboss.weld.servlet.HttpContextLifecycle;
> > >  import org.jboss.weld.servlet.spi.helpers.
> > AcceptingHttpContextActivation
> > > Filter;
> > > -import org.jglue.cdiunit.internal.LifecycleAwareRequest;
> > > +import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
> > > +import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
> > >
> > >  /**
> > >   * @author jsarman
> > > @@ -49,7 +50,7 @@ public class ContextManager
> > >                 try
> > >                 {
> > >                         lifecycle = new HttpContextLifecycle(
> > > BeanManagerProxy.unwrap(beanManager),
> > > -                                       AcceptingHttpContextActivation
> > Filter.INSTANCE,
> > > true, true);
> > > +                                       AcceptingHttpContextActivation
> > Filter.INSTANCE,
> > > true, true, false, true);
> > >                 }
> > >                 catch (NoSuchMethodError e)
> > >                 {
> > > @@ -73,7 +74,7 @@ public class ContextManager
> > >                 if (currentRequest != null)
> > >                         return;
> > >
> > > -               currentRequest = new LifecycleAwareRequest(lifecycle,
> > > request, currentSession);
> > > +               currentRequest = new LifecycleAwareRequest(new
> > > CdiUnitInitialListenerImpl(), request);
> > >                 lifecycle.requestInitialized(currentRequest, null);
> > >         }
> > >
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > 26557b35/wicket-core/src/main/java/org/apache/wicket/
> protocol/http/mock/
> > > MockHttpServletRequest.java
> > > ----------------------------------------------------------------------
> > > diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/
> > > http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/
> > > org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
> > > index 44ee8d4..10c878d 100755
> > > --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> > > MockHttpServletRequest.java
> > > +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> > > MockHttpServletRequest.java
> > > @@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements
> > > HttpServletRequest
> > >         @Override
> > >         public HttpSession getSession(boolean b)
> > >         {
> > > -               HttpSession sess = null;
> > >                 if (session instanceof MockHttpSession)
> > >                 {
> > >                         MockHttpSession mockHttpSession =
> > > (MockHttpSession)session;
> > > @@ -1188,13 +1187,8 @@ public class MockHttpServletRequest implements
> > > HttpServletRequest
> > >                         {
> > >                                 mockHttpSession.setTemporary(false);
> > >                         }
> > > -
> > > -                       if (mockHttpSession.isTemporary() == false)
> > > -                       {
> > > -                               sess = session;
> > > -                       }
> > >                 }
> > > -               return sess;
> > > +               return session;
> > >         }
> > >
> > >         /**
> > >
> > > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > 26557b35/wicket-core/src/test/java/org/apache/wicket/
> protocol/http/mock/
> > > MockHttpServletRequestTest.java
> > > ----------------------------------------------------------------------
> > > diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/
> > > http/mock/MockHttpServletRequestTest.java b/wicket-core/src/test/java/
> > > org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
> > > index 99f956e..8f0802c 100755
> > > --- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> > > MockHttpServletRequestTest.java
> > > +++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> > > MockHttpServletRequestTest.java
> > > @@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends
> > > WicketTestCase
> > >          assertNull(url.getQueryString());
> > >      }
> > >
> > > -       @Test
> > > -       public void getSessionFromNonMockHttpSession()
> > > -       {
> > > -               HttpSession httpSession = Mockito.mock(HttpSession.
> > class);
> > > -               MockHttpServletRequest request = new
> > > MockHttpServletRequest(null, httpSession, null);
> > > -               assertNull("MockHttpServletRequest knows how to work
> > only
> > > with MockHttpSession", request.getSession(true));
> > > -               assertNull("MockHttpServletRequest knows how to work
> > only
> > > with MockHttpSession", request.getSession(false));
> > > -       }
> > > -
> > > -       @Test
> > > -       public void getSessionFalseFromMockHttpSession()
> > > -       {
> > > -               HttpSession httpSession = new MockHttpSession(null);
> > > -               MockHttpServletRequest request = new
> > > MockHttpServletRequest(null, httpSession, null);
> > > -               assertNull("HttpSession should not be created!",
> > > request.getSession(false));
> > > -       }
> > > +//     @Test
> > > +//     public void getSessionFromNonMockHttpSession()
> > > +//     {
> > > +//             HttpSession httpSession = Mockito.mock(HttpSession.
> > class);
> > > +//             MockHttpServletRequest request = new
> > > MockHttpServletRequest(null, httpSession, null);
> > > +//             assertTrue("MockHttpServletRequest knows how to work
> > only
> > > with MockHttpSession", request.getSession(true).);
> > > +//             assertNull("MockHttpServletRequest knows how to work
> > only
> > > with MockHttpSession", request.getSession(false));
> > > +//     }
> > > +//
> > > +//     @Test
> > > +//     public void getSessionFalseFromMockHttpSession()
> > > +//     {
> > > +//             HttpSession httpSession = new MockHttpSession(null);
> > > +//             MockHttpServletRequest request = new
> > > MockHttpServletRequest(null, httpSession, null);
> > > +//             assertNull("HttpSession should not be created!",
> > > request.getSession(false));
> > > +//     }
> > >
> > >         @Test
> > >         public void getSessionDefaultFromMockHttpSession()
> > >
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>



-- 
WBR
Maxim aka solomax

Re: [4/8] wicket git commit: Added missing java 9 module

Posted by Andrea Del Bene <an...@gmail.com>.
Hi,

changes to MockHttpServletRequest and its test have been reverted in a
later commit, so the final code doesn't contain the commented out code.

On Fri, May 18, 2018 at 10:47 AM, Maxim Solodovnik <so...@gmail.com>
wrote:

> Is this commented out code really necessary?
> Or maybe it should be fixed?
>
> On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:
>
> > Added missing java 9 module
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/26557b35
> > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
> > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35
> >
> > Branch: refs/heads/wicket-9.x
> > Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
> > Parents: bfbdfe2
> > Author: Andrea Del Bene <an...@gmail.com>
> > Authored: Sun May 13 21:25:43 2018 +0200
> > Committer: Andrea Del Bene <an...@gmail.com>
> > Committed: Sun May 13 21:25:43 2018 +0200
> >
> > ----------------------------------------------------------------------
> >  pom.xml                                         | 25 ++++++++++++++-
> >  testing/wicket-arquillian/pom.xml               |  8 ++++-
> >  wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
> >  .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
> >  .../http/mock/MockHttpServletRequest.java       |  8 +----
> >  .../http/mock/MockHttpServletRequestTest.java   | 32
> ++++++++++----------
> >  6 files changed, 69 insertions(+), 28 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index 8e3a754..fd8498c 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -442,6 +442,28 @@
> >                                 <version>2.4.2.SP1</version>
> >                         </dependency>
> >                         <dependency>
> > +                           <groupId>org.jboss.weld</groupId>
> > +                           <artifactId>weld-spi</artifactId>
> > +                           <version>3.0.SP3</version>
> > +                       </dependency>
> > +                       <dependency>
> > +                           <groupId>org.jboss.weld.module</groupId>
> > +                           <artifactId>weld-web</artifactId>
> > +                           <version>3.0.4.Final</version>
> > +                       </dependency>
> > +
> > +                       <dependency>
> > +                           <groupId>org.jboss.weld</groupId>
> > +                           <artifactId>weld-core</artifactId>
> > +                           <version>2.4.7.Final</version>
> > +                       </dependency>
> > +                       <dependency>
> > +                           <groupId>org.jboss.weld.se</groupId>
> > +                           <artifactId>weld-se</artifactId>
> > +                           <version>2.4.7.Final</version>
> > +                           <scope>test</scope>
> > +                       </dependency>
> > +                       <dependency>
> >                                 <groupId>org.objenesis</groupId>
> >                                 <artifactId>objenesis</artifactId>
> >                                 <version>${objenesis.version}</version>
> > @@ -544,7 +566,7 @@
> >                         <dependency>
> >                                 <groupId>org.jglue.cdi-unit</groupId>
> >                                 <artifactId>cdi-unit</artifactId>
> > -                               <version>2.2.1</version>
> > +                               <version>4.0.2</version>
> >                                 <scope>test</scope>
> >                         </dependency>
> >                         <dependency>
> > @@ -959,6 +981,7 @@
> >                                                 <includes>
> >
> > <include>**/*Test.java</include>
> >                                                 </includes>
> > +                                               <argLine>--add-opens
> > java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
> >                                         </configuration>
> >                                         <dependencies>
> >                                                 <dependency>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > 26557b35/testing/wicket-arquillian/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/testing/wicket-arquillian/pom.xml
> > b/testing/wicket-arquillian/pom.xml
> > index f82ed07..954dd62 100644
> > --- a/testing/wicket-arquillian/pom.xml
> > +++ b/testing/wicket-arquillian/pom.xml
> > @@ -42,7 +42,7 @@
> >                 <wicket.arquillian.management.
> > port>11091</wicket.arquillian.management.port>
> >                 <!-- end port configuration -->
> >
> > -               <arquillian.version>1.1.13.Final</arquillian.version>
> > +               <arquillian.version>1.4.0.Final</arquillian.version>
> >                 <maven.dependency.plugin.version>2.10</maven.
> > dependency.plugin.version>
> >                 <project.build.sourceEncoding>UTF-8</project.build.
> > sourceEncoding>
> >                 <wildfly.version>8.2.1.Final</wildfly.version>
> > @@ -84,6 +84,12 @@
> >                         <groupId>org.wildfly</groupId>
> >                         <artifactId>wildfly-embedded</artifactId>
> >                         <version>${wildfly.version}</version>
> > +                       <exclusions>
> > +            <exclusion>
> > +                <groupId>sun.jdk</groupId>
> > +                <artifactId>jconsole</artifactId>
> > +            </exclusion>
> > +        </exclusions>
> >                 </dependency>
> >                 <dependency>
> >                         <groupId>org.jboss.arquillian.junit</groupId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > 26557b35/wicket-cdi-1.1/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> > index 957ff0e..9bfa684 100644
> > --- a/wicket-cdi-1.1/pom.xml
> > +++ b/wicket-cdi-1.1/pom.xml
> > @@ -60,5 +60,22 @@
> >                         <groupId>org.jglue.cdi-unit</groupId>
> >                         <artifactId>cdi-unit</artifactId>
> >                 </dependency>
> > +               <dependency>
> > +                   <groupId>org.jboss.weld</groupId>
> > +                   <artifactId>weld-spi</artifactId>
> > +               </dependency>
> > +               <dependency>
> > +                   <groupId>org.jboss.weld</groupId>
> > +                   <artifactId>weld-core</artifactId>
> > +               </dependency>
> > +               <dependency>
> > +                   <groupId>org.jboss.weld.se</groupId>
> > +                   <artifactId>weld-se</artifactId>
> > +                   <scope>test</scope>
> > +               </dependency>
> > +               <dependency>
> > +                       <groupId>org.jboss.weld.module</groupId>
> > +                       <artifactId>weld-web</artifactId>
> > +               </dependency>
> >         </dependencies>
> >  </project>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > 26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/
> > cdi/ContextManager.java
> > ----------------------------------------------------------------------
> > diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> ContextManager.java
> > b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
> > index 3e22aef..ee92367 100644
> > --- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > ContextManager.java
> > +++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> > ContextManager.java
> > @@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
> >  import org.jboss.weld.bean.builtin.BeanManagerProxy;
> >  import org.jboss.weld.servlet.HttpContextLifecycle;
> >  import org.jboss.weld.servlet.spi.helpers.
> AcceptingHttpContextActivation
> > Filter;
> > -import org.jglue.cdiunit.internal.LifecycleAwareRequest;
> > +import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
> > +import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
> >
> >  /**
> >   * @author jsarman
> > @@ -49,7 +50,7 @@ public class ContextManager
> >                 try
> >                 {
> >                         lifecycle = new HttpContextLifecycle(
> > BeanManagerProxy.unwrap(beanManager),
> > -                                       AcceptingHttpContextActivation
> Filter.INSTANCE,
> > true, true);
> > +                                       AcceptingHttpContextActivation
> Filter.INSTANCE,
> > true, true, false, true);
> >                 }
> >                 catch (NoSuchMethodError e)
> >                 {
> > @@ -73,7 +74,7 @@ public class ContextManager
> >                 if (currentRequest != null)
> >                         return;
> >
> > -               currentRequest = new LifecycleAwareRequest(lifecycle,
> > request, currentSession);
> > +               currentRequest = new LifecycleAwareRequest(new
> > CdiUnitInitialListenerImpl(), request);
> >                 lifecycle.requestInitialized(currentRequest, null);
> >         }
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > 26557b35/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequest.java
> > ----------------------------------------------------------------------
> > diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/
> > http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/
> > org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
> > index 44ee8d4..10c878d 100755
> > --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequest.java
> > +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequest.java
> > @@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements
> > HttpServletRequest
> >         @Override
> >         public HttpSession getSession(boolean b)
> >         {
> > -               HttpSession sess = null;
> >                 if (session instanceof MockHttpSession)
> >                 {
> >                         MockHttpSession mockHttpSession =
> > (MockHttpSession)session;
> > @@ -1188,13 +1187,8 @@ public class MockHttpServletRequest implements
> > HttpServletRequest
> >                         {
> >                                 mockHttpSession.setTemporary(false);
> >                         }
> > -
> > -                       if (mockHttpSession.isTemporary() == false)
> > -                       {
> > -                               sess = session;
> > -                       }
> >                 }
> > -               return sess;
> > +               return session;
> >         }
> >
> >         /**
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > 26557b35/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequestTest.java
> > ----------------------------------------------------------------------
> > diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/
> > http/mock/MockHttpServletRequestTest.java b/wicket-core/src/test/java/
> > org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
> > index 99f956e..8f0802c 100755
> > --- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequestTest.java
> > +++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> > MockHttpServletRequestTest.java
> > @@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends
> > WicketTestCase
> >          assertNull(url.getQueryString());
> >      }
> >
> > -       @Test
> > -       public void getSessionFromNonMockHttpSession()
> > -       {
> > -               HttpSession httpSession = Mockito.mock(HttpSession.
> class);
> > -               MockHttpServletRequest request = new
> > MockHttpServletRequest(null, httpSession, null);
> > -               assertNull("MockHttpServletRequest knows how to work
> only
> > with MockHttpSession", request.getSession(true));
> > -               assertNull("MockHttpServletRequest knows how to work
> only
> > with MockHttpSession", request.getSession(false));
> > -       }
> > -
> > -       @Test
> > -       public void getSessionFalseFromMockHttpSession()
> > -       {
> > -               HttpSession httpSession = new MockHttpSession(null);
> > -               MockHttpServletRequest request = new
> > MockHttpServletRequest(null, httpSession, null);
> > -               assertNull("HttpSession should not be created!",
> > request.getSession(false));
> > -       }
> > +//     @Test
> > +//     public void getSessionFromNonMockHttpSession()
> > +//     {
> > +//             HttpSession httpSession = Mockito.mock(HttpSession.
> class);
> > +//             MockHttpServletRequest request = new
> > MockHttpServletRequest(null, httpSession, null);
> > +//             assertTrue("MockHttpServletRequest knows how to work
> only
> > with MockHttpSession", request.getSession(true).);
> > +//             assertNull("MockHttpServletRequest knows how to work
> only
> > with MockHttpSession", request.getSession(false));
> > +//     }
> > +//
> > +//     @Test
> > +//     public void getSessionFalseFromMockHttpSession()
> > +//     {
> > +//             HttpSession httpSession = new MockHttpSession(null);
> > +//             MockHttpServletRequest request = new
> > MockHttpServletRequest(null, httpSession, null);
> > +//             assertNull("HttpSession should not be created!",
> > request.getSession(false));
> > +//     }
> >
> >         @Test
> >         public void getSessionDefaultFromMockHttpSession()
> >
> >
>
>
> --
> WBR
> Maxim aka solomax
>

Re: [4/8] wicket git commit: Added missing java 9 module

Posted by Maxim Solodovnik <so...@gmail.com>.
Is this commented out code really necessary?
Or maybe it should be fixed?

On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:

> Added missing java 9 module
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/26557b35
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35
>
> Branch: refs/heads/wicket-9.x
> Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
> Parents: bfbdfe2
> Author: Andrea Del Bene <an...@gmail.com>
> Authored: Sun May 13 21:25:43 2018 +0200
> Committer: Andrea Del Bene <an...@gmail.com>
> Committed: Sun May 13 21:25:43 2018 +0200
>
> ----------------------------------------------------------------------
>  pom.xml                                         | 25 ++++++++++++++-
>  testing/wicket-arquillian/pom.xml               |  8 ++++-
>  wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
>  .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
>  .../http/mock/MockHttpServletRequest.java       |  8 +----
>  .../http/mock/MockHttpServletRequestTest.java   | 32 ++++++++++----------
>  6 files changed, 69 insertions(+), 28 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 8e3a754..fd8498c 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -442,6 +442,28 @@
>                                 <version>2.4.2.SP1</version>
>                         </dependency>
>                         <dependency>
> +                           <groupId>org.jboss.weld</groupId>
> +                           <artifactId>weld-spi</artifactId>
> +                           <version>3.0.SP3</version>
> +                       </dependency>
> +                       <dependency>
> +                           <groupId>org.jboss.weld.module</groupId>
> +                           <artifactId>weld-web</artifactId>
> +                           <version>3.0.4.Final</version>
> +                       </dependency>
> +
> +                       <dependency>
> +                           <groupId>org.jboss.weld</groupId>
> +                           <artifactId>weld-core</artifactId>
> +                           <version>2.4.7.Final</version>
> +                       </dependency>
> +                       <dependency>
> +                           <groupId>org.jboss.weld.se</groupId>
> +                           <artifactId>weld-se</artifactId>
> +                           <version>2.4.7.Final</version>
> +                           <scope>test</scope>
> +                       </dependency>
> +                       <dependency>
>                                 <groupId>org.objenesis</groupId>
>                                 <artifactId>objenesis</artifactId>
>                                 <version>${objenesis.version}</version>
> @@ -544,7 +566,7 @@
>                         <dependency>
>                                 <groupId>org.jglue.cdi-unit</groupId>
>                                 <artifactId>cdi-unit</artifactId>
> -                               <version>2.2.1</version>
> +                               <version>4.0.2</version>
>                                 <scope>test</scope>
>                         </dependency>
>                         <dependency>
> @@ -959,6 +981,7 @@
>                                                 <includes>
>
> <include>**/*Test.java</include>
>                                                 </includes>
> +                                               <argLine>--add-opens
> java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
>                                         </configuration>
>                                         <dependencies>
>                                                 <dependency>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 26557b35/testing/wicket-arquillian/pom.xml
> ----------------------------------------------------------------------
> diff --git a/testing/wicket-arquillian/pom.xml
> b/testing/wicket-arquillian/pom.xml
> index f82ed07..954dd62 100644
> --- a/testing/wicket-arquillian/pom.xml
> +++ b/testing/wicket-arquillian/pom.xml
> @@ -42,7 +42,7 @@
>                 <wicket.arquillian.management.
> port>11091</wicket.arquillian.management.port>
>                 <!-- end port configuration -->
>
> -               <arquillian.version>1.1.13.Final</arquillian.version>
> +               <arquillian.version>1.4.0.Final</arquillian.version>
>                 <maven.dependency.plugin.version>2.10</maven.
> dependency.plugin.version>
>                 <project.build.sourceEncoding>UTF-8</project.build.
> sourceEncoding>
>                 <wildfly.version>8.2.1.Final</wildfly.version>
> @@ -84,6 +84,12 @@
>                         <groupId>org.wildfly</groupId>
>                         <artifactId>wildfly-embedded</artifactId>
>                         <version>${wildfly.version}</version>
> +                       <exclusions>
> +            <exclusion>
> +                <groupId>sun.jdk</groupId>
> +                <artifactId>jconsole</artifactId>
> +            </exclusion>
> +        </exclusions>
>                 </dependency>
>                 <dependency>
>                         <groupId>org.jboss.arquillian.junit</groupId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 26557b35/wicket-cdi-1.1/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> index 957ff0e..9bfa684 100644
> --- a/wicket-cdi-1.1/pom.xml
> +++ b/wicket-cdi-1.1/pom.xml
> @@ -60,5 +60,22 @@
>                         <groupId>org.jglue.cdi-unit</groupId>
>                         <artifactId>cdi-unit</artifactId>
>                 </dependency>
> +               <dependency>
> +                   <groupId>org.jboss.weld</groupId>
> +                   <artifactId>weld-spi</artifactId>
> +               </dependency>
> +               <dependency>
> +                   <groupId>org.jboss.weld</groupId>
> +                   <artifactId>weld-core</artifactId>
> +               </dependency>
> +               <dependency>
> +                   <groupId>org.jboss.weld.se</groupId>
> +                   <artifactId>weld-se</artifactId>
> +                   <scope>test</scope>
> +               </dependency>
> +               <dependency>
> +                       <groupId>org.jboss.weld.module</groupId>
> +                       <artifactId>weld-web</artifactId>
> +               </dependency>
>         </dependencies>
>  </project>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/
> cdi/ContextManager.java
> ----------------------------------------------------------------------
> diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
> b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
> index 3e22aef..ee92367 100644
> --- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> ContextManager.java
> +++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/
> ContextManager.java
> @@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
>  import org.jboss.weld.bean.builtin.BeanManagerProxy;
>  import org.jboss.weld.servlet.HttpContextLifecycle;
>  import org.jboss.weld.servlet.spi.helpers.AcceptingHttpContextActivation
> Filter;
> -import org.jglue.cdiunit.internal.LifecycleAwareRequest;
> +import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
> +import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
>
>  /**
>   * @author jsarman
> @@ -49,7 +50,7 @@ public class ContextManager
>                 try
>                 {
>                         lifecycle = new HttpContextLifecycle(
> BeanManagerProxy.unwrap(beanManager),
> -                                       AcceptingHttpContextActivationFilter.INSTANCE,
> true, true);
> +                                       AcceptingHttpContextActivationFilter.INSTANCE,
> true, true, false, true);
>                 }
>                 catch (NoSuchMethodError e)
>                 {
> @@ -73,7 +74,7 @@ public class ContextManager
>                 if (currentRequest != null)
>                         return;
>
> -               currentRequest = new LifecycleAwareRequest(lifecycle,
> request, currentSession);
> +               currentRequest = new LifecycleAwareRequest(new
> CdiUnitInitialListenerImpl(), request);
>                 lifecycle.requestInitialized(currentRequest, null);
>         }
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 26557b35/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequest.java
> ----------------------------------------------------------------------
> diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/
> http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/
> org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
> index 44ee8d4..10c878d 100755
> --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequest.java
> +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequest.java
> @@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements
> HttpServletRequest
>         @Override
>         public HttpSession getSession(boolean b)
>         {
> -               HttpSession sess = null;
>                 if (session instanceof MockHttpSession)
>                 {
>                         MockHttpSession mockHttpSession =
> (MockHttpSession)session;
> @@ -1188,13 +1187,8 @@ public class MockHttpServletRequest implements
> HttpServletRequest
>                         {
>                                 mockHttpSession.setTemporary(false);
>                         }
> -
> -                       if (mockHttpSession.isTemporary() == false)
> -                       {
> -                               sess = session;
> -                       }
>                 }
> -               return sess;
> +               return session;
>         }
>
>         /**
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 26557b35/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequestTest.java
> ----------------------------------------------------------------------
> diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/
> http/mock/MockHttpServletRequestTest.java b/wicket-core/src/test/java/
> org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
> index 99f956e..8f0802c 100755
> --- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequestTest.java
> +++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/
> MockHttpServletRequestTest.java
> @@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends
> WicketTestCase
>          assertNull(url.getQueryString());
>      }
>
> -       @Test
> -       public void getSessionFromNonMockHttpSession()
> -       {
> -               HttpSession httpSession = Mockito.mock(HttpSession.class);
> -               MockHttpServletRequest request = new
> MockHttpServletRequest(null, httpSession, null);
> -               assertNull("MockHttpServletRequest knows how to work only
> with MockHttpSession", request.getSession(true));
> -               assertNull("MockHttpServletRequest knows how to work only
> with MockHttpSession", request.getSession(false));
> -       }
> -
> -       @Test
> -       public void getSessionFalseFromMockHttpSession()
> -       {
> -               HttpSession httpSession = new MockHttpSession(null);
> -               MockHttpServletRequest request = new
> MockHttpServletRequest(null, httpSession, null);
> -               assertNull("HttpSession should not be created!",
> request.getSession(false));
> -       }
> +//     @Test
> +//     public void getSessionFromNonMockHttpSession()
> +//     {
> +//             HttpSession httpSession = Mockito.mock(HttpSession.class);
> +//             MockHttpServletRequest request = new
> MockHttpServletRequest(null, httpSession, null);
> +//             assertTrue("MockHttpServletRequest knows how to work only
> with MockHttpSession", request.getSession(true).);
> +//             assertNull("MockHttpServletRequest knows how to work only
> with MockHttpSession", request.getSession(false));
> +//     }
> +//
> +//     @Test
> +//     public void getSessionFalseFromMockHttpSession()
> +//     {
> +//             HttpSession httpSession = new MockHttpSession(null);
> +//             MockHttpServletRequest request = new
> MockHttpServletRequest(null, httpSession, null);
> +//             assertNull("HttpSession should not be created!",
> request.getSession(false));
> +//     }
>
>         @Test
>         public void getSessionDefaultFromMockHttpSession()
>
>


-- 
WBR
Maxim aka solomax

[4/8] wicket git commit: Added missing java 9 module

Posted by ad...@apache.org.
Added missing java 9 module


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/26557b35
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/26557b35
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/26557b35

Branch: refs/heads/wicket-9.x
Commit: 26557b352a31d9d0503065e18a3b48489fd066f1
Parents: bfbdfe2
Author: Andrea Del Bene <an...@gmail.com>
Authored: Sun May 13 21:25:43 2018 +0200
Committer: Andrea Del Bene <an...@gmail.com>
Committed: Sun May 13 21:25:43 2018 +0200

----------------------------------------------------------------------
 pom.xml                                         | 25 ++++++++++++++-
 testing/wicket-arquillian/pom.xml               |  8 ++++-
 wicket-cdi-1.1/pom.xml                          | 17 +++++++++++
 .../org/apache/wicket/cdi/ContextManager.java   |  7 +++--
 .../http/mock/MockHttpServletRequest.java       |  8 +----
 .../http/mock/MockHttpServletRequestTest.java   | 32 ++++++++++----------
 6 files changed, 69 insertions(+), 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 8e3a754..fd8498c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -442,6 +442,28 @@
 				<version>2.4.2.SP1</version>
 			</dependency>
 			<dependency>
+			    <groupId>org.jboss.weld</groupId>
+			    <artifactId>weld-spi</artifactId>
+			    <version>3.0.SP3</version>
+			</dependency>
+			<dependency>
+			    <groupId>org.jboss.weld.module</groupId>
+			    <artifactId>weld-web</artifactId>
+			    <version>3.0.4.Final</version>
+			</dependency>
+
+			<dependency>
+			    <groupId>org.jboss.weld</groupId>
+			    <artifactId>weld-core</artifactId>
+			    <version>2.4.7.Final</version>
+			</dependency>
+			<dependency>
+			    <groupId>org.jboss.weld.se</groupId>
+			    <artifactId>weld-se</artifactId>
+			    <version>2.4.7.Final</version>
+			    <scope>test</scope>
+			</dependency>
+			<dependency>
 				<groupId>org.objenesis</groupId>
 				<artifactId>objenesis</artifactId>
 				<version>${objenesis.version}</version>
@@ -544,7 +566,7 @@
 			<dependency>
 				<groupId>org.jglue.cdi-unit</groupId>
 				<artifactId>cdi-unit</artifactId>
-				<version>2.2.1</version>
+				<version>4.0.2</version>
 				<scope>test</scope>
 			</dependency>
 			<dependency>
@@ -959,6 +981,7 @@
 						<includes>
 							<include>**/*Test.java</include>
 						</includes>
+						<argLine>--add-opens java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
 					</configuration>
 					<dependencies>
 						<dependency>

http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/testing/wicket-arquillian/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-arquillian/pom.xml b/testing/wicket-arquillian/pom.xml
index f82ed07..954dd62 100644
--- a/testing/wicket-arquillian/pom.xml
+++ b/testing/wicket-arquillian/pom.xml
@@ -42,7 +42,7 @@
 		<wicket.arquillian.management.port>11091</wicket.arquillian.management.port>
 		<!-- end port configuration -->
 
-		<arquillian.version>1.1.13.Final</arquillian.version>
+		<arquillian.version>1.4.0.Final</arquillian.version>
 		<maven.dependency.plugin.version>2.10</maven.dependency.plugin.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<wildfly.version>8.2.1.Final</wildfly.version>
@@ -84,6 +84,12 @@
 			<groupId>org.wildfly</groupId>
 			<artifactId>wildfly-embedded</artifactId>
 			<version>${wildfly.version}</version>
+			<exclusions>
+            <exclusion>
+                <groupId>sun.jdk</groupId>
+                <artifactId>jconsole</artifactId>
+            </exclusion>
+        </exclusions>
 		</dependency>
 		<dependency>
 			<groupId>org.jboss.arquillian.junit</groupId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/wicket-cdi-1.1/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
index 957ff0e..9bfa684 100644
--- a/wicket-cdi-1.1/pom.xml
+++ b/wicket-cdi-1.1/pom.xml
@@ -60,5 +60,22 @@
 			<groupId>org.jglue.cdi-unit</groupId>
 			<artifactId>cdi-unit</artifactId>
 		</dependency>
+		<dependency>
+		    <groupId>org.jboss.weld</groupId>
+		    <artifactId>weld-spi</artifactId>
+		</dependency>
+		<dependency>
+		    <groupId>org.jboss.weld</groupId>
+		    <artifactId>weld-core</artifactId>
+		</dependency>
+		<dependency>
+		    <groupId>org.jboss.weld.se</groupId>
+		    <artifactId>weld-se</artifactId>
+		    <scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.jboss.weld.module</groupId>
+			<artifactId>weld-web</artifactId>
+		</dependency>
 	</dependencies>
 </project>

http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
index 3e22aef..ee92367 100644
--- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
+++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/ContextManager.java
@@ -26,7 +26,8 @@ import javax.servlet.http.HttpSession;
 import org.jboss.weld.bean.builtin.BeanManagerProxy;
 import org.jboss.weld.servlet.HttpContextLifecycle;
 import org.jboss.weld.servlet.spi.helpers.AcceptingHttpContextActivationFilter;
-import org.jglue.cdiunit.internal.LifecycleAwareRequest;
+import org.jglue.cdiunit.internal.CdiUnitInitialListenerImpl;
+import org.jglue.cdiunit.internal.servlet.LifecycleAwareRequest;
 
 /**
  * @author jsarman
@@ -49,7 +50,7 @@ public class ContextManager
 		try
 		{
 			lifecycle = new HttpContextLifecycle(BeanManagerProxy.unwrap(beanManager),
-					AcceptingHttpContextActivationFilter.INSTANCE, true, true);
+					AcceptingHttpContextActivationFilter.INSTANCE, true, true, false, true);
 		}
 		catch (NoSuchMethodError e)
 		{
@@ -73,7 +74,7 @@ public class ContextManager
 		if (currentRequest != null)
 			return;
 
-		currentRequest = new LifecycleAwareRequest(lifecycle, request, currentSession);
+		currentRequest = new LifecycleAwareRequest(new CdiUnitInitialListenerImpl(), request);
 		lifecycle.requestInitialized(currentRequest, null);
 	}
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 44ee8d4..10c878d 100755
--- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1180,7 +1180,6 @@ public class MockHttpServletRequest implements HttpServletRequest
 	@Override
 	public HttpSession getSession(boolean b)
 	{
-		HttpSession sess = null;
 		if (session instanceof MockHttpSession)
 		{
 			MockHttpSession mockHttpSession = (MockHttpSession)session;
@@ -1188,13 +1187,8 @@ public class MockHttpServletRequest implements HttpServletRequest
 			{
 				mockHttpSession.setTemporary(false);
 			}
-
-			if (mockHttpSession.isTemporary() == false)
-			{
-				sess = session;
-			}
 		}
-		return sess;
+		return session;
 	}
 
 	/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/26557b35/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
index 99f956e..8f0802c 100755
--- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
@@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends WicketTestCase
         assertNull(url.getQueryString());
     }
 	
-	@Test
-	public void getSessionFromNonMockHttpSession()
-	{
-		HttpSession httpSession = Mockito.mock(HttpSession.class);
-		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
-		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(true));
-		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(false));
-	}
-
-	@Test
-	public void getSessionFalseFromMockHttpSession()
-	{
-		HttpSession httpSession = new MockHttpSession(null);
-		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
-		assertNull("HttpSession should not be created!", request.getSession(false));
-	}
+//	@Test
+//	public void getSessionFromNonMockHttpSession()
+//	{
+//		HttpSession httpSession = Mockito.mock(HttpSession.class);
+//		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
+//		assertTrue("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(true).);
+//		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(false));
+//	}
+//
+//	@Test
+//	public void getSessionFalseFromMockHttpSession()
+//	{
+//		HttpSession httpSession = new MockHttpSession(null);
+//		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
+//		assertNull("HttpSession should not be created!", request.getSession(false));
+//	}
 
 	@Test
 	public void getSessionDefaultFromMockHttpSession()


[6/8] wicket git commit: Revert changes to MockHttpServletRequest

Posted by ad...@apache.org.
Revert changes to MockHttpServletRequest

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c07b0953
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c07b0953
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c07b0953

Branch: refs/heads/wicket-9.x
Commit: c07b09533488f6fc1fc517dfdeb0d78fbeeacf2d
Parents: 89720d5
Author: Andrea Del Bene <an...@edenviaggi.it>
Authored: Mon May 14 12:12:09 2018 +0200
Committer: Andrea Del Bene <an...@edenviaggi.it>
Committed: Mon May 14 12:12:09 2018 +0200

----------------------------------------------------------------------
 .../org/apache/wicket/cdi/CdiWicketTester.java  |  1 +
 .../http/mock/MockHttpServletRequest.java       | 14 ++++++---
 .../http/mock/MockHttpServletRequestTest.java   | 32 ++++++++++----------
 3 files changed, 27 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/c07b0953/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/CdiWicketTester.java
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/CdiWicketTester.java b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/CdiWicketTester.java
index 35bec1b..275a9bc 100644
--- a/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/CdiWicketTester.java
+++ b/wicket-cdi-1.1/src/test/java/org/apache/wicket/cdi/CdiWicketTester.java
@@ -49,6 +49,7 @@ public class CdiWicketTester extends WicketTester
 	{
 		super(app);
 		NonContextual.of(CdiWicketTester.class).inject(this);
+		getHttpSession().setTemporary(false);
 	}
 
 	/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/c07b0953/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 10c878d..a9396ba 100755
--- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1173,22 +1173,28 @@ public class MockHttpServletRequest implements HttpServletRequest
 	/**
 	 * Get the session.
 	 * 
-	 * @param b
+	 * @param createNew
 	 *            Ignored, there is always a session
 	 * @return The session
 	 */
 	@Override
-	public HttpSession getSession(boolean b)
+	public HttpSession getSession(boolean createNew)
 	{
+		HttpSession sess = null;
 		if (session instanceof MockHttpSession)
 		{
 			MockHttpSession mockHttpSession = (MockHttpSession)session;
-			if (b)
+			if (createNew)
 			{
 				mockHttpSession.setTemporary(false);
 			}
+
+			if (mockHttpSession.isTemporary() == false)
+			{
+				sess = session;
+			}
 		}
-		return session;
+		return sess;
 	}
 
 	/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/c07b0953/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
index 8f0802c..99f956e 100755
--- a/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequestTest.java
@@ -119,22 +119,22 @@ public class MockHttpServletRequestTest extends WicketTestCase
         assertNull(url.getQueryString());
     }
 	
-//	@Test
-//	public void getSessionFromNonMockHttpSession()
-//	{
-//		HttpSession httpSession = Mockito.mock(HttpSession.class);
-//		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
-//		assertTrue("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(true).);
-//		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(false));
-//	}
-//
-//	@Test
-//	public void getSessionFalseFromMockHttpSession()
-//	{
-//		HttpSession httpSession = new MockHttpSession(null);
-//		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
-//		assertNull("HttpSession should not be created!", request.getSession(false));
-//	}
+	@Test
+	public void getSessionFromNonMockHttpSession()
+	{
+		HttpSession httpSession = Mockito.mock(HttpSession.class);
+		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
+		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(true));
+		assertNull("MockHttpServletRequest knows how to work only with MockHttpSession", request.getSession(false));
+	}
+
+	@Test
+	public void getSessionFalseFromMockHttpSession()
+	{
+		HttpSession httpSession = new MockHttpSession(null);
+		MockHttpServletRequest request = new MockHttpServletRequest(null, httpSession, null);
+		assertNull("HttpSession should not be created!", request.getSession(false));
+	}
 
 	@Test
 	public void getSessionDefaultFromMockHttpSession()


[5/8] wicket git commit: Fixed problems with arquillian

Posted by ad...@apache.org.
Fixed problems with arquillian


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/89720d5b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/89720d5b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/89720d5b

Branch: refs/heads/wicket-9.x
Commit: 89720d5b4f4a8782e8c2dc5ea60db6db0aa44119
Parents: 26557b3
Author: Andrea Del Bene <an...@gmail.com>
Authored: Sun May 13 22:52:06 2018 +0200
Committer: Andrea Del Bene <an...@gmail.com>
Committed: Sun May 13 22:52:06 2018 +0200

----------------------------------------------------------------------
 pom.xml                           |  4 +--
 testing/wicket-arquillian/pom.xml | 51 ++++++++++++++++++++++++----------
 2 files changed, 38 insertions(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/89720d5b/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index fd8498c..253b757 100644
--- a/pom.xml
+++ b/pom.xml
@@ -132,7 +132,7 @@
 		<servlet-api.version>3.1.0</servlet-api.version>
 		<maven.javadoc.version>2.10.4</maven.javadoc.version>
 		<maven.surefire.version>2.20</maven.surefire.version>
-		<mockito.version>2.9.0</mockito.version>
+		<mockito.version>2.18.3</mockito.version>
 		<slf4j.version>1.7.25</slf4j.version>
 		<logback.version>1.2.3</logback.version>
 		<hamcrest.version>2.0.0.0</hamcrest.version>
@@ -981,7 +981,7 @@
 						<includes>
 							<include>**/*Test.java</include>
 						</includes>
-						<argLine>--add-opens java.base/jdk.internal.loader=ALL-UNNAMED</argLine>
+						<argLine>--add-opens java.base/jdk.internal.loader=ALL-UNNAMED --add-modules=ALL-SYSTEM</argLine>
 					</configuration>
 					<dependencies>
 						<dependency>

http://git-wip-us.apache.org/repos/asf/wicket/blob/89720d5b/testing/wicket-arquillian/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-arquillian/pom.xml b/testing/wicket-arquillian/pom.xml
index 954dd62..b3d5de0 100644
--- a/testing/wicket-arquillian/pom.xml
+++ b/testing/wicket-arquillian/pom.xml
@@ -15,7 +15,9 @@
    See the License for the specific language governing permissions and
    limitations under the License.
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
 	<modelVersion>4.0.0</modelVersion>
 
 	<parent>
@@ -45,7 +47,7 @@
 		<arquillian.version>1.4.0.Final</arquillian.version>
 		<maven.dependency.plugin.version>2.10</maven.dependency.plugin.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-		<wildfly.version>8.2.1.Final</wildfly.version>
+		<wildfly.version>11.0.0.Final</wildfly.version>
 		<version.wildfly.maven.plugin>1.0.2.Final</version.wildfly.maven.plugin>
 		<jee.spec.version>1.1.0.Final</jee.spec.version>
 	</properties>
@@ -77,21 +79,27 @@
 		</dependency>
 		<dependency>
 			<groupId>org.wildfly</groupId>
-			<artifactId>wildfly-arquillian-container-embedded</artifactId>
+			<artifactId>wildfly-weld</artifactId>
 			<version>${wildfly.version}</version>
+			<exclusions>
+				<exclusion>
+					<groupId>sun.jdk</groupId>
+					<artifactId>jconsole</artifactId>
+				</exclusion>
+			</exclusions>
 		</dependency>
 		<dependency>
-			<groupId>org.wildfly</groupId>
-			<artifactId>wildfly-embedded</artifactId>
-			<version>${wildfly.version}</version>
-			<exclusions>
-            <exclusion>
-                <groupId>sun.jdk</groupId>
-                <artifactId>jconsole</artifactId>
-            </exclusion>
-        </exclusions>
+			<groupId>org.wildfly.arquillian</groupId>
+			<artifactId>wildfly-arquillian-container-embedded</artifactId>
+			<version>2.1.0.Final</version>
+			<scope>test</scope>
 		</dependency>
 		<dependency>
+			<groupId>org.jboss.arquillian.protocol</groupId>
+			<artifactId>arquillian-protocol-servlet</artifactId>
+		</dependency>
+
+		<dependency>
 			<groupId>org.jboss.arquillian.junit</groupId>
 			<artifactId>arquillian-junit-container</artifactId>
 			<scope>test</scope>
@@ -107,7 +115,7 @@
 			<groupId>org.apache.wicket</groupId>
 			<artifactId>wicket-core</artifactId>
 		</dependency>
-		
+
 		<dependency>
 			<groupId>org.jboss.shrinkwrap.resolver</groupId>
 			<artifactId>shrinkwrap-resolver-impl-maven</artifactId>
@@ -117,11 +125,12 @@
 			<artifactId>shrinkwrap-resolver-spi</artifactId>
 		</dependency>
 
+
 	</dependencies>
 
 	<build>
 		<resources>
-			 <resource>
+			<resource>
 				<directory>src/main/resources</directory>
 				<filtering>true</filtering>
 			</resource>
@@ -198,6 +207,18 @@
 			</plugin>
 		</plugins>
 	</build>
-
+	<repositories>
+		<repository>
+			<id>Apache Nexus</id>
+			<url>http://repository.jboss.org/nexus/content/groups/public/</url>
+			<layout>default</layout>
+			<releases>
+				<enabled>true</enabled>
+			</releases>
+			<snapshots>
+				<enabled>true</enabled>
+			</snapshots>
+		</repository>
+	</repositories>
 </project>
 


[8/8] wicket git commit: removed unnecessary dependencies

Posted by ad...@apache.org.
removed unnecessary dependencies


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8c058e49
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8c058e49
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8c058e49

Branch: refs/heads/wicket-9.x
Commit: 8c058e49ffd78190cd1ce781360f6efc973b76ff
Parents: e5828ab
Author: Andrea Del Bene <an...@edenviaggi.it>
Authored: Tue May 15 18:36:38 2018 +0200
Committer: Andrea Del Bene <an...@edenviaggi.it>
Committed: Tue May 15 18:36:38 2018 +0200

----------------------------------------------------------------------
 testing/wicket-arquillian/pom.xml | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/8c058e49/testing/wicket-arquillian/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-arquillian/pom.xml b/testing/wicket-arquillian/pom.xml
index b3d5de0..023842e 100644
--- a/testing/wicket-arquillian/pom.xml
+++ b/testing/wicket-arquillian/pom.xml
@@ -94,10 +94,7 @@
 			<version>2.1.0.Final</version>
 			<scope>test</scope>
 		</dependency>
-		<dependency>
-			<groupId>org.jboss.arquillian.protocol</groupId>
-			<artifactId>arquillian-protocol-servlet</artifactId>
-		</dependency>
+		
 
 		<dependency>
 			<groupId>org.jboss.arquillian.junit</groupId>
@@ -120,12 +117,7 @@
 			<groupId>org.jboss.shrinkwrap.resolver</groupId>
 			<artifactId>shrinkwrap-resolver-impl-maven</artifactId>
 		</dependency>
-		<dependency>
-			<groupId>org.jboss.shrinkwrap.resolver</groupId>
-			<artifactId>shrinkwrap-resolver-spi</artifactId>
-		</dependency>
-
-
+		
 	</dependencies>
 
 	<build>


[2/8] wicket git commit: Fixed test for Java 9 date/time changes

Posted by ad...@apache.org.
Fixed test for Java 9 date/time changes

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cebdacf1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cebdacf1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cebdacf1

Branch: refs/heads/wicket-9.x
Commit: cebdacf1eb6995b0284bad225503ecfc42a5fe63
Parents: 4fe3a91
Author: Andrea Del Bene <an...@gmail.com>
Authored: Sat Apr 14 13:17:59 2018 +0200
Committer: Andrea Del Bene <an...@gmail.com>
Committed: Sat May 12 20:05:15 2018 +0200

----------------------------------------------------------------------
 .../util/convert/converter/LocalDateTimeConverterTest.java     | 4 ++--
 .../util/convert/converter/ZonedDateTimeConverterTest.java     | 6 +++---
 .../apache/wicket/util/convert/converters/ConvertersTest.java  | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/cebdacf1/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/LocalDateTimeConverterTest.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/LocalDateTimeConverterTest.java b/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/LocalDateTimeConverterTest.java
index f9dc8fc..5ca8182 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/LocalDateTimeConverterTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/LocalDateTimeConverterTest.java
@@ -35,13 +35,13 @@ public class LocalDateTimeConverterTest extends Assert
 	public void convertToString() {
 		LocalDateTimeConverter converter = new LocalDateTimeConverter();
 		String date = converter.convertToString(LocalDateTime.of(2016, 7, 11, 1, 2, 3), Locale.ENGLISH);
-		assertThat(date, is(equalTo("Jul 11, 2016 1:02:03 AM")));
+		assertThat(date, is(equalTo("Jul 11, 2016, 1:02:03 AM")));
 	}
 
 	@Test
 	public void convertToObject() {
 		LocalDateTimeConverter converter = new LocalDateTimeConverter();
-		LocalDateTime date = converter.convertToObject("Jul 11, 2016 1:02:03 AM", Locale.ENGLISH);
+		LocalDateTime date = converter.convertToObject("Jul 11, 2016, 1:02:03 AM", Locale.ENGLISH);
 		assertThat(date, is(equalTo(LocalDateTime.of(2016, 7, 11, 1, 2, 3))));
 	}
 	

http://git-wip-us.apache.org/repos/asf/wicket/blob/cebdacf1/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/ZonedDateTimeConverterTest.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/ZonedDateTimeConverterTest.java b/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/ZonedDateTimeConverterTest.java
index 58a0af9..d40a640 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/ZonedDateTimeConverterTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/convert/converter/ZonedDateTimeConverterTest.java
@@ -32,19 +32,19 @@ import org.junit.Test;
  */
 public class ZonedDateTimeConverterTest extends Assert
 {
-	private ZoneId zone = ZoneId.of("UTC");
+	private ZoneId zone = ZoneId.of("Etc/UCT");
 
 	@Test
 	public void convertToString() {
 		ZonedDateTimeConverter converter = new ZonedDateTimeConverter();
 		String date = converter.convertToString(ZonedDateTime.of(2016, 7, 11, 1, 2, 3, 0, zone), Locale.ENGLISH);
-		assertThat(date, is(equalTo("Jul 11, 2016 1:02:03 AM UTC")));
+		assertThat(date, is(equalTo("Jul 11, 2016, 1:02:03 AM Coordinated Universal Time")));
 	}
 
 	@Test
 	public void convertToObject() {
 		ZonedDateTimeConverter converter = new ZonedDateTimeConverter();
-		ZonedDateTime date = converter.convertToObject("Jul 11, 2016 1:02:03 AM UTC", Locale.ENGLISH);
+		ZonedDateTime date = converter.convertToObject("Jul 11, 2016, 1:02:03 AM Coordinated Universal Time", Locale.ENGLISH);
 		assertThat(date, is(equalTo(ZonedDateTime.of(2016, 7, 11, 1, 2, 3, 0, zone))));
 	}
 	

http://git-wip-us.apache.org/repos/asf/wicket/blob/cebdacf1/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java b/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
index 1f30783..4e025a9 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
@@ -76,7 +76,7 @@ public final class ConvertersTest
 
 		// \u00A0 = nbsp
 		// \u00A4 = currency symbol (unspecified currency)
-		String string = "1\u00A0234,00 \u00A4";
+		String string = "1\u00A0234,00\u00A0\u00A4";
 
 		assertEquals(string, fc.convertToString(Float.valueOf(1234f), Locale.FRENCH));
 		assertEquals(Float.valueOf(1234f), fc.convertToObject(string, Locale.FRENCH));
@@ -377,7 +377,7 @@ public final class ConvertersTest
 		cal.clear();
 		cal.set(2011, Calendar.MAY, 1);
 
-		assertEquals("1-5-11", converter.convertToString(cal, DUTCH_LOCALE));
+		assertEquals("01-05-11", converter.convertToString(cal, DUTCH_LOCALE));
 		assertEquals(cal, converter.convertToObject("1-5-11", DUTCH_LOCALE));
 
 		cal = Calendar.getInstance(Locale.US);


Re: [3/8] wicket git commit: version upgrade

Posted by Andrea Del Bene <an...@gmail.com>.
No decision has been made about it. I think we can use Java 10 with no
problem. The purpose of this branch is to prepare a new master branch fully
buildable with Java > 8. I've tested it with Java 9 and I'm quite sure it
can work without changing code also with Java 10. If everything is ok with
Java 10 feel free to change this code.

On Fri, May 18, 2018 at 10:45 AM, Maxim Solodovnik <so...@gmail.com>
wrote:

> Are we switching to java9? or maybe java10?
> Maybe it worth to create property for java version? (to change in one place
> only)
>
> On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:
>
> > version upgrade
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bfbdfe2d
> > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bfbdfe2d
> > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bfbdfe2d
> >
> > Branch: refs/heads/wicket-9.x
> > Commit: bfbdfe2dedfca34f20e44bf3f7aaa94a35f8a02b
> > Parents: cebdacf
> > Author: Andrea Del Bene <an...@gmail.com>
> > Authored: Sun May 13 14:29:14 2018 +0200
> > Committer: Andrea Del Bene <an...@gmail.com>
> > Committed: Sun May 13 14:29:14 2018 +0200
> >
> > ----------------------------------------------------------------------
> >  archetypes/quickstart/pom.xml                   |  2 +-
> >  pom.xml                                         | 38
> ++++++++++----------
> >  testing/wicket-arquillian/pom.xml               |  2 +-
> >  testing/wicket-common-tests/pom.xml             |  2 +-
> >  testing/wicket-js-tests/pom.xml                 |  2 +-
> >  wicket-auth-roles/pom.xml                       |  2 +-
> >  wicket-bean-validation/pom.xml                  |  2 +-
> >  wicket-cdi-1.1/pom.xml                          |  2 +-
> >  wicket-cdi/pom.xml                              |  2 +-
> >  wicket-core/pom.xml                             |  2 +-
> >  wicket-devutils/pom.xml                         |  2 +-
> >  wicket-examples/pom.xml                         |  2 +-
> >  wicket-experimental/pom.xml                     |  2 +-
> >  wicket-experimental/wicket-http2/pom.xml        |  2 +-
> >  wicket-experimental/wicket-metrics/pom.xml      |  2 +-
> >  wicket-extensions/pom.xml                       |  2 +-
> >  wicket-guice/pom.xml                            |  2 +-
> >  wicket-ioc/pom.xml                              |  2 +-
> >  wicket-jmx/pom.xml                              |  2 +-
> >  wicket-native-websocket/pom.xml                 |  2 +-
> >  .../wicket-native-websocket-core/pom.xml        |  2 +-
> >  .../wicket-native-websocket-javax/pom.xml       |  2 +-
> >  wicket-objectsizeof-agent/pom.xml               |  2 +-
> >  wicket-request/pom.xml                          |  2 +-
> >  wicket-spring/pom.xml                           |  2 +-
> >  wicket-user-guide/pom.xml                       |  2 +-
> >  wicket-util/pom.xml                             |  2 +-
> >  wicket-velocity/pom.xml                         |  2 +-
> >  wicket/pom.xml                                  |  2 +-
> >  29 files changed, 47 insertions(+), 47 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/archetypes/
> > quickstart/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/archetypes/quickstart/pom.xml b/archetypes/quickstart/pom.
> xml
> > index 09ffb23..3f04703 100644
> > --- a/archetypes/quickstart/pom.xml
> > +++ b/archetypes/quickstart/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-archetype-quickstart</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index fbecbb9..8e3a754 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -24,7 +24,7 @@
> >         </parent>
> >         <groupId>org.apache.wicket</groupId>
> >         <artifactId>wicket-parent</artifactId>
> > -       <version>8.0.0-SNAPSHOT</version>
> > +       <version>9.0.0-SNAPSHOT</version>
> >         <packaging>pom</packaging>
> >         <name>Wicket Parent</name>
> >         <description>Wicket is a Java-based open source component web
> > application framework.</description>
> > @@ -270,7 +270,7 @@
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <!-- It seems there is a bug in Maven
> > (2.2.1 & 3.0.1) and
> >                                 type 'pom' is not properly inherited.
> I.e.
> > the
> >                                 dependency management doesn't work -->
> > @@ -279,31 +279,31 @@
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-auth-roles<
> /artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-bean-
> > validation</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-cdi</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-cdi-1.1</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-core</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> > @@ -315,7 +315,7 @@
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-devutils</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> > @@ -326,37 +326,37 @@
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-extensions<
> /artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-guice</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-ioc</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-jmx</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-native-
> > websocket-core</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-native-
> > websocket-javax</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> > @@ -368,25 +368,25 @@
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-request</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-spring</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-util</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> >                                 <groupId>org.apache.wicket</groupId>
> >                                 <artifactId>wicket-velocity</artifactId>
> > -                               <version>8.0.0-SNAPSHOT</version>
> > +                               <version>9.0.0-SNAPSHOT</version>
> >                                 <type>jar</type>
> >                         </dependency>
> >                         <dependency>
> > @@ -1257,7 +1257,7 @@
> >                                                 <configuration>
> >                                                         <toolchains>
> >                                                                 <jdk>
> > -
> >  <version>1.8</version>
> > +
> >  <version>9</version>
> >
> > <vendor>oracle</vendor>
> >                                                                 </jdk>
> >                                                         </toolchains>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/testing/wicket-arquillian/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/testing/wicket-arquillian/pom.xml
> > b/testing/wicket-arquillian/pom.xml
> > index 94613da..f82ed07 100644
> > --- a/testing/wicket-arquillian/pom.xml
> > +++ b/testing/wicket-arquillian/pom.xml
> > @@ -21,7 +21,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../../pom.xml</relativePath>
> >         </parent>
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/testing/wicket-common-tests/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/testing/wicket-common-tests/pom.xml
> > b/testing/wicket-common-tests/pom.xml
> > index a8a3750..83079db 100644
> > --- a/testing/wicket-common-tests/pom.xml
> > +++ b/testing/wicket-common-tests/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-common-tests</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/testing/wicket-js-tests/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/testing/wicket-js-tests/pom.xml
> > b/testing/wicket-js-tests/pom.xml
> > index 01ba33c..1941ad8 100644
> > --- a/testing/wicket-js-tests/pom.xml
> > +++ b/testing/wicket-js-tests/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-js-tests</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-auth-roles/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-auth-roles/pom.xml b/wicket-auth-roles/pom.xml
> > index 442eb7e..a724dc0 100644
> > --- a/wicket-auth-roles/pom.xml
> > +++ b/wicket-auth-roles/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-auth-roles</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-bean-
> > validation/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-bean-validation/pom.xml
> b/wicket-bean-validation/pom.
> > xml
> > index c9b345b..77fa72c 100644
> > --- a/wicket-bean-validation/pom.xml
> > +++ b/wicket-bean-validation/pom.xml
> > @@ -4,7 +4,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-bean-validation</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-cdi-1.1/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> > index 82058a8..957ff0e 100644
> > --- a/wicket-cdi-1.1/pom.xml
> > +++ b/wicket-cdi-1.1/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-cdi-1.1</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-cdi/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-cdi/pom.xml b/wicket-cdi/pom.xml
> > index ffb927d..bbb0662 100644
> > --- a/wicket-cdi/pom.xml
> > +++ b/wicket-cdi/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-cdi</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-core/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
> > index d9386c5..3d8d7d0 100644
> > --- a/wicket-core/pom.xml
> > +++ b/wicket-core/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-core</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-devutils/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-devutils/pom.xml b/wicket-devutils/pom.xml
> > index b21d499..48bb68a 100644
> > --- a/wicket-devutils/pom.xml
> > +++ b/wicket-devutils/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-devutils</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-examples/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
> > index 550a5f4..6e1aa5e 100644
> > --- a/wicket-examples/pom.xml
> > +++ b/wicket-examples/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-examples</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-experimental/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-experimental/pom.xml b/wicket-experimental/pom.xml
> > index ff4012a..36c9587 100644
> > --- a/wicket-experimental/pom.xml
> > +++ b/wicket-experimental/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <groupId>org.apache.wicket.experimental.wicket8</groupId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-experimental/wicket-http2/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-experimental/wicket-http2/pom.xml
> > b/wicket-experimental/wicket-http2/pom.xml
> > index bd82989..0b995e9 100644
> > --- a/wicket-experimental/wicket-http2/pom.xml
> > +++ b/wicket-experimental/wicket-http2/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket.
> experimental.wicket8</groupId>
> >                 <artifactId>wicket-experimental</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-http2</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-experimental/wicket-metrics/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-experimental/wicket-metrics/pom.xml
> > b/wicket-experimental/wicket-metrics/pom.xml
> > index 66d8fa3..e6626b4 100644
> > --- a/wicket-experimental/wicket-metrics/pom.xml
> > +++ b/wicket-experimental/wicket-metrics/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket.
> experimental.wicket8</groupId>
> >                 <artifactId>wicket-experimental</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-metrics</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-extensions/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-extensions/pom.xml b/wicket-extensions/pom.xml
> > index 96508ca..33e6dde 100644
> > --- a/wicket-extensions/pom.xml
> > +++ b/wicket-extensions/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-extensions</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-guice/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-guice/pom.xml b/wicket-guice/pom.xml
> > index 6f4011a..35ea19e 100644
> > --- a/wicket-guice/pom.xml
> > +++ b/wicket-guice/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-guice</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-ioc/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-ioc/pom.xml b/wicket-ioc/pom.xml
> > index b1f517d..76a0bba 100644
> > --- a/wicket-ioc/pom.xml
> > +++ b/wicket-ioc/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-ioc</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-jmx/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-jmx/pom.xml b/wicket-jmx/pom.xml
> > index f1ceb0a..c7e3b97 100644
> > --- a/wicket-jmx/pom.xml
> > +++ b/wicket-jmx/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-jmx</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-native-
> > websocket/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-native-websocket/pom.xml
> > b/wicket-native-websocket/pom.xml
> > index 3c4309b..e5ece73 100644
> > --- a/wicket-native-websocket/pom.xml
> > +++ b/wicket-native-websocket/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-native-websocket</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-native-
> > websocket/wicket-native-websocket-core/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-native-websocket/wicket-native-websocket-core/
> pom.xml
> > b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> > index 6a1e53f..267746c 100644
> > --- a/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> > +++ b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> > @@ -21,7 +21,7 @@
> >      <parent>
> >          <groupId>org.apache.wicket</groupId>
> >          <artifactId>wicket-native-websocket</artifactId>
> > -        <version>8.0.0-SNAPSHOT</version>
> > +        <version>9.0.0-SNAPSHOT</version>
> >          <relativePath>../pom.xml</relativePath>
> >      </parent>
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-native-
> > websocket/wicket-native-websocket-javax/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-native-websocket/wicket-native-websocket-javax/
> pom.xml
> > b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> > index 27825f3..6c1586b 100644
> > --- a/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> > +++ b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-native-websocket</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-native-websocket-javax</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-objectsizeof-agent/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-objectsizeof-agent/pom.xml
> > b/wicket-objectsizeof-agent/pom.xml
> > index 65e9dd3..ba246a5 100644
> > --- a/wicket-objectsizeof-agent/pom.xml
> > +++ b/wicket-objectsizeof-agent/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-objectsizeof-agent</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-request/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-request/pom.xml b/wicket-request/pom.xml
> > index b6409d4..809edb8 100755
> > --- a/wicket-request/pom.xml
> > +++ b/wicket-request/pom.xml
> > @@ -20,7 +20,7 @@
> >    <parent>
> >      <artifactId>wicket-parent</artifactId>
> >      <groupId>org.apache.wicket</groupId>
> > -    <version>8.0.0-SNAPSHOT</version>
> > +    <version>9.0.0-SNAPSHOT</version>
> >    </parent>
> >    <artifactId>wicket-request</artifactId>
> >    <packaging>bundle</packaging>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-spring/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-spring/pom.xml b/wicket-spring/pom.xml
> > index d545bf9..6209579 100644
> > --- a/wicket-spring/pom.xml
> > +++ b/wicket-spring/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-spring</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-user-guide/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-user-guide/pom.xml b/wicket-user-guide/pom.xml
> > index 90f0f68..95f1283 100644
> > --- a/wicket-user-guide/pom.xml
> > +++ b/wicket-user-guide/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-user-guide</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-util/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-util/pom.xml b/wicket-util/pom.xml
> > index b9caec1..2720728 100755
> > --- a/wicket-util/pom.xml
> > +++ b/wicket-util/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-util</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > bfbdfe2d/wicket-velocity/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket-velocity/pom.xml b/wicket-velocity/pom.xml
> > index c7617ee..ff6d55f 100644
> > --- a/wicket-velocity/pom.xml
> > +++ b/wicket-velocity/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket-velocity</artifactId>
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/wicket/pom.xml b/wicket/pom.xml
> > index f696216..30243d2 100644
> > --- a/wicket/pom.xml
> > +++ b/wicket/pom.xml
> > @@ -20,7 +20,7 @@
> >         <parent>
> >                 <groupId>org.apache.wicket</groupId>
> >                 <artifactId>wicket-parent</artifactId>
> > -               <version>8.0.0-SNAPSHOT</version>
> > +               <version>9.0.0-SNAPSHOT</version>
> >                 <relativePath>../pom.xml</relativePath>
> >         </parent>
> >         <artifactId>wicket</artifactId>
> >
> >
>
>
> --
> WBR
> Maxim aka solomax
>

Re: [3/8] wicket git commit: version upgrade

Posted by Maxim Solodovnik <so...@gmail.com>.
Are we switching to java9? or maybe java10?
Maybe it worth to create property for java version? (to change in one place
only)

On Fri, May 18, 2018 at 3:30 PM, <ad...@apache.org> wrote:

> version upgrade
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bfbdfe2d
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bfbdfe2d
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bfbdfe2d
>
> Branch: refs/heads/wicket-9.x
> Commit: bfbdfe2dedfca34f20e44bf3f7aaa94a35f8a02b
> Parents: cebdacf
> Author: Andrea Del Bene <an...@gmail.com>
> Authored: Sun May 13 14:29:14 2018 +0200
> Committer: Andrea Del Bene <an...@gmail.com>
> Committed: Sun May 13 14:29:14 2018 +0200
>
> ----------------------------------------------------------------------
>  archetypes/quickstart/pom.xml                   |  2 +-
>  pom.xml                                         | 38 ++++++++++----------
>  testing/wicket-arquillian/pom.xml               |  2 +-
>  testing/wicket-common-tests/pom.xml             |  2 +-
>  testing/wicket-js-tests/pom.xml                 |  2 +-
>  wicket-auth-roles/pom.xml                       |  2 +-
>  wicket-bean-validation/pom.xml                  |  2 +-
>  wicket-cdi-1.1/pom.xml                          |  2 +-
>  wicket-cdi/pom.xml                              |  2 +-
>  wicket-core/pom.xml                             |  2 +-
>  wicket-devutils/pom.xml                         |  2 +-
>  wicket-examples/pom.xml                         |  2 +-
>  wicket-experimental/pom.xml                     |  2 +-
>  wicket-experimental/wicket-http2/pom.xml        |  2 +-
>  wicket-experimental/wicket-metrics/pom.xml      |  2 +-
>  wicket-extensions/pom.xml                       |  2 +-
>  wicket-guice/pom.xml                            |  2 +-
>  wicket-ioc/pom.xml                              |  2 +-
>  wicket-jmx/pom.xml                              |  2 +-
>  wicket-native-websocket/pom.xml                 |  2 +-
>  .../wicket-native-websocket-core/pom.xml        |  2 +-
>  .../wicket-native-websocket-javax/pom.xml       |  2 +-
>  wicket-objectsizeof-agent/pom.xml               |  2 +-
>  wicket-request/pom.xml                          |  2 +-
>  wicket-spring/pom.xml                           |  2 +-
>  wicket-user-guide/pom.xml                       |  2 +-
>  wicket-util/pom.xml                             |  2 +-
>  wicket-velocity/pom.xml                         |  2 +-
>  wicket/pom.xml                                  |  2 +-
>  29 files changed, 47 insertions(+), 47 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/archetypes/
> quickstart/pom.xml
> ----------------------------------------------------------------------
> diff --git a/archetypes/quickstart/pom.xml b/archetypes/quickstart/pom.xml
> index 09ffb23..3f04703 100644
> --- a/archetypes/quickstart/pom.xml
> +++ b/archetypes/quickstart/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-archetype-quickstart</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index fbecbb9..8e3a754 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -24,7 +24,7 @@
>         </parent>
>         <groupId>org.apache.wicket</groupId>
>         <artifactId>wicket-parent</artifactId>
> -       <version>8.0.0-SNAPSHOT</version>
> +       <version>9.0.0-SNAPSHOT</version>
>         <packaging>pom</packaging>
>         <name>Wicket Parent</name>
>         <description>Wicket is a Java-based open source component web
> application framework.</description>
> @@ -270,7 +270,7 @@
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <!-- It seems there is a bug in Maven
> (2.2.1 & 3.0.1) and
>                                 type 'pom' is not properly inherited. I.e.
> the
>                                 dependency management doesn't work -->
> @@ -279,31 +279,31 @@
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-auth-roles</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-bean-
> validation</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-cdi</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-cdi-1.1</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-core</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
> @@ -315,7 +315,7 @@
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-devutils</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
> @@ -326,37 +326,37 @@
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-extensions</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-guice</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-ioc</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-jmx</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-native-
> websocket-core</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-native-
> websocket-javax</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
> @@ -368,25 +368,25 @@
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-request</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-spring</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-util</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
>                                 <groupId>org.apache.wicket</groupId>
>                                 <artifactId>wicket-velocity</artifactId>
> -                               <version>8.0.0-SNAPSHOT</version>
> +                               <version>9.0.0-SNAPSHOT</version>
>                                 <type>jar</type>
>                         </dependency>
>                         <dependency>
> @@ -1257,7 +1257,7 @@
>                                                 <configuration>
>                                                         <toolchains>
>                                                                 <jdk>
> -
>  <version>1.8</version>
> +
>  <version>9</version>
>
> <vendor>oracle</vendor>
>                                                                 </jdk>
>                                                         </toolchains>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/testing/wicket-arquillian/pom.xml
> ----------------------------------------------------------------------
> diff --git a/testing/wicket-arquillian/pom.xml
> b/testing/wicket-arquillian/pom.xml
> index 94613da..f82ed07 100644
> --- a/testing/wicket-arquillian/pom.xml
> +++ b/testing/wicket-arquillian/pom.xml
> @@ -21,7 +21,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../../pom.xml</relativePath>
>         </parent>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/testing/wicket-common-tests/pom.xml
> ----------------------------------------------------------------------
> diff --git a/testing/wicket-common-tests/pom.xml
> b/testing/wicket-common-tests/pom.xml
> index a8a3750..83079db 100644
> --- a/testing/wicket-common-tests/pom.xml
> +++ b/testing/wicket-common-tests/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-common-tests</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/testing/wicket-js-tests/pom.xml
> ----------------------------------------------------------------------
> diff --git a/testing/wicket-js-tests/pom.xml
> b/testing/wicket-js-tests/pom.xml
> index 01ba33c..1941ad8 100644
> --- a/testing/wicket-js-tests/pom.xml
> +++ b/testing/wicket-js-tests/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-js-tests</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-auth-roles/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-auth-roles/pom.xml b/wicket-auth-roles/pom.xml
> index 442eb7e..a724dc0 100644
> --- a/wicket-auth-roles/pom.xml
> +++ b/wicket-auth-roles/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-auth-roles</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-bean-
> validation/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-bean-validation/pom.xml b/wicket-bean-validation/pom.
> xml
> index c9b345b..77fa72c 100644
> --- a/wicket-bean-validation/pom.xml
> +++ b/wicket-bean-validation/pom.xml
> @@ -4,7 +4,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-bean-validation</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-cdi-1.1/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
> index 82058a8..957ff0e 100644
> --- a/wicket-cdi-1.1/pom.xml
> +++ b/wicket-cdi-1.1/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-cdi-1.1</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-cdi/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-cdi/pom.xml b/wicket-cdi/pom.xml
> index ffb927d..bbb0662 100644
> --- a/wicket-cdi/pom.xml
> +++ b/wicket-cdi/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-cdi</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
> index d9386c5..3d8d7d0 100644
> --- a/wicket-core/pom.xml
> +++ b/wicket-core/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-core</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-devutils/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-devutils/pom.xml b/wicket-devutils/pom.xml
> index b21d499..48bb68a 100644
> --- a/wicket-devutils/pom.xml
> +++ b/wicket-devutils/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-devutils</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-examples/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
> index 550a5f4..6e1aa5e 100644
> --- a/wicket-examples/pom.xml
> +++ b/wicket-examples/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-examples</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-experimental/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-experimental/pom.xml b/wicket-experimental/pom.xml
> index ff4012a..36c9587 100644
> --- a/wicket-experimental/pom.xml
> +++ b/wicket-experimental/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <groupId>org.apache.wicket.experimental.wicket8</groupId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-experimental/wicket-http2/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-experimental/wicket-http2/pom.xml
> b/wicket-experimental/wicket-http2/pom.xml
> index bd82989..0b995e9 100644
> --- a/wicket-experimental/wicket-http2/pom.xml
> +++ b/wicket-experimental/wicket-http2/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket.experimental.wicket8</groupId>
>                 <artifactId>wicket-experimental</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-http2</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-experimental/wicket-metrics/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-experimental/wicket-metrics/pom.xml
> b/wicket-experimental/wicket-metrics/pom.xml
> index 66d8fa3..e6626b4 100644
> --- a/wicket-experimental/wicket-metrics/pom.xml
> +++ b/wicket-experimental/wicket-metrics/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket.experimental.wicket8</groupId>
>                 <artifactId>wicket-experimental</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-metrics</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-extensions/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-extensions/pom.xml b/wicket-extensions/pom.xml
> index 96508ca..33e6dde 100644
> --- a/wicket-extensions/pom.xml
> +++ b/wicket-extensions/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-extensions</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-guice/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-guice/pom.xml b/wicket-guice/pom.xml
> index 6f4011a..35ea19e 100644
> --- a/wicket-guice/pom.xml
> +++ b/wicket-guice/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-guice</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-ioc/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-ioc/pom.xml b/wicket-ioc/pom.xml
> index b1f517d..76a0bba 100644
> --- a/wicket-ioc/pom.xml
> +++ b/wicket-ioc/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-ioc</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-jmx/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-jmx/pom.xml b/wicket-jmx/pom.xml
> index f1ceb0a..c7e3b97 100644
> --- a/wicket-jmx/pom.xml
> +++ b/wicket-jmx/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-jmx</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-
> websocket/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-native-websocket/pom.xml
> b/wicket-native-websocket/pom.xml
> index 3c4309b..e5ece73 100644
> --- a/wicket-native-websocket/pom.xml
> +++ b/wicket-native-websocket/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-native-websocket</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-
> websocket/wicket-native-websocket-core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> index 6a1e53f..267746c 100644
> --- a/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> +++ b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
> @@ -21,7 +21,7 @@
>      <parent>
>          <groupId>org.apache.wicket</groupId>
>          <artifactId>wicket-native-websocket</artifactId>
> -        <version>8.0.0-SNAPSHOT</version>
> +        <version>9.0.0-SNAPSHOT</version>
>          <relativePath>../pom.xml</relativePath>
>      </parent>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-
> websocket/wicket-native-websocket-javax/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> index 27825f3..6c1586b 100644
> --- a/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> +++ b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-native-websocket</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-native-websocket-javax</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-objectsizeof-agent/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-objectsizeof-agent/pom.xml
> b/wicket-objectsizeof-agent/pom.xml
> index 65e9dd3..ba246a5 100644
> --- a/wicket-objectsizeof-agent/pom.xml
> +++ b/wicket-objectsizeof-agent/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-objectsizeof-agent</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-request/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-request/pom.xml b/wicket-request/pom.xml
> index b6409d4..809edb8 100755
> --- a/wicket-request/pom.xml
> +++ b/wicket-request/pom.xml
> @@ -20,7 +20,7 @@
>    <parent>
>      <artifactId>wicket-parent</artifactId>
>      <groupId>org.apache.wicket</groupId>
> -    <version>8.0.0-SNAPSHOT</version>
> +    <version>9.0.0-SNAPSHOT</version>
>    </parent>
>    <artifactId>wicket-request</artifactId>
>    <packaging>bundle</packaging>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-spring/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-spring/pom.xml b/wicket-spring/pom.xml
> index d545bf9..6209579 100644
> --- a/wicket-spring/pom.xml
> +++ b/wicket-spring/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-spring</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-user-guide/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-user-guide/pom.xml b/wicket-user-guide/pom.xml
> index 90f0f68..95f1283 100644
> --- a/wicket-user-guide/pom.xml
> +++ b/wicket-user-guide/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-user-guide</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-util/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-util/pom.xml b/wicket-util/pom.xml
> index b9caec1..2720728 100755
> --- a/wicket-util/pom.xml
> +++ b/wicket-util/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-util</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> bfbdfe2d/wicket-velocity/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket-velocity/pom.xml b/wicket-velocity/pom.xml
> index c7617ee..ff6d55f 100644
> --- a/wicket-velocity/pom.xml
> +++ b/wicket-velocity/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket-velocity</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket/pom.xml
> ----------------------------------------------------------------------
> diff --git a/wicket/pom.xml b/wicket/pom.xml
> index f696216..30243d2 100644
> --- a/wicket/pom.xml
> +++ b/wicket/pom.xml
> @@ -20,7 +20,7 @@
>         <parent>
>                 <groupId>org.apache.wicket</groupId>
>                 <artifactId>wicket-parent</artifactId>
> -               <version>8.0.0-SNAPSHOT</version>
> +               <version>9.0.0-SNAPSHOT</version>
>                 <relativePath>../pom.xml</relativePath>
>         </parent>
>         <artifactId>wicket</artifactId>
>
>


-- 
WBR
Maxim aka solomax

[3/8] wicket git commit: version upgrade

Posted by ad...@apache.org.
version upgrade


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bfbdfe2d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bfbdfe2d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bfbdfe2d

Branch: refs/heads/wicket-9.x
Commit: bfbdfe2dedfca34f20e44bf3f7aaa94a35f8a02b
Parents: cebdacf
Author: Andrea Del Bene <an...@gmail.com>
Authored: Sun May 13 14:29:14 2018 +0200
Committer: Andrea Del Bene <an...@gmail.com>
Committed: Sun May 13 14:29:14 2018 +0200

----------------------------------------------------------------------
 archetypes/quickstart/pom.xml                   |  2 +-
 pom.xml                                         | 38 ++++++++++----------
 testing/wicket-arquillian/pom.xml               |  2 +-
 testing/wicket-common-tests/pom.xml             |  2 +-
 testing/wicket-js-tests/pom.xml                 |  2 +-
 wicket-auth-roles/pom.xml                       |  2 +-
 wicket-bean-validation/pom.xml                  |  2 +-
 wicket-cdi-1.1/pom.xml                          |  2 +-
 wicket-cdi/pom.xml                              |  2 +-
 wicket-core/pom.xml                             |  2 +-
 wicket-devutils/pom.xml                         |  2 +-
 wicket-examples/pom.xml                         |  2 +-
 wicket-experimental/pom.xml                     |  2 +-
 wicket-experimental/wicket-http2/pom.xml        |  2 +-
 wicket-experimental/wicket-metrics/pom.xml      |  2 +-
 wicket-extensions/pom.xml                       |  2 +-
 wicket-guice/pom.xml                            |  2 +-
 wicket-ioc/pom.xml                              |  2 +-
 wicket-jmx/pom.xml                              |  2 +-
 wicket-native-websocket/pom.xml                 |  2 +-
 .../wicket-native-websocket-core/pom.xml        |  2 +-
 .../wicket-native-websocket-javax/pom.xml       |  2 +-
 wicket-objectsizeof-agent/pom.xml               |  2 +-
 wicket-request/pom.xml                          |  2 +-
 wicket-spring/pom.xml                           |  2 +-
 wicket-user-guide/pom.xml                       |  2 +-
 wicket-util/pom.xml                             |  2 +-
 wicket-velocity/pom.xml                         |  2 +-
 wicket/pom.xml                                  |  2 +-
 29 files changed, 47 insertions(+), 47 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/archetypes/quickstart/pom.xml
----------------------------------------------------------------------
diff --git a/archetypes/quickstart/pom.xml b/archetypes/quickstart/pom.xml
index 09ffb23..3f04703 100644
--- a/archetypes/quickstart/pom.xml
+++ b/archetypes/quickstart/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-archetype-quickstart</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index fbecbb9..8e3a754 100644
--- a/pom.xml
+++ b/pom.xml
@@ -24,7 +24,7 @@
 	</parent>
 	<groupId>org.apache.wicket</groupId>
 	<artifactId>wicket-parent</artifactId>
-	<version>8.0.0-SNAPSHOT</version>
+	<version>9.0.0-SNAPSHOT</version>
 	<packaging>pom</packaging>
 	<name>Wicket Parent</name>
 	<description>Wicket is a Java-based open source component web application framework.</description>
@@ -270,7 +270,7 @@
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<!-- It seems there is a bug in Maven (2.2.1 & 3.0.1) and
 				type 'pom' is not properly inherited. I.e. the
 				dependency management doesn't work -->
@@ -279,31 +279,31 @@
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-auth-roles</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-bean-validation</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-cdi</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-cdi-1.1</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-core</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
@@ -315,7 +315,7 @@
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-devutils</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
@@ -326,37 +326,37 @@
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-extensions</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-guice</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-ioc</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-jmx</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-native-websocket-core</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-native-websocket-javax</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
@@ -368,25 +368,25 @@
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-request</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-spring</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-util</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
 				<groupId>org.apache.wicket</groupId>
 				<artifactId>wicket-velocity</artifactId>
-				<version>8.0.0-SNAPSHOT</version>
+				<version>9.0.0-SNAPSHOT</version>
 				<type>jar</type>
 			</dependency>
 			<dependency>
@@ -1257,7 +1257,7 @@
 						<configuration>
 							<toolchains>
 								<jdk>
-									<version>1.8</version>
+									<version>9</version>
 									<vendor>oracle</vendor>
 								</jdk>
 							</toolchains>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/testing/wicket-arquillian/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-arquillian/pom.xml b/testing/wicket-arquillian/pom.xml
index 94613da..f82ed07 100644
--- a/testing/wicket-arquillian/pom.xml
+++ b/testing/wicket-arquillian/pom.xml
@@ -21,7 +21,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../../pom.xml</relativePath>
 	</parent>
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/testing/wicket-common-tests/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-common-tests/pom.xml b/testing/wicket-common-tests/pom.xml
index a8a3750..83079db 100644
--- a/testing/wicket-common-tests/pom.xml
+++ b/testing/wicket-common-tests/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-common-tests</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/testing/wicket-js-tests/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-js-tests/pom.xml b/testing/wicket-js-tests/pom.xml
index 01ba33c..1941ad8 100644
--- a/testing/wicket-js-tests/pom.xml
+++ b/testing/wicket-js-tests/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-js-tests</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-auth-roles/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-auth-roles/pom.xml b/wicket-auth-roles/pom.xml
index 442eb7e..a724dc0 100644
--- a/wicket-auth-roles/pom.xml
+++ b/wicket-auth-roles/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-auth-roles</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-bean-validation/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-bean-validation/pom.xml b/wicket-bean-validation/pom.xml
index c9b345b..77fa72c 100644
--- a/wicket-bean-validation/pom.xml
+++ b/wicket-bean-validation/pom.xml
@@ -4,7 +4,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-bean-validation</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-cdi-1.1/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/pom.xml b/wicket-cdi-1.1/pom.xml
index 82058a8..957ff0e 100644
--- a/wicket-cdi-1.1/pom.xml
+++ b/wicket-cdi-1.1/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-cdi-1.1</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-cdi/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-cdi/pom.xml b/wicket-cdi/pom.xml
index ffb927d..bbb0662 100644
--- a/wicket-cdi/pom.xml
+++ b/wicket-cdi/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-cdi</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-core/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
index d9386c5..3d8d7d0 100644
--- a/wicket-core/pom.xml
+++ b/wicket-core/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-core</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-devutils/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-devutils/pom.xml b/wicket-devutils/pom.xml
index b21d499..48bb68a 100644
--- a/wicket-devutils/pom.xml
+++ b/wicket-devutils/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-devutils</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-examples/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
index 550a5f4..6e1aa5e 100644
--- a/wicket-examples/pom.xml
+++ b/wicket-examples/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-examples</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-experimental/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-experimental/pom.xml b/wicket-experimental/pom.xml
index ff4012a..36c9587 100644
--- a/wicket-experimental/pom.xml
+++ b/wicket-experimental/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<groupId>org.apache.wicket.experimental.wicket8</groupId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-experimental/wicket-http2/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-experimental/wicket-http2/pom.xml b/wicket-experimental/wicket-http2/pom.xml
index bd82989..0b995e9 100644
--- a/wicket-experimental/wicket-http2/pom.xml
+++ b/wicket-experimental/wicket-http2/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket.experimental.wicket8</groupId>
 		<artifactId>wicket-experimental</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-http2</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-experimental/wicket-metrics/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-experimental/wicket-metrics/pom.xml b/wicket-experimental/wicket-metrics/pom.xml
index 66d8fa3..e6626b4 100644
--- a/wicket-experimental/wicket-metrics/pom.xml
+++ b/wicket-experimental/wicket-metrics/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket.experimental.wicket8</groupId>
 		<artifactId>wicket-experimental</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-metrics</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-extensions/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-extensions/pom.xml b/wicket-extensions/pom.xml
index 96508ca..33e6dde 100644
--- a/wicket-extensions/pom.xml
+++ b/wicket-extensions/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-extensions</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-guice/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-guice/pom.xml b/wicket-guice/pom.xml
index 6f4011a..35ea19e 100644
--- a/wicket-guice/pom.xml
+++ b/wicket-guice/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-guice</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-ioc/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-ioc/pom.xml b/wicket-ioc/pom.xml
index b1f517d..76a0bba 100644
--- a/wicket-ioc/pom.xml
+++ b/wicket-ioc/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-ioc</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-jmx/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-jmx/pom.xml b/wicket-jmx/pom.xml
index f1ceb0a..c7e3b97 100644
--- a/wicket-jmx/pom.xml
+++ b/wicket-jmx/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-jmx</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-websocket/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-native-websocket/pom.xml b/wicket-native-websocket/pom.xml
index 3c4309b..e5ece73 100644
--- a/wicket-native-websocket/pom.xml
+++ b/wicket-native-websocket/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-native-websocket</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-websocket/wicket-native-websocket-core/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-native-websocket/wicket-native-websocket-core/pom.xml b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
index 6a1e53f..267746c 100644
--- a/wicket-native-websocket/wicket-native-websocket-core/pom.xml
+++ b/wicket-native-websocket/wicket-native-websocket-core/pom.xml
@@ -21,7 +21,7 @@
     <parent>
         <groupId>org.apache.wicket</groupId>
         <artifactId>wicket-native-websocket</artifactId>
-        <version>8.0.0-SNAPSHOT</version>
+        <version>9.0.0-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-native-websocket/wicket-native-websocket-javax/pom.xml b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
index 27825f3..6c1586b 100644
--- a/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
+++ b/wicket-native-websocket/wicket-native-websocket-javax/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-native-websocket</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-native-websocket-javax</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-objectsizeof-agent/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-objectsizeof-agent/pom.xml b/wicket-objectsizeof-agent/pom.xml
index 65e9dd3..ba246a5 100644
--- a/wicket-objectsizeof-agent/pom.xml
+++ b/wicket-objectsizeof-agent/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-objectsizeof-agent</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-request/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-request/pom.xml b/wicket-request/pom.xml
index b6409d4..809edb8 100755
--- a/wicket-request/pom.xml
+++ b/wicket-request/pom.xml
@@ -20,7 +20,7 @@
   <parent>
     <artifactId>wicket-parent</artifactId>
     <groupId>org.apache.wicket</groupId>
-    <version>8.0.0-SNAPSHOT</version>
+    <version>9.0.0-SNAPSHOT</version>
   </parent>
   <artifactId>wicket-request</artifactId>
   <packaging>bundle</packaging>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-spring/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-spring/pom.xml b/wicket-spring/pom.xml
index d545bf9..6209579 100644
--- a/wicket-spring/pom.xml
+++ b/wicket-spring/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-spring</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-user-guide/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-user-guide/pom.xml b/wicket-user-guide/pom.xml
index 90f0f68..95f1283 100644
--- a/wicket-user-guide/pom.xml
+++ b/wicket-user-guide/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-user-guide</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-util/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-util/pom.xml b/wicket-util/pom.xml
index b9caec1..2720728 100755
--- a/wicket-util/pom.xml
+++ b/wicket-util/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-util</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket-velocity/pom.xml
----------------------------------------------------------------------
diff --git a/wicket-velocity/pom.xml b/wicket-velocity/pom.xml
index c7617ee..ff6d55f 100644
--- a/wicket-velocity/pom.xml
+++ b/wicket-velocity/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket-velocity</artifactId>

http://git-wip-us.apache.org/repos/asf/wicket/blob/bfbdfe2d/wicket/pom.xml
----------------------------------------------------------------------
diff --git a/wicket/pom.xml b/wicket/pom.xml
index f696216..30243d2 100644
--- a/wicket/pom.xml
+++ b/wicket/pom.xml
@@ -20,7 +20,7 @@
 	<parent>
 		<groupId>org.apache.wicket</groupId>
 		<artifactId>wicket-parent</artifactId>
-		<version>8.0.0-SNAPSHOT</version>
+		<version>9.0.0-SNAPSHOT</version>
 		<relativePath>../pom.xml</relativePath>
 	</parent>
 	<artifactId>wicket</artifactId>