You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2015/12/09 18:05:23 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - Make test compliant wit...
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1204
CLOUDSTACK-9123 - Make test compliant with multiple hypervisors
This PR make the test_internal_lb.py work with other Hypervisors types.
- Get hypervisor information from testClient.getHypervisorInfo()
- Adds XenServer, HyperV and VMware hypervisors
- Makes sure the OS type is "Other PV (64-bit)"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack improve/test-internal-lb-CLOUDSTACK-9123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1204
----
commit c7f5e8a82724d09b61884e1f45f3995a93f9e3a0
Author: Wilder Rodrigues <wr...@schubergphilis.com>
Date: 2015-12-08T15:09:24Z
CLOUDSTACK-9123 - Make test compliant with multiple hypervisors
- Get hypervisor information from testClient.getHypervisorInfo()
- Adds HyperV and VMware hypervisors
- Makes sure the OS type is "Other PV (64-bit)"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163536301
@wilderrodrigues @remibergsma I could only verify for KVM.
Ran tests on Ubuntu 14.04 management/hypervisor.
```
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 2532.875s
```
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163539777
Thanks, @borisroman!
@michaelandersen, have you already tested this against Xen?
By the way, I did both already.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163660061
FYI: my tests also succeeded.
```
[root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_88R1S8/results.txt
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1733.573s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163539898
Ran tests on Xenserver 6.2:
Results:
```
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1064.773s
OK
```
Environment:
```
1 XenServer 6.2
Management Server on CentOS 7.1
```
Test command:
```
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a tags=advanced,required_hardware=true test_internal_lb.py
```
LGTM!
good work @wilderrodrigues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - Make test compliant wit...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163326324
Ping @remibergsma @borisroman @michaelandersen @miguelaferreira @DaanHoogland @karuturi
* Environment
* 1 KVM on CentOS 7.1
* Management Server on CentOS 7.1
* Agent + Common built from source
* Tests
```
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a tags=advanced,required_hardware=true smoke/test_internal_lb.py
```
* Results
```
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 2867.658s
OK
/tmp//MarvinLogs/test_internal_lb_YAYUF4/results.txt (END)
```
* Environment
* 1 XenServer 6.2
* Management Server on CentOS 7.1
* Tests
```
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1-ISOLATED.cfg -s -a tags=advanced,required_hardware=true smoke/test_internal_lb.py
```
* Results
```
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1146.677s
OK
/tmp//MarvinLogs/test_internal_lb_NPZKJ3/results.txt (END)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1204#issuecomment-163542058
Thanks, @michaelandersen!
Ping @remibergsma @DaanHoogland - this one is ready to be merged.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---