You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zyfeier (via GitHub)" <gi...@apache.org> on 2023/03/15 07:27:40 UTC
[GitHub] [nuttx-apps] zyfeier opened a new pull request, #1664: apps: add header file
zyfeier opened a new pull request, #1664:
URL: https://github.com/apache/nuttx-apps/pull/1664
## Summary
Add missing assert.h header file.
## Impact
NA
## Testing
CI Pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko merged pull request #1664: apps: add header file
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #1664:
URL: https://github.com/apache/nuttx-apps/pull/1664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1664: apps: add header file
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1664:
URL: https://github.com/apache/nuttx-apps/pull/1664#discussion_r1136794926
##########
testing/ostest/ostest.h:
##########
@@ -27,6 +27,8 @@
#include <nuttx/config.h>
+#include <assert.h>
Review Comment:
In general I do not support indirect including. What from ostest.h needs assert.h?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] gustavonihei commented on a diff in pull request #1664: apps: add header file
Posted by "gustavonihei (via GitHub)" <gi...@apache.org>.
gustavonihei commented on code in PR #1664:
URL: https://github.com/apache/nuttx-apps/pull/1664#discussion_r1137079752
##########
testing/ostest/ostest.h:
##########
@@ -27,6 +27,8 @@
#include <nuttx/config.h>
+#include <assert.h>
Review Comment:
Agreed, `assert.h` should be included directly in the files where it is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org