You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2017/11/29 15:59:38 UTC
[myfaces-tobago] 03/06: TOBAGO-1782: Clean up JS: using !== and ===
instead of != and ==
This is an automated email from the ASF dual-hosted git repository.
lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit d4172ae2d94926b673c15365598407d20d3ab8e2
Author: Udo Schnurpfeil <lo...@apache.org>
AuthorDate: Wed Nov 29 16:35:46 2017 +0100
TOBAGO-1782: Clean up
JS: using !== and === instead of != and ==
---
.../tobago-bootstrap/_version/js/tobago-sheet.js | 58 +++++++++++-----------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/tobago-theme/tobago-theme-standard/src/main/resources/META-INF/resources/tobago/standard/tobago-bootstrap/_version/js/tobago-sheet.js b/tobago-theme/tobago-theme-standard/src/main/resources/META-INF/resources/tobago/standard/tobago-bootstrap/_version/js/tobago-sheet.js
index 45adaf4..3936ca1 100644
--- a/tobago-theme/tobago-theme-standard/src/main/resources/META-INF/resources/tobago/standard/tobago-bootstrap/_version/js/tobago-sheet.js
+++ b/tobago-theme/tobago-theme-standard/src/main/resources/META-INF/resources/tobago/standard/tobago-bootstrap/_version/js/tobago-sheet.js
@@ -55,16 +55,16 @@ Tobago.Sheet.init = function(elements) {
var click = commands ? commands.click : undefined;
var dblclick = commands ? commands.dblclick : undefined;
new Tobago.Sheet(id, undefined, undefined, undefined, undefined,
- click != undefined ? click.action : undefined,
- click != undefined ? click.partially : undefined, // fixme: partially no longer used
- dblclick != undefined ? dblclick.action : undefined,
- dblclick != undefined ? dblclick.partially: undefined, // fixme: partially no longer used
+ click !== undefined ? click.action : undefined,
+ click !== undefined ? click.partially : undefined, // fixme: partially no longer used
+ dblclick !== undefined ? dblclick.action : undefined,
+ dblclick !== undefined ? dblclick.partially: undefined, // fixme: partially no longer used
sheet.data("tobago-behavior-commands")); // type array
//////////////////////////////////////////////
// XXX bugfix for IE11 (lower than IE11 isn't supported for that feature)
// if a max-height is set on the sheet,
- if (Tobago.browser.isMsie && sheet.css("max-height") != "none") {
+ if (Tobago.browser.isMsie && sheet.css("max-height") !== "none") {
sheet.css("height", sheet.css("height")); // reset the height to the same value
}
});
@@ -118,7 +118,7 @@ Tobago.Sheet.setup2 = function (sheets) {
jQuery(sheets).each(function() {
// basic idea: there are two possible sources for the sizes:
- // 1. the columns attribute of <tc:sheet> like columns="3*;200px;3*", held by data attribute "tobago-layout"
+ // 1. the columns attribute of <tc:sheet> like {"columns":[1.0,1.0,1.0]}, held by data attribute "tobago-layout"
// 2. the hidden field which may contain a value like ",300,200,100,"
//
// The 1st source usually is the default set by the developer.
@@ -136,7 +136,7 @@ Tobago.Sheet.setup2 = function (sheets) {
var columnWidths = jQuery.parseJSON(hidden.val());
console.info("columnWidths: " + columnWidths); // @DEV_ONLY
}
- if (columnWidths != undefined && columnWidths.length == 0) {
+ if (columnWidths !== undefined && columnWidths.length === 0) {
// otherwise use the layout definition
var layout = $sheet.data("tobago-layout");
if (layout && layout.columns && layout.columns.length > 0) {
@@ -148,17 +148,17 @@ Tobago.Sheet.setup2 = function (sheets) {
var $bodyTable = $sheet.children("div").children("table");
var $bodyCol = $bodyTable.children("colgroup").children("col");
- console.assert($headerCol.length - 1 == $bodyCol.length, "header and body column number doesn't match"); // @DEV_ONLY
+ console.assert($headerCol.length - 1 === $bodyCol.length, "header and body column number doesn't match"); // @DEV_ONLY
var i;
var intValue;
var sumRelative = 0;
var widthRelative = $bodyTable.width();
for (i = 0; i < tokens.length; i++) {
- if (rendered[i] == "true") {
- if (typeof tokens[i] == "number") {
+ if (rendered[i] === "true") {
+ if (typeof tokens[i] === "number") {
sumRelative += tokens[i];
- } else if (typeof tokens[i] == "object" && tokens[i].measure != undefined) {
+ } else if (typeof tokens[i] === "object" && tokens[i].measure !== undefined) {
intValue = parseInt(tokens[i].measure);
if (tokens[i].measure.lastIndexOf("px") > 0) {
widthRelative -= intValue;
@@ -175,10 +175,10 @@ Tobago.Sheet.setup2 = function (sheets) {
var headerBodyColCount = 0;
for (i = 0; i < tokens.length; i++) {
var colWidth = 0;
- if (rendered[i] == "true") {
- if (typeof tokens[i] == "number") {
+ if (rendered[i] === "true") {
+ if (typeof tokens[i] === "number") {
colWidth = parseInt((tokens[i] * widthRelative) / sumRelative);
- } else if (typeof tokens[i] == "object" && tokens[i].measure != undefined) {
+ } else if (typeof tokens[i] === "object" && tokens[i].measure !== undefined) {
intValue = parseInt(tokens[i].measure);
if (tokens[i].measure.lastIndexOf("px") > 0) {
colWidth = intValue;
@@ -257,7 +257,7 @@ Tobago.Sheet.setup2 = function (sheets) {
var usedWidth = 0;
var headerBodyColCount = 0;
for (i = 0; i < rendered.length; i++) {
- if (rendered[i] == "true") {
+ if (rendered[i] === "true") {
// last column is the filler column
var newWidth = headerCols.eq(headerBodyColCount).width();
// for the hidden field
@@ -265,7 +265,7 @@ Tobago.Sheet.setup2 = function (sheets) {
usedWidth += newWidth;
var oldWidth = bodyCols.eq(headerBodyColCount).width();
- if (oldWidth != newWidth) {
+ if (oldWidth !== newWidth) {
// set to the body
bodyCols.eq(headerBodyColCount).attr("width", newWidth);
// reset the width inside of the cells (TD) if the value was changed.
@@ -278,12 +278,12 @@ Tobago.Sheet.setup2 = function (sheets) {
}
}
headerBodyColCount++;
- } else if (hiddenWidths != undefined && hiddenWidths.length >= i) {
+ } else if (hiddenWidths !== undefined && hiddenWidths.length >= i) {
widths[i] = hiddenWidths[i];
} else {
- if (typeof tokens[i] == "number") {
+ if (typeof tokens[i] === "number") {
widths[i] = 100;
- } else if (typeof tokens[i] == "object" && tokens[i].measure != undefined) {
+ } else if (typeof tokens[i] === "object" && tokens[i].measure !== undefined) {
var intValue = parseInt(tokens[i].measure);
if (tokens[i].measure.lastIndexOf("px") > 0) {
widths[i] = intValue;
@@ -323,7 +323,7 @@ Tobago.Sheet.setup2 = function (sheets) {
var sheet = jQuery(this);
var hidden = Tobago.Sheet.findHiddenScrollPosition(sheet);
var sep = hidden.val().indexOf(";");
- if (sep != -1) {
+ if (sep !== -1) {
var scrollLeft = hidden.val().substr(0, sep);
var scrollTop = hidden.val().substr(sep + 1);
var body = sheet.children(".tobago-sheet-body");
@@ -337,7 +337,7 @@ Tobago.Sheet.setup2 = function (sheets) {
jQuery(sheets).each(function () {
var sheet = jQuery(this);
var selectionMode = sheet.data("tobago-selection-mode");
- if (selectionMode == "single" || selectionMode == "singleOrNone" || selectionMode == "multi") {
+ if (selectionMode === "single" || selectionMode === "singleOrNone" || selectionMode === "multi") {
Tobago.Sheet.getRows(sheet).each(function () {
var row = jQuery(this);
row.bind("mousedown", function (event) {
@@ -364,20 +364,20 @@ Tobago.Sheet.setup2 = function (sheets) {
var selectionMode = $sheet.data("tobago-selection-mode");
- if ((!event.ctrlKey && !event.metaKey && $selector.size() == 0)
- || selectionMode == "single" || selectionMode == "singleOrNone") {
+ if ((!event.ctrlKey && !event.metaKey && $selector.size() === 0)
+ || selectionMode === "single" || selectionMode === "singleOrNone") {
Tobago.Sheet.deselectAll($sheet);
Tobago.Sheet.resetSelected($sheet);
}
var lastClickedRowIndex = $sheet.data("tobago-last-clicked-row-index");
- if (event.shiftKey && selectionMode == "multi" && lastClickedRowIndex > -1) {
+ if (event.shiftKey && selectionMode === "multi" && lastClickedRowIndex > -1) {
if (lastClickedRowIndex <= $row.index()) {
Tobago.Sheet.selectRange($sheet, $rows, lastClickedRowIndex, $row.index(), true, false);
} else {
Tobago.Sheet.selectRange($sheet, $rows, $row.index(), lastClickedRowIndex, true, false);
}
- } else if (selectionMode != "singleOrNone" || !Tobago.Sheet.isRowSelected($sheet, $row)) {
+ } else if (selectionMode !== "singleOrNone" || !Tobago.Sheet.isRowSelected($sheet, $row)) {
Tobago.Sheet.toggleSelection($sheet, $row, $selector);
}
var commands = sheet.data("tobago-row-action");
@@ -443,7 +443,7 @@ Tobago.Sheet.setup2 = function (sheets) {
.blur(function () {
Tobago.Sheet.hideInputOrSubmit(jQuery(this));
}).keydown(function (event) {
- if (event.keyCode == 13) {
+ if (event.keyCode === 13) {
event.stopPropagation();
event.preventDefault();
jQuery(this).blur();
@@ -454,7 +454,7 @@ Tobago.Sheet.setup2 = function (sheets) {
Tobago.Sheet.hideInputOrSubmit = function(input) {
var output = input.siblings(".tobago-sheet-pagingOutput");
- var changed = output.html() != input.val();
+ var changed = output.html() !== input.val();
var sheetId = input.parents(".tobago-sheet:first").attr("id");
output.html(input.val());
if (changed) {
@@ -508,7 +508,7 @@ Tobago.Sheet.prototype.setup = function() {
Tobago.Sheet.prototype.initReload = function() {
var sheet = jQuery(Tobago.Utils.escapeClientId(this.id));
var reload = sheet.data("tobago-reload");
- if (typeof reload == "number") {
+ if (typeof reload === "number") {
Tobago.addReloadTimeout(this.id, Tobago.bind2(this, "reloadWithAction", null, this.id), reload);
}
};
@@ -617,7 +617,7 @@ Tobago.Sheet.toggleAll = function(sheet) {
};
Tobago.Sheet.selectRange = function($sheet, $rows, first, last, selectDeselected, deselectSelected) {
- if ($rows.size() == 0) {
+ if ($rows.size() === 0) {
return;
}
var selected = Tobago.Sheet.findHiddenSelected($sheet);
--
To stop receiving notification emails like this one, please contact
"commits@myfaces.apache.org" <co...@myfaces.apache.org>.