You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/19 17:53:24 UTC
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.3.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated May 19, 2017, 5:53 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
use 3.3.0 instead.
Summary (updated)
-----------------
Remove unnecessary patch after protobuf upgrade to 3.3.0.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/4/
Changes: https://reviews.apache.org/r/58513/diff/3-4/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.3.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated May 24, 2017, 4:16 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
Removed dependency on discarded review.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/4/
Testing
-------
Thanks,
Zhitao Li