You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/18 10:40:00 UTC

[GitHub] [maven] hboutemy commented on a diff in pull request #756: MNG-7501 display relative path to pom.xml

hboutemy commented on code in PR #756:
URL: https://github.com/apache/maven/pull/756#discussion_r900808391


##########
maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java:
##########
@@ -73,6 +83,7 @@ public void testProjectStarted()
         inOrder.verify( logger ).info( "" );
         inOrder.verify( logger ).info( "------------------< org.apache.maven:maven-embedder >-------------------" );
         inOrder.verify( logger ).info( "Building Apache Maven Embedder 3.5.4-SNAPSHOT" );
+        inOrder.verify( logger ).info( "    maven-embedder/pom.xml" );

Review Comment:
   I love "Building xxx \n from yyy"
   and it adds a clear reason to indentation to match "Building" length, not taste (that inherently varies between people)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org