You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "avamingli (via GitHub)" <gi...@apache.org> on 2026/03/02 09:20:24 UTC
Re: [PR] New contrib/fixeddecimal: add support for Cloudberry [cloudberry]
avamingli commented on code in PR #1584:
URL: https://github.com/apache/cloudberry/pull/1584#discussion_r2871324321
##########
contrib/fixeddecimal/test/expected/index.out:
##########
@@ -35,11 +43,13 @@ SELECT * FROM fixdec ORDER BY d;
(8 rows)
EXPLAIN (COSTS OFF) SELECT * FROM fixdec WHERE d = '12.34'::FIXEDDECIMAL;
- QUERY PLAN
--------------------------------------------
- Index Scan using fixdec_d_idx on fixdec
- Index Cond: (d = '12.34'::fixeddecimal)
-(2 rows)
+ QUERY PLAN
+------------------------------------------
+ Gather Motion 3:1 (slice1; segments: 3)
+ -> Seq Scan on fixdec
+ Filter: (d = '12.34'::fixeddecimal)
+ Optimizer: GPORCA
+(4 rows)
Review Comment:
Any explain about that?
##########
contrib/fixeddecimal/test/expected/index.out:
##########
@@ -10,16 +11,23 @@ INSERT INTO fixdec (id,d) VALUES(8, 123.45);
INSERT INTO fixdec (id,d) VALUES(9, 123.456);
-- Should fail
CREATE UNIQUE INDEX fixdec_d_idx ON fixdec (d);
-ERROR: could not create unique index "fixdec_d_idx"
-DETAIL: Key (d)=(123.45) is duplicated.
+ERROR: UNIQUE index must contain all columns in the table's distribution key
+DETAIL: Distribution key column "id" is not included in the constraint.
DELETE FROM fixdec WHERE id = 9;
CREATE UNIQUE INDEX fixdec_d_idx ON fixdec (d);
+ERROR: UNIQUE index must contain all columns in the table's distribution key
+DETAIL: Distribution key column "id" is not included in the constraint.
SET enable_seqscan = off;
EXPLAIN (COSTS OFF) SELECT * FROM fixdec ORDER BY d;
- QUERY PLAN
------------------------------------------
- Index Scan using fixdec_d_idx on fixdec
-(1 row)
+ QUERY PLAN
+---------------------------------------
+ Gather Motion 3:1 (slice1; segments: 3)
+ Merge Key: d
+ -> Sort
+ Sort Key: d
+ -> Seq Scan on fixdec
Review Comment:
Please fix that, not just copy the error into tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org