[GitHub] [pinot] 61yao commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1023389693


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) {
         return createSqlType(SqlTypeName.VARCHAR);
       case BYTES:
         return createSqlType(SqlTypeName.VARBINARY);
+      case BIG_DECIMAL:

Review Comment:
   If I remember the code correctly, this BIG_DECIMAL is not passed down correctly broker to server in the thrift protocol. This is also one of the reason I feel we should do integration test at broker level. 
   Can you help verify this? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org