You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/11/08 21:52:57 UTC

[PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

kou opened a new pull request, #44684:
URL: https://github.com/apache/arrow/pull/44684

   ### Rationale for this change
   
   The compute module uses the IPC module features for option serialization.
   
   ### What changes are included in this PR?
   
   Enable the IPC module when the compute module is enabled.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2571306839

   I close this in favor of GH-45171.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2467311059

   Just curious how did parquet support dependency to ARROW_IPC?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #44684: GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE
URL: https://github.com/apache/arrow/pull/44684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "jleibs (via GitHub)" <gi...@apache.org>.
jleibs commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2468477926

   This does not fix my issues.  I am explicitly setting:
   ```
   -DARROW_COMPUTE=OFF
   ```
   so the dependency on `ARROW_IPC` is irrelevant.
   
   The issue is that `[function_internal.cc](https://github.com/apache/arrow/blob/9105a4109a80a1c01eabb24ee4b9f7c94ee942cb/cpp/src/arrow/compute/function_internal.cc#L73)` is included in the build even if `ARROW_COMPUTE` is disabled.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2465808092

   :warning: GitHub issue #44563 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "jleibs (via GitHub)" <gi...@apache.org>.
jleibs commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2468483767

   See here:
   https://github.com/apache/arrow/blob/95b7181307fe133e8c84a0c0be2856ee15348b8e/cpp/src/arrow/CMakeLists.txt#L719C5-L799
   
   In short, there is a baseline level of compute functionality included regardless of the `ARROW_COMPUTE` flag,
   
   As far as I can tell `ARROW_COMPUTE` falg should actually be called something like `ARROW_COMPUTE_EXTRA`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2467320683

   It also uses the same approach:
   
   https://github.com/apache/arrow/blob/95b7181307fe133e8c84a0c0be2856ee15348b8e/cpp/cmake_modules/DefineOptions.cmake#L389-L393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2465809132

   @jleibs Could you try this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44684:
URL: https://github.com/apache/arrow/pull/44684#issuecomment-2506458662

   Ok, so perhaps we should simply return `Status::NotImplemented` from `GenericOptionsType::{Serialize,Deserialize}` if Arrow was compiled without IPC support?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org