You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/02/17 21:24:14 UTC
[GitHub] [commons-collections] Claudenw opened a new pull request #130:
Collections749 better documentation for signedness
Claudenw opened a new pull request #130: Collections749 better documentation for signedness
URL: https://github.com/apache/commons-collections/pull/130
Updated documentation for COLLECTIONS-749.
fixes COLLECTIONS-749.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] garydgregory commented on a change in pull
request #130: Collections749 better documentation for signedness
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #130: Collections749 better documentation for signedness
URL: https://github.com/apache/commons-collections/pull/130#discussion_r380754840
##########
File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java
##########
@@ -58,6 +58,10 @@
/**
* Identifies the signedness of the calculations for this function.
+ * <p>
+ * When the hash function executes it generally returns an array of bytes.
+ * That array is converted into one or more numerical values.
+ * The Signedness identifies if those values are signed or unsigned.
Review comment:
Close HTML tags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow commented on issue #130: Collections749
better documentation for signedness
Posted by GitBox <gi...@apache.org>.
kinow commented on issue #130: Collections749 better documentation for signedness
URL: https://github.com/apache/commons-collections/pull/130#issuecomment-605395558
ping @Claudenw, see @aherbert 's comment above :point_up:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] aherbert commented on issue #130:
Collections749 better documentation for signedness
Posted by GitBox <gi...@apache.org>.
aherbert commented on issue #130: Collections749 better documentation for signedness
URL: https://github.com/apache/commons-collections/pull/130#issuecomment-599639761
I think this PR is obsolete. Master now contains very similar text to that in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services