You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2026/06/23 00:01:09 UTC

Re: [PR] KAFKA-20116: Send task-(end)-offset to broker (3/N) [kafka]

mjsax commented on code in PR #21803:
URL: https://github.com/apache/kafka/pull/21803#discussion_r3456173457


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -520,7 +520,12 @@ public static StreamThread create(final TopologyMetadata topologyMetadata,
             clientSupplier,
             processId,
             consumerConfigs,
-            taskManager::taskOffsetSumSnapshot
+            taskManager::taskOffsetSumSnapshot,
+            // TODO (KAFKA-20116): wire a real per-task changelog end-offset supplier here.
+            // Empty placeholder for now lets us thread setTaskEndOffsets through the heartbeat builder
+            // and exercise the lag-comparison code path; with no end-offset entries, hasHotWarmupTask
+            // safely returns false (the broker simply can't compute lag yet).
+            Map::of

Review Comment:
   WIP via https://github.com/apache/kafka/pull/22608



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org