You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "syhleo (via GitHub)" <gi...@apache.org> on 2024/08/16 04:55:54 UTC
[PR] [ISSUE #8547] Add test coverage of ControllableOffset [rocketmq]
syhleo opened a new pull request, #8548:
URL: https://github.com/apache/rocketmq/pull/8548
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8547
### Brief Description
/
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
/
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8547] Coverage of ControllableOffset [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing commented on PR #8548:
URL: https://github.com/apache/rocketmq/pull/8548#issuecomment-2292907269
link #8262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8547] Add more test cases of ControllableOffset [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #8548:
URL: https://github.com/apache/rocketmq/pull/8548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8547] Add more test cases of ControllableOffset [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8548:
URL: https://github.com/apache/rocketmq/pull/8548#issuecomment-2292941982
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8548?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 46.95%. Comparing base [(`2d1e314`)](https://app.codecov.io/gh/apache/rocketmq/commit/2d1e3143c7dc60aca805e6689c5364825e3020d4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d3b3b08`)](https://app.codecov.io/gh/apache/rocketmq/commit/d3b3b082ddc94a239acd1c1ae5be809fa7916428?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 48 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8548 +/- ##
=============================================
+ Coverage 44.79% 46.95% +2.16%
- Complexity 10870 11328 +458
=============================================
Files 1274 1275 +1
Lines 88968 89101 +133
Branches 11434 11466 +32
=============================================
+ Hits 39853 41840 +1987
+ Misses 44130 42079 -2051
- Partials 4985 5182 +197
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8548?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org