You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/03 14:43:56 UTC
[GitHub] [flink] fapaul opened a new pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
fapaul opened a new pull request #18972:
URL: https://github.com/apache/flink/pull/18972
…teAsync is called
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
With FLINK-25206 it is possible to disallow configuration changes inside
the user program. Before this commit the validation only happened when
a job was executed synchronously and asynchronous submissions still
succeeded. Now, the asynchronous submission also fails.
## Brief change log
- Validate the configurations in the `executeAsync` method since it is the main entrypoint for the execution
## Verifying this change
Added a test to very `execute` and `executeAsync`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f0187e8f641bd9104f5d64087af1d6bde06931 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f0187e8f641bd9104f5d64087af1d6bde06931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
}, {
"hash" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505)
* e4cb01661266700467d17eb1a8ec8a5b26a6fc25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
}, {
"hash" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32547",
"triggerID" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4cb01661266700467d17eb1a8ec8a5b26a6fc25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32547)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f0187e8f641bd9104f5d64087af1d6bde06931 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501)
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f0187e8f641bd9104f5d64087af1d6bde06931 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501)
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18972:
URL: https://github.com/apache/flink/pull/18972#discussion_r818810304
##########
File path: docs/layouts/shortcodes/generated/deployment_configuration.html
##########
@@ -12,7 +12,7 @@
<td><h5>execution.allow-client-job-configurations</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Determines whether configurations in the user program are allowed when running with Application mode. Has no effect for other deployment modes.</td>
+ <td>Determines whether configurations in the user program are allowed. Depending on your deployment mode failing the job might have different affects. Either your client that is trying to submit the job to an external cluster (session cluster deployment) throws the exception or the Job manager (application mode deployment).</td>
Review comment:
I think there bust be an extra space here as well between `session` and `cluster`
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/DeploymentOptions.java
##########
@@ -112,6 +112,9 @@
.defaultValue(true)
.withDescription(
"Determines whether configurations in the user program are "
- + "allowed when running with Application mode. Has no effect for other "
- + "deployment modes.");
+ + "allowed. Depending on your deployment mode failing the job "
+ + "might have different affects. Either your client that is "
+ + "trying to submit the job to an external cluster (session "
+ + " cluster deployment) throws the exception or the Job "
Review comment:
```suggestion
+ "cluster deployment) throws the exception or the Job "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28f0187e8f641bd9104f5d64087af1d6bde06931 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501)
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
}, {
"hash" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32547",
"triggerID" : "e4cb01661266700467d17eb1a8ec8a5b26a6fc25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505)
* e4cb01661266700467d17eb1a8ec8a5b26a6fc25 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32547)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18972:
URL: https://github.com/apache/flink/pull/18972#issuecomment-1058144699
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32501",
"triggerID" : "28f0187e8f641bd9104f5d64087af1d6bde06931",
"triggerType" : "PUSH"
}, {
"hash" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505",
"triggerID" : "41dc5388514d8d2b8b76b3e752214be0134ffa62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41dc5388514d8d2b8b76b3e752214be0134ffa62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18972: [FLINK-26453][clients] Prevent program configurations also when execu…
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18972:
URL: https://github.com/apache/flink/pull/18972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org