[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3201: ARTEMIS-2820 Undeploy diverts by removing them from broker.xml

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3201:
URL: https://github.com/apache/activemq-artemis/pull/3201#discussion_r448336678



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
##########
@@ -448,6 +450,63 @@ public void testRedeployQueueDefaults() throws Exception {
       }
    }
 
+   @Test
+   public void testUndeployDivert() throws Exception {

Review comment:
       @jsmucr if you could check and fix RedeployTest::testUndeployDivert and testRedeployQueueDefaults
   
   with my latest PR merged 
   org.apache.activemq.artemis.tests.integration.client.UpdateQueueTest.testUpdateQueueWithNullUser is passing.
   
   
   But as you and Michael said something else seems to be going on.
   
   
   I won't release 2.14 for another week, so we have time to fix this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org