You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ole Solberg (JIRA)" <ji...@apache.org> on 2007/10/30 15:43:50 UTC
[jira] Created: (DERBY-3162) Create a framework for replication
tests
Create a framework for replication tests
----------------------------------------
Key: DERBY-3162
URL: https://issues.apache.org/jira/browse/DERBY-3162
Project: Derby
Issue Type: Sub-task
Components: Test
Affects Versions: 10.4.0.0
Reporter: Ole Solberg
Assignee: Ole Solberg
Priority: Minor
Handle
- starting and stopping Derby servers to have the master and slave replication roles,
- doing administrative commands like startreplication, startslave, stopreplication, failover,
- performing consistency checks on the slave vs. the master,
- running load clients against master and slave in the various states of replication,
- provoking error situations on master and slave, and network,
- ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573638#action_12573638 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
I tried to run the ReplicationRun_Local test, but in order for it to
run, I had to manually create the directories db_master and db_slave
for the test to run.
Since this patch does not affect people not working on replication, I
suggest that I commit the patch more or less as it is, and then we can
do I more thorough review afterwards.
Some initial comments based on a quick look at parts of the patch:
- I assume you did not intend to include the build.xml.orig file.
- Do you intend to document ReplicationRun_Local in
README.runningTests?
- I did not understand the following line in README.runningTests:
cd <testing dir>/ # ${user.dir}
- README.framework seems a bit out of date
- Some general observations:
- Several classes has a lot of unused imports.
- Many very long lines
- For some classes I miss an initial javadoc that explains the
purpose of the class.
- As far as I know, there should be only one exception per @throws
tag.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.8_v1_post641328.stat.txt
derby-3162.8_v1_post641328.diff.txt
Patch derby-3162.8_v1_post641328 for replication testing.
Main topics of this patch are
A: make replication tests run when starting with a
relative path for classpath. (2.1 and 2.5 below.)
B: Enable ReplicationSuite in suites.All (3. below)
1. java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/ReplicationSuite.java
.1 Added ReplicationRun_Local_1.suite() which does a simple consistency test
on contents in master and slave db's after replication.
2. java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/ReplicationRun.java
.1 Set user.dir and derby.system.home correctly when starting servers.
(StartServer())
.2 Minor cleanup on detecting we are running in a "localhost" environment.
.3 Cleanup some DEBUG.
.4 Do master and slave verification directly from the ReplicationRun VM.
(verifySlave(), verifyMaster())
.5 Set user.dir correctly when running existing JUnit tests as
"replication load".
(runUserCommandLocally())
3. java/testing/org/apache/derbyTesting/functionTests/suites/All.java
.1 Add ReplicationSuite.suite() to suites.All.
The patch has been tested on
Linux: jars: 1.4, 1.5, 1.6. classes: 1.4, 1.5, 1.6
rel.cp jars: 1.5, 1.6
Solaris: jars: 1.4, 1.5, 1.6
Windows: jars: 1.4, 1.5, 1.6
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt, derby-3162.8_v1_post641328.diff.txt, derby-3162.8_v1_post641328.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3162:
-----------------------------------
Derby Info: (was: [Patch Available])
Committed patch derby-3162.3-v3.diff.txt as revision 633466.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576322#action_12576322 ]
Ole Solberg commented on DERBY-3162:
------------------------------------
Thanks Øystein, for your comments and committing the patch!
> Øystein Grøvlen updated DERBY-3162:
> -----------------------------------
>
> Derby Info: (was: [Patch Available])
>
> Thanks for the new tests, Ole. I have committed the derby-3162.3-v4d.diff.txt patch as revision 634734.
>
> I think there is quite a few things that needs to be cleaned up, but I am still committing this as I think the tests are useful, and I have checked that it does not break the regression tests. I have not have time to verify that all state changes are covered, and I hope that other people could join in verifying this.
There is definitly quite some cleanup that needs to be done on theses tests and framework.
Your comments are all valid and useful!
>
> Some initial comments/questions:
>
> * When I run the junit regression test, I get the directories from
> the replication tests in the current directory. Most tests write
> to the system directory. (I know this is not the only test that
> violates this)
I will fix this.
>
> * Why is not the replication suite put in the suites package like all
> other suites?
I will fix this.
>
> * What would it take to run the replication tests with the security
> manager?
I must admit I have to investigate that.
>
> * I would prefer if the tests were given more meaningful names?
> part1a and part1b does not tell me very much what has been tested.
I agree.
>
> * Why is there only one test case per class? Would it not make sense
> to put all state tests into the same class?
I think that should be done.
>
> * Why has not part2 of the stat tests been added to the test suite?
But I think it is:
>From ReplicationSuite:
.
.
suite.addTest(ReplicationRun_Local_StateTest_part1_3.suite());
suite.addTest(ReplicationRun_Local_StateTest_part2.suite());
.
>
> * I had hoped that the same test classes could be used both for running
> locally and distributed, and that a property/parameter was used to
> determine how to run it. How much work will it be to enable that.
That is he intention. The framework and tests were initially written for and run
in a distributed context.
This patch has only been tested for running locally, and was specifically
meant to be useable for running the replication tests as part of suites.All.
For the distributed case the selection of server hosts, test to run etc.
are specified in a property file.
There should not be much work to (re)enable that.
>
> * What is the purpose of testReplication_CleanUp? It seems to only
> stop servers.
It is currently not used, should be removed.
>
> * All the methods with multiple parameters that all uses defaults,
> makes the tests less readable.
I agree.
>
> * I suggest using assertSQLState to check that the expected exception
> occurs.
I will change to that - I actually knew it were available so I should have used it!
>
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582285#action_12582285 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Patch 6 merged to 10.4 branch at revision 641302.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v4b.diff.txt
derby-3162.3-v4b.stat.txt
Patch derby-3162.3-v4b replaces derby-3162.3-v4.
Had forgotten to enable part of a test that would fail without DERBY-3358.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4.diff.txt, derby-3162.3-v4.stat.txt, derby-3162.3-v4b.diff.txt, derby-3162.3-v4b.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578480#action_12578480 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Patch derby-3162.5-v1.diff.txt merge to 10.4 branch as revision 636864.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.6_v1.stat.txt
derby-3162.6_v1.diff.txt
Patch 3162.6-v1 for replicationtests:
Fix to allow ReplicationSuite to run on JVM 1.4 and 1.5:
The replicationTest framework (ReplicationRun) used Drivermanager.getConnection()
to do startMaster=true and startSlave=true concurrently.
On 1.5 (and 1.4), but not on 1.6, it turned out that this caused a deadlock (on DriverManager.class?).
Using DataSource instead of DriverManager solved the problem.
Big thanks to Kristian Waagan who helped analyzing this!
The patch has been tested on
Linux: jars: 1.4, 1.5, 1.6. classes: 1.4, 1.5, 1.6
Solaris: jars: 1.4, 1.5, 1.6
Windows: jars: 1.4, 1.5, 1.6
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3162:
-----------------------------------
Derby Info: (was: [Patch Available])
Fix Version/s: 10.5.0.0
Patch derby-3162.5-v1.diff.txt committed as revision 636837.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.4-v1.stat.txt
derby-3162.4-v1.diff.txt
The patch derby-3162.4-v1 fixes the 'StringIndexOutOfBoundsException' seen on Windows
in the ReplicationSuite tests.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573860#action_12573860 ]
Daniel John Debrunner commented on DERBY-3162:
----------------------------------------------
Is this a new framework for executing tests or just a way of having junit tests that test replication?
>From README.runningTests it seems it is the latter, which is good.
Any reason why the tests need to start with no security manager set as a property instead of using the no security manager decorator. Then the test would be self contained like any other test.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582982#action_12582982 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Thanks for the derby-3162.8_v1_post641328.diff.txt patch, Ole.
I did some editing of indentation and long lines, and removed the declaration of an unused variable before committing it at revision 642193.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt, derby-3162.8_v1_post641328.diff.txt, derby-3162.8_v1_post641328.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.5-v1.stat.txt
derby-3162.5-v1.diff.txt
Patch derby-3162.5-v1 fixes several problems wrt. classpath, running on Windows, incorrect master or slave database path.
I ran ReplicationSuite (with jvm 1.6) on
- Linux: w/jars, w/classes
- Solaris: w/jars
- Windows: w/jars
The problem with relative classpath is not yet resolved.
I am seeing hangs when running with jvm 1.5, 1.4. Will create JIRAs for this.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.4-v3.stat.txt
derby-3162.4-v3.diff.txt
Patch derby-3162.4-v3 replaces derby-3162.4-v2.
This patch uses the complete classpath without attempting to run with a minimal classpath when starting servers etc.
I have successfully run ReplicationSuite against jar files AND against class files.
The patch still disables ReplicationSuite.suite() in suites.All.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574900#action_12574900 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Ole, thanks for the follow-up patch. I have some comments:
* ReplicationRun#startServer_direct: You have several attempts to set
the same properties. I think that is a bit confusing to the
reader.
* ReplicationRun_Full:
- suite() does addTestSuite(ReplicationRun.class). Is that the
right class? (Trying to run the class indicates that it is not.)
- Lots of unecessary imports. Only the junit packages seems to be
needed.
- No need to override setUp and tearDown when they only call the
overridden method.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg closed DERBY-3162.
------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Currently planned framework and tests for trunk and 10.4 branch are committed and used in nightly tests: Closing.
Additional improvements and additions will be traced by new JIRA issues.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt, derby-3162.8_v1_post641328.diff.txt, derby-3162.8_v1_post641328.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573820#action_12573820 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Patch v2 committed as revision 632371.
Looking forward to follow-up patches with discussed improvements.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3162:
-----------------------------------
Derby Info: (was: [Patch Available])
Thanks, Ole. Patch derby-3162.4-v3 committed as revision 635575.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.4-v1.diff.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584147#action_12584147 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Patch 8 merged to 10.4 branch at revision 643415..
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt, derby-3162.8_v1_post641328.diff.txt, derby-3162.8_v1_post641328.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.3-v4b.diff.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4b.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v4d.stat.txt
derby-3162.3-v4d.diff.txt
Patch 3162.3-v4d replaces 3162.3-v4c:
Added tests for the replication state after failover has been done.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576548#action_12576548 ]
V.Narayanan commented on DERBY-3162:
------------------------------------
>I am seeing messages like 'Warning: UnknkownHostException: OLESO-FERRARI: OLESO-FERRARI.'
>in connection with InetAddress.getByName(hostName) in ReplicationRun.pingServer.
I checked the ping code, seems harmless and also seems to conform to what NetworkServerControl
comments asks you to do
ping code -
ping( new NetworkServerControl(InetAddress.getByName(hostName),port), iterations);
NetworkServerControl comments -
This is an example of starting and shutting down the Network Server in the example
above with the API.
NetworkServerControl serverControl = new NetworkServerControl(InetAddress.getByName("myhost"),1621)
serverControl.shutdown();
Looks like a lookup failure in windows to me,
I am not sure that your code is at fault.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v2.diff.txt
derby-3162.3-v2.stat.txt
New patch 3162.3-v2, as 3162.3-v1, plus fixes for Javadoc warnings.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v1.diff.txt
derby-3162.3-v1.stat.txt
Patch derby-3162.3-v1 for replication test framework.
1. Handle that startMaster now correctly gets "XRE04" while slave is not yet ready after startSlave.
2. Create {user.dir}/[db_master|db_slave] if not existing.
3. Start servers via rt.exec().
4. New ReplicationRun_Full which handles the distributed case with replication state tests
and optional load on servers.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.3-v4b.stat.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.2-v2.stat.txt
derby-3162.2-v2.diff.txt
New patch for replication test framework and tests.
This patch combines and extends the previous patches on 3162 AND 3164 in ONE new patch.
This patch makes it possible to run replication tests with master and slave servers on localhost.
This variant, as implemented in the JUnit test o.a.dT.fT.tests.replicationTests.ReplicationRun_Local, does NOT depend on a propertyfile to specify hosts, ports, testhosts etc.
ReplicationRun_Local will run a small set of existing JUnit tests against the master server/database and as such is an initial regression test for replication.
The set of existing JUnit tests will be extended, and tests on behaviour of a replicated system in the different states of replication will be added in coming patches.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573913#action_12573913 ]
Ole Solberg commented on DERBY-3162:
------------------------------------
This is a way of having junit tests that test replication.
Starting with no security manager set as a property is really "old habit" by me..... Will look into using the no security manager decorator.
Thanks for the hint!
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.4-v1.stat.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v4.stat.txt
derby-3162.3-v4.diff.txt
Patch 3162.3-v4 for testing replication:
- Added tests for checking replication command behaviour in
different states of replication.
(ReplicationRun_Local_StateTest_part*)
- Added 'ReplicationSuite.suite()' at end of .../suites/All.java.
That is, the replication test will be run as part of suites.All.
- replication tests now uses 'SecurityManagerSetup.noSecurityManager()'.
- changed replication test trace output to use Utils.DEBUG().
Can be turned on by '-Dderby.tests.repltrace=true'.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4.diff.txt, derby-3162.3-v4.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580397#action_12580397 ]
Dyre Tjeldvoll commented on DERBY-3162:
---------------------------------------
This issue has 10.5 as fixversion. Should it not be 10.4?
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.4-v2.stat.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3162:
-----------------------------------
Derby Info: (was: [Patch Available])
Patch 6 committed at revision 640506
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573641#action_12573641 ]
V.Narayanan commented on DERBY-3162:
------------------------------------
> Several classes has a lot of unused imports.
IDE's (I use Netbeans) support a fix imports feature that automatically
removes the
imports that are not used. Since these are new classes that are
introduced you could use
this feature safely without any fear of generating diffs that may be
unrelated to your feature.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4.diff.txt, derby-3162.3-v4.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.4-v2.diff.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3162:
-----------------------------------
Derby Info: (was: [Patch Available])
Thanks for the new tests, Ole. I have committed the derby-3162.3-v4d.diff.txt patch as revision 634734.
I think there is quite a few things that needs to be cleaned up, but I am still committing this as I think the tests are useful, and I have checked that it does not break the regression tests. I have not have time to verify that all state changes are covered, and I hope that other people could join in verifying this.
Some initial comments/questions:
* When I run the junit regression test, I get the directories from
the replication tests in the current directory. Most tests write
to the system directory. (I know this is not the only test that
violates this)
* Why is not the replication suite put in the suites package like all
other suites?
* What would it take to run the replication tests with the security
manager?
* I would prefer if the tests were given more meaningful names?
part1a and part1b does not tell me very much what has been tested.
* Why is there only one test case per class? Would it not make sense
to put all state tests into the same class?
* Why has not part2 of the stat tests been added to the test suite?
* I had hoped that the same test classes could be used both for running
locally and distributed, and that a property/parameter was used to
determine how to run it. How much work will it be to enable that.
* What is the purpose of testReplication_CleanUp? It seems to only
stop servers.
* All the methods with multiple parameters that all uses defaults,
makes the tests less readable.
* I suggest using assertSQLState to check that the expected exception
occurs.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v3.diff.txt
derby-3162.3-v3.stat.txt
Øystein, thanks for your comments.
Patch 3162.3-v3 should handle your comments on ReplicationRun#startServer_direct and ReplicationRun_Full.
I will treat similar problems in other classes in follow up patches. Thanks again!
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.3-v4.stat.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4b.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.1-v1.diff.txt
First version of a a framework for running replication tests.
Depends on derby-3163.1-v1.diff.txt.
+ java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/ReplicationRun.java
+ java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/build.xml
M java/testing/build.xml:
+ <ant dir="${derby.testing.src.dir}/${derby.testing.functest.dir}/tests/replicationTests"/>
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: (was: derby-3162.3-v4.diff.txt)
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4b.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573747#action_12573747 ]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
I have looked a bit closer at the ReplicationRun class, and I have
some comments. Note, however, as I said in my previous comment, if
you like, I can commit the existing patch and you can work on the
improvements in follow-up patches. Some comments:
- I must admit that it took me some time to understand how I should
go about to add new tests, but if I understand it correctly, the
way to do it is to subclass ReplicationRun for my test class and
use the methods of ReplicationRun to initiate replication. I miss
some instructions on how to go about writing new tests in this
framework.
- I feel it is a bit confusing that ReplicationRun seems to be both a
framework and a test. I think it would be better if the methods
used to perform replication operations were separated from actual
test cases.
- I also think it would be a good idea to separate the code for
testing with localhost from the code for testing with master and
slaves on different hosts. In other words, I suggest having two
classes (with a common base class), one for local testing and one
for distributed testing both implementing the same set of methods
like startServer, initMaster etc.
- I miss some documentation of all the static fields in
ReplicationRun.
- Many of the fields are both initialized when they are declared and
in initEnvironment. It seems a bit errorprone to duplicate this.
- Why is masterServerHost etc. set to localhost in ReplicationRun? I
thought that was supposed to be behavior that were specific to
ReplicationRun_Local.
- I think the classes Utils and State should be given more specific
names.
- I think it is a source of confusion that both ReplicationRun and
its inner class State contains a method called initEnvironment. By
the way, the State does not currently seem to be in use.
- Some unused imports: FileChannel, Inet6Address, JDBC
- I am not sure it is a good idea to import whole packages. At
least for java.util, Properties seems to be the only class used.
Why not import just that class.
- The freezeDB string is empty. Note that you still need to freeze
the database when replication is started.
- Some comments have references to PoC. I guess that is obsolete.
- Does masterServer and slaveServer need to be declared at class
level? They seem to be local to the test case when they are used.
- Why implement setUp and tearDown when they only call the
corresponding method in the super class?
- The file name README.properties is a bit awkward since IDEs and
other tools may think it is a properties file, which it is not.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577027#action_12577027 ]
Jørgen Løland commented on DERBY-3162:
--------------------------------------
I encountered an issue with the classpath. I use this setup in all my sandboxes:
sandbox
|-- test
| |-- oldharness
| `-- junit
`-- trunk
When I run the replication test suite from the junit directory with classpath=../../trunk/jars/sane, I get a
java.lang.NoClassDefFoundError: org/apache/derby/drda/NetworkServerControl
If I replace the classpath with the absolute path ( /home/.../trunk/jars/sane), the problem goes away.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.3-v4c.stat.txt
derby-3162.3-v4c.diff.txt
Patch 3162.3-v4c replaces 3162.3-v4b: enabling more test cases in TestPreStartedMaster.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4.diff.txt, derby-3162.3-v4.stat.txt, derby-3162.3-v4b.diff.txt, derby-3162.3-v4b.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573764#action_12573764 ]
Ole Solberg commented on DERBY-3162:
------------------------------------
Thanks Øystein for reviewing this!
> Øystein Grøvlen commented on DERBY-3162:
> ----------------------------------------
>
> I tried to run the ReplicationRun_Local test, but in order for it to
> run, I had to manually create the directories db_master and db_slave
> for the test to run.
I missed that one, probably because I have been running in the same dirs all the time so it was always there...
>
> Since this patch does not affect people not working on replication, I
> suggest that I commit the patch more or less as it is, and then we can
> do I more thorough review afterwards.
I would appreciate that. It will probably make it easier to incrementally do all the required enhancements and fixes pointed out below.
>
> Some initial comments based on a quick look at parts of the patch:
>
> - I assume you did not intend to include the build.xml.orig file.
Can't find that in my sandbox!
>
> - Do you intend to document ReplicationRun_Local in
> README.runningTests?
I will.
>
> - I did not understand the following line in README.runningTests:
> cd <testing dir>/ # ${user.dir}
I'll clean that up (I probably meant that ${user.dir} would be <testing dir>.)
>
> - README.framework seems a bit out of date
Will fix.
>
> - Some general observations:
> - Several classes has a lot of unused imports.
> - Many very long lines
> - For some classes I miss an initial javadoc that explains the
> purpose of the class.
> - As far as I know, there should be only one exception per @throws
> tag.
>
> Øystein Grøvlen commented on DERBY-3162:
> ----------------------------------------
>
> I have looked a bit closer at the ReplicationRun class, and I have
> some comments. Note, however, as I said in my previous comment, if
> you like, I can commit the existing patch and you can work on the
> improvements in follow-up patches. Some comments:
>
> - I must admit that it took me some time to understand how I should
> go about to add new tests, but if I understand it correctly, the
> way to do it is to subclass ReplicationRun for my test class and
> use the methods of ReplicationRun to initiate replication. I miss
> some instructions on how to go about writing new tests in this
> framework.
Yes, that is the intention. I agree instructions should be enhanced.
>
> - I feel it is a bit confusing that ReplicationRun seems to be both a
> framework and a test. I think it would be better if the methods
> used to perform replication operations were separated from actual
> test cases.
The test part should be removed.
>
> - I also think it would be a good idea to separate the code for
> testing with localhost from the code for testing with master and
> slaves on different hosts. In other words, I suggest having two
> classes (with a common base class), one for local testing and one
> for distributed testing both implementing the same set of methods
> like startServer, initMaster etc.
Yes, when looking at this now I tend to agree. I started out creating the framework (and test) for the distributed case and the "localhost case" was added later.
>
> - I miss some documentation of all the static fields in
> ReplicationRun.
Will add.
>
> - Many of the fields are both initialized when they are declared and
> in initEnvironment. It seems a bit errorprone to duplicate this.
Thanks for pointing this out - I have stared too long at this code alone I guess ;-)
>
> - Why is masterServerHost etc. set to localhost in ReplicationRun? I
> thought that was supposed to be behavior that were specific to
> ReplicationRun_Local.
Ditto.
>
> - I think the classes Utils and State should be given more specific
> names.
Will fix.
>
> - I think it is a source of confusion that both ReplicationRun and
> its inner class State contains a method called initEnvironment. By
> the way, the State does not currently seem to be in use.
Will clean up this.
>
> - Some unused imports: FileChannel, Inet6Address, JDBC
>
> - I am not sure it is a good idea to import whole packages. At
> least for java.util, Properties seems to be the only class used.
> Why not import just that class.
Thanks for pointing this out.
>
> - The freezeDB string is empty. Note that you still need to freeze
> the database when replication is started.
Will clean up.
>
> - Some comments have references to PoC. I guess that is obsolete.
Will clean up.
>
> - Does masterServer and slaveServer need to be declared at class
> level? They seem to be local to the test case when they are used.
Thanks for pointing this out.
>
> - Why implement setUp and tearDown when they only call the
> corresponding method in the super class?
Thanks for pointing this out.
>
> - The file name README.properties is a bit awkward since IDEs and
> other tools may think it is a properties file, which it is not.
Thanks! did not think of that!
>
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt, derby-3162.8_v1_post641328.diff.txt, derby-3162.8_v1_post641328.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Fix Version/s: (was: 10.5.0.0)
10.4.0.0
Changed fix version to 10.4
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v3.diff.txt, derby-3162.4-v3.stat.txt, derby-3162.5-v1.diff.txt, derby-3162.5-v1.stat.txt, derby-3162.6_v1.diff.txt, derby-3162.6_v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Derby Info: [Patch Available]
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3162) Create a framework for replication
tests
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3162:
-------------------------------
Attachment: derby-3162.4-v2.stat.txt
derby-3162.4-v2.diff.txt
Patch derby-3162.4-v2 replaces derby-3162.4-v1:
This patch fixes some stupid classpath / pathSeparator problems which
also showed up on Windows.
I do however still have trouble running the tests on Windows:
I am seeing messages like 'Warning: UnknkownHostException: OLESO-FERRARI: OLESO-FERRARI.'
in connection with InetAddress.getByName(hostName) in ReplicationRun.pingServer.
The patch therefore comments out the replication suite from suites.All.
'org.apache.derbyTesting.functionTests.tests.replicationTests.ReplicationSuite' must thus be run
separatly.
I am sorry for the inconvenience :-(
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt, derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt, derby-3162.3-v3.diff.txt, derby-3162.3-v3.stat.txt, derby-3162.3-v4c.diff.txt, derby-3162.3-v4c.stat.txt, derby-3162.3-v4d.diff.txt, derby-3162.3-v4d.stat.txt, derby-3162.4-v1.diff.txt, derby-3162.4-v1.stat.txt, derby-3162.4-v2.diff.txt, derby-3162.4-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3162) Create a framework for replication
tests
Posted by "A B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574720#action_12574720 ]
A B commented on DERBY-3162:
----------------------------
A few javadoc warnings that have arisen from commits for this issue:
[javadoc] java\testing\org\apache\derbyTesting\functionTests\tests\replicationTests\Utils.java:62: warning - @return tag cannot be used in method with void return type.
[javadoc] java\testing\org\apache\derbyTesting\functionTests\tests\replicationTests\Utils.java:135: warning - @return tag cannot be used in method with void return type.
[javadoc] java\testing\org\apache\derbyTesting\functionTests\tests\replicationTests\Utils.java:147: warning - @param argument "srcPath" is not a parameter name.
[javadoc] java\testing\org\apache\derbyTesting\functionTests\tests\replicationTests\Utils.java:147: warning - @param argument "destPath" is not a parameter name.
[javadoc] java\testing\org\apache\derbyTesting\functionTests\tests\replicationTests\Utils.java:147: warning - @return tag cannot be used in method with void return type.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave replication roles,
> - doing administrative commands like startreplication, startslave, stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.