You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/30 06:57:00 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #2037: [CALCITE-3834] Support AntiJoin in EnumerableMergeJoin

rubenada commented on a change in pull request #2037:
URL: https://github.com/apache/calcite/pull/2037#discussion_r447452267



##########
File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -3878,6 +3879,8 @@ public void remove() {
     private final Comparator<TKey> comparator;
     private boolean done;
     private Enumerator<TResult> results;
+    // only used for ANTI join: if right input is over, all remaining elements from left are results
+    private boolean remainingLeft;

Review comment:
       Correct, it means the right input is over, but the left is not; hence all remaining tuples from the left relation are results for the anti-join




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org