You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2026/07/06 09:01:09 UTC
[PR] [CI] Try to debug ccache not ccaching anything on Windows + MSVC [arrow]
pitrou opened a new pull request, #50387:
URL: https://github.com/apache/arrow/pull/50387
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
* [AI-generated Code Guidance](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code)
Please remove this line and the above text before creating your pull request.
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4892785261
+1, that is a significant improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Try to debug ccache not ccaching anything on Windows + MSVC [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4890950126
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4894308727
I've enabled the C++ Extra tests to check that it also works on ARM64 Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4909915987
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ce1915a915b93fb60c3caed78a307bbe7cc0f35c.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/85752044918) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4893202804
The CMake code worked properly. I think that it's broken when we use CMake 3.25 or later. I think that CMake 3.25 introduced `CMAKE_MSVC_DEBUG_INFORMATION_FORMAT` and removed `/Zi` from `CMAKE_C{,XX}_FLAGS*`.
So we should use `CMAKE_MSVC_DEBUG_INFORMATION_FORMAT` instead of the existing `/Zi` -> `/Z7` code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4895390847
Ok, cache is now effective on ARM64 Windows as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #50387:
URL: https://github.com/apache/arrow/pull/50387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50388: [C++][CI] Make ccache effective MSVC-based builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50387:
URL: https://github.com/apache/arrow/pull/50387#issuecomment-4892866019
> +1
>
> Could you remove
Interesting, I hadn't noticed this piece of CMake code. I assume it wasn't working properly? (perhaps the option was passed as `-Zi` rather than `/Zi`?).
Do you think we should set CMAKE_MSVC_DEBUG_INFORMATION_FORMAT in https://github.com/apache/arrow/blob/5bf8934eb3cfbb82433a95e13ba4cf1355da0b1b/cpp/cmake_modules/SetupCxxFlags.cmake#L238 rather than in individual CI config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org